From nobody Sat May 18 23:44:16 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+67327+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67327+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1605134950; cv=none; d=zohomail.com; s=zohoarc; b=Ttc0Cfj75YUMbdbHLckQb8WU1BEVeij4+2X3yKdGitGiRSdp6CxByCSlzcbmOrYTbN/hAcyxc9BthusXtRa8JHh82rqvs+hsLxEJETHclJhTpZuYQ9/cPC1BI2LML26diDFYAVUCSX+dxg/UwHTzVlHvo8OW0rmNz4bbaCdqggM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1605134950; h=Content-Transfer-Encoding:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=zeReApU6+xWH3kxxcaVVkR9jb/rLUiGgSlmzJM/CtnQ=; b=QE0EYHxNFe79NmN0XAtUfIg0rz5QExgD8vyk0nNrZntxew51FwyULJ8EAxGfcs9smFkeJVVhiYuQSkEUQVUiOvTNiF4A3rP8Z5nRR2lNHIn5sx03g7dnyzhYbZjqR1jL4cLBTxsBT2NHlXd+Mv9dyaoAOQo5qGdFLztkC2JA0xQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+67327+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1605134950876911.3209477216601; Wed, 11 Nov 2020 14:49:10 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id HRjhYY1788612xxBEGP6V0ox; Wed, 11 Nov 2020 14:49:10 -0800 X-Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.11366.1605120563582986544 for ; Wed, 11 Nov 2020 10:49:23 -0800 IronPort-SDR: Trua1XcISSHWxCU+znOkJqrf5SZhZU08scl/4e9PiQkh3Wz7hFFwJ4A7J62sldcBtBX8aHTjxL rPnp0OnKfFUw== X-IronPort-AV: E=McAfee;i="6000,8403,9802"; a="188180886" X-IronPort-AV: E=Sophos;i="5.77,470,1596524400"; d="scan'208";a="188180886" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 10:49:22 -0800 IronPort-SDR: LjpfnxVVj8xo4XKdOFVzxgPLzruG8AMM+nFpTCMVCsAHNHoGKcR1sYjOcu5c1PmuCacvi2uw9S /CHYE7mP9Wow== X-IronPort-AV: E=Sophos;i="5.77,470,1596524400"; d="scan'208";a="531817139" X-Received: from fm73lab146.amr.corp.intel.com ([10.121.84.165]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Nov 2020 10:49:22 -0800 From: Nishant Mistry To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Index to the RpmcLib Date: Wed, 11 Nov 2020 10:49:09 -0800 Message-Id: <661e44cf628ae7315fc738b64a52736f6b5b5285.1605047447.git.nishant.c.mistry@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nishant.c.mistry@intel.com X-Gm-Message-State: 140OHGhe5TtHmDk15pdx1N9ix1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1605134950; bh=MVzLdC+Dtnm9uXQENb2MNGb4eCVY6/8UdWaLECYST9I=; h=Date:From:Reply-To:Subject:To; b=FyEoRXDF9dgZx5D2QFZZq86f9QDAqt4aQL31xlNoQ7asTxAfRLpZPEHFbH3Da/Dkxbn chvSX2Oghqn4KCmW5gIsp6Q5/3OT40RoHv52UconjxKDFYn21WWts8qBLszOw/6fSOqrr mHzsggds0W4O5bVZLiPQsJ1K7sBQhMPr6aA= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2594 The re-design requires multiple RPMC counter usages. The consumer will be capable of selecting amongst multiple counters. Signed-off-by: Nishant C Mistry Reviewed-by: Jian J Wang --- SecurityPkg/Include/Library/RpmcLib.h | 6 +++++- SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 6 +++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/SecurityPkg/Include/Library/RpmcLib.h b/SecurityPkg/Include/Li= brary/RpmcLib.h index 5882bfae2f..3c15bce1ce 100644 --- a/SecurityPkg/Include/Library/RpmcLib.h +++ b/SecurityPkg/Include/Library/RpmcLib.h @@ -14,6 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent /** Requests the monotonic counter from the designated RPMC counter. =20 + @param[in] CounterIndex The RPMC index @param[out] CounterValue A pointer to a buffer to store the= RPMC value. =20 @retval EFI_SUCCESS The operation completed successful= ly. @@ -23,12 +24,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent EFI_STATUS EFIAPI RequestMonotonicCounter ( + IN UINT8 CounterIndex, OUT UINT32 *CounterValue ); =20 /** Increments the monotonic counter in the SPI flash device by 1. =20 + @param[in] CounterIndex The RPMC index + @retval EFI_SUCCESS The operation completed successful= ly. @retval EFI_DEVICE_ERROR A device error occurred while atte= mpting to update the counter. @retval EFI_UNSUPPORTED The operation is un-supported. @@ -36,7 +40,7 @@ RequestMonotonicCounter ( EFI_STATUS EFIAPI IncrementMonotonicCounter ( - VOID + IN UINT8 CounterIndex ); =20 #endif diff --git a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c b/SecurityPkg/Li= brary/RpmcLibNull/RpmcLibNull.c index e1dd09eb10..697e493a7c 100644 --- a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c +++ b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c @@ -12,6 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent /** Requests the monotonic counter from the designated RPMC counter. =20 + @param[in] CounterIndex The RPMC index @param[out] CounterValue A pointer to a buffer to store the= RPMC value. =20 @retval EFI_SUCCESS The operation completed successful= ly. @@ -21,6 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent EFI_STATUS EFIAPI RequestMonotonicCounter ( + IN UINT8 CounterIndex, OUT UINT32 *CounterValue ) { @@ -31,6 +33,8 @@ RequestMonotonicCounter ( /** Increments the monotonic counter in the SPI flash device by 1. =20 + @param[in] CounterIndex The RPMC index + @retval EFI_SUCCESS The operation completed successful= ly. @retval EFI_DEVICE_ERROR A device error occurred while atte= mpting to update the counter. @retval EFI_UNSUPPORTED The operation is un-supported. @@ -38,7 +42,7 @@ RequestMonotonicCounter ( EFI_STATUS EFIAPI IncrementMonotonicCounter ( - VOID + IN UINT8 CounterIndex ) { ASSERT (FALSE); --=20 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#67327): https://edk2.groups.io/g/devel/message/67327 Mute This Topic: https://groups.io/mt/78195042/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-