From nobody Sat Apr 20 00:56:58 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+94113+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94113+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1663832185; cv=none; d=zohomail.com; s=zohoarc; b=FpUefdpkb6/iSwIkPMxlXM7tvW3Ss9zk1esrMGMMWJpE2qKsDyg03g3vUgZ7HxeD3XTzVZZn5EPadHln4rmRGwUCCUZzFta/eheuXNUZ2bWa06bSJUr5/SW1Ww6ApEMJv/if8MYydf3oa/qwtStCHHbwtP6KIdmr4B6CRUjdCeA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1663832185; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=ylY0h2UNw1GZECbCuGV5nBE7fiXNvZKf4FgKGaK82TY=; b=RqH8z/ReUnxdK7yE/jnxL90PHWMskPNMdx/Is58hgmacKVz4jmyNIoIaycFhWh2i6znfruz0TM/a6m1Urex82WJ+i1avwrVanRDGuweECb/tJIwk2k8WczUVhhqn5YLKbaQlwuDdo47+twju3Yd6mc7m5CAojeAUvEUX47fphfs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+94113+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1663832185276985.9736574144503; Thu, 22 Sep 2022 00:36:25 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id ffKxYY1788612x1CctbEMQ6o; Thu, 22 Sep 2022 00:36:24 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web09.4492.1663832184050949725 for ; Thu, 22 Sep 2022 00:36:24 -0700 X-IronPort-AV: E=McAfee;i="6500,9779,10477"; a="283275811" X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="283275811" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 00:36:21 -0700 X-IronPort-AV: E=Sophos;i="5.93,335,1654585200"; d="scan'208";a="621993658" X-Received: from rodrigog-mobl.amr.corp.intel.com ([10.254.12.189]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2022 00:36:21 -0700 From: "Rodrigo Gonzalez del Cueto" To: devel@edk2.groups.io Cc: "Gonzalez Del Cueto, Rodrigo" , Jiewen Yao , Jian J Wang Subject: [edk2-devel] [PATCH] SecurityPkg: Remove enforcement of final GoIdle transition for CRB commands Date: Thu, 22 Sep 2022 00:35:36 -0700 Message-Id: <5f134d299f44f162f7ae7537a0f8c6783210fbea.1663832124.git.rodrigo.gonzalez.del.cueto@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rodrigo.gonzalez.del.cueto@intel.com X-Gm-Message-State: OyWYQxIUN3p6uBBYbxQajvYvx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1663832184; bh=XLoVIk+fG/qQcnZyX8TLWz0EelqTy4vWEYHM7SkAlIQ=; h=Cc:Date:From:Reply-To:Subject:To; b=tEcuUHGUEIDauXtX0MtBJXw2TQAeTfz9WPbjWz8vftg2lErmqKhzRhbUxbbHhudCG4+ Fp9eSoDFlzYSr32G+/uvB4Qjua2yX5B+8pHGRLRcRMoU64WUn8Nnj/rF6RUx25wbmElKY XcQ55kHgVkhgxN6TKpG1lsLGLx5DuRxjVZo= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1663832185960100001 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4077 Following the design described in the TCG specification, the driver implementation of the CRB protocol does not require enforcing completing the transition to goIdle at the end of a command sequence. Signed-off-by: "Gonzalez Del Cueto, Rodrigo" Cc: Jiewen Yao Cc: Jian J Wang --- SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c b/SecurityPkg/= Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c index 840265292a..1f9ac5ab5a 100644 --- a/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c +++ b/SecurityPkg/Library/Tpm2DeviceLibDTpm/Tpm2Ptp.c @@ -381,19 +381,6 @@ GoIdle_Exit: // MmioWrite32 ((UINTN)&CrbReg->CrbControlRequest, PTP_CRB_CONTROL_AREA_REQ= UEST_GO_IDLE); =20 - // - // Only enforce Idle state transition if execution fails when CRBIdleByp= ass=3D=3D1 - // Leave regular Idle delay at the beginning of next command execution - // - if (GetCachedIdleByPass () =3D=3D 1) { - Status =3D PtpCrbWaitRegisterBits ( - &CrbReg->CrbControlStatus, - PTP_CRB_CONTROL_AREA_STATUS_TPM_IDLE, - 0, - PTP_TIMEOUT_C - ); - } - return Status; } =20 --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94113): https://edk2.groups.io/g/devel/message/94113 Mute This Topic: https://groups.io/mt/93843955/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-