From nobody Fri May 3 17:10:10 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+47297+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47297+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=yandex.ru ARC-Seal: i=1; a=rsa-sha256; t=1568660039; cv=none; d=zoho.com; s=zohoarc; b=F8LEdXLcZZfN0VyCo2rS/6xTUUOpA59R8AZZ5oVslnOtAl2rW51CxnjV25Xw9uwvMIlNThKak0H56lQ4FCHuyh/u+e0HnTJMMrvHcLn+qa1+OHL4Ac/xVtLSWqhDgtNzphH0i8mTfksv/4o15rsmCZiZIV4jLjeipC0Ay8TlDgo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zoho.com; s=zohoarc; t=1568660039; h=Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To:ARC-Authentication-Results; bh=hyhF6TZ7J1P8tH2760aJadMwY3mrxh/G2wAS3FnNMx4=; b=IWIwG2FLfvz8TApy/uzMMPWVSsYmm4gJ/B8nAT5n40GAsw609gM0Ug3xM8UosqDiP+064FfUamc0pPvFnUjXF95DD6yjNE85znvknP2kM0D9RF1GZ5ZGcVg9rjO9EUonTvaXdMn3Fg8Sro2EQ1TjvH5Y9Jh3ohjXzef7ioVbIyE= ARC-Authentication-Results: i=1; mx.zoho.com; dkim=pass; spf=pass (zoho.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+47297+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1568660039575833.7619601650038; Mon, 16 Sep 2019 11:53:59 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id Gyr4YY1788612xOT7beN1TV2; Mon, 16 Sep 2019 11:53:59 -0700 X-Received: from forward106o.mail.yandex.net (forward106o.mail.yandex.net [37.140.190.187]) by groups.io with SMTP; Mon, 16 Sep 2019 07:21:57 -0700 X-Received: from mxback27g.mail.yandex.net (mxback27g.mail.yandex.net [IPv6:2a02:6b8:0:1472:2741:0:8b7:327]) by forward106o.mail.yandex.net (Yandex) with ESMTP id 966075060EB3; Mon, 16 Sep 2019 17:21:54 +0300 (MSK) X-Received: from sas2-b0ca3cd64eaa.qloud-c.yandex.net (sas2-b0ca3cd64eaa.qloud-c.yandex.net [2a02:6b8:c14:718c:0:640:b0ca:3cd6]) by mxback27g.mail.yandex.net (nwsmtp/Yandex) with ESMTP id kPx2OvOYTc-Ls7CTJvH; Mon, 16 Sep 2019 17:21:54 +0300 X-Received: by sas2-b0ca3cd64eaa.qloud-c.yandex.net (nwsmtp/Yandex) with ESMTPSA id FpUiSlrZG7-LrI0VEII; Mon, 16 Sep 2019 17:21:53 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) From: Gris87 To: devel@edk2.groups.io Cc: Gris87 , Ruiyu Ni Subject: [edk2-devel] [PATCH] MdeModulePkg: Add missing sourceX for Blt Date: Mon, 16 Sep 2019 14:21:47 +0000 Message-Id: <583ec11aa07d5f93113237da627d058c5672c322.1568643322.git.Gris87@yandex.ru> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,Gris87@yandex.ru X-Gm-Message-State: ZHZ47wERvw1hUgo7rty8g9MSx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1568660039; bh=g1THalVezBXNnFesL6Qp163ZBFVfarqokztOxRK9r/c=; h=Cc:Date:From:Reply-To:Subject:To; b=vmtNZEro0RvWie1CJvEQ5wSoch5O0Alyps/i47StwyJidxhhNuLsghKRp6EgQtjET/2 3yWbsdDrb4ZSFTR7icm6r4K2iVtu3Tw5/UEqzcqYzP0SNkxErEvR+Zgum16eOnvWpxx9a Fb3eqx7azN0+WmyNmiVjiDg4KU4S6CDFWyk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Type: text/plain; charset="utf-8" There is no sourceX offset in case when Configure->PixelFormat =3D=3D PixelBlueGreenRedReserved8BitPerColor. We are copying most left pixels instead of copying required rectangle. Signed-off-by: Gris87 Cc: Ruiyu Ni Reviewed-by: Zhichao Gao Tested-by: Zhichao Gao --- MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c b/M= deModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c index 47c5326e99..ff7979c962 100644 --- a/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c +++ b/MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c @@ -504,7 +504,7 @@ FrameBufferBltLibBufferToVideo ( Destination =3D Configure->FrameBuffer + Offset; =20 if (Configure->PixelFormat =3D=3D PixelBlueGreenRedReserved8BitPerColo= r) { - Source =3D (UINT8 *) BltBuffer + (SrcY * Delta); + Source =3D (UINT8 *) BltBuffer + (SrcY * Delta) + SourceX * sizeof (= EFI_GRAPHICS_OUTPUT_BLT_PIXEL); } else { for (IndexX =3D 0; IndexX < Width; IndexX++) { Blt =3D --=20 2.19.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#47297): https://edk2.groups.io/g/devel/message/47297 Mute This Topic: https://groups.io/mt/34168097/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-