From nobody Sat May 4 22:29:19 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+68650+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68650+1787277+3901457@groups.io ARC-Seal: i=1; a=rsa-sha256; t=1607593048; cv=none; d=zohomail.com; s=zohoarc; b=luwPgIwxMJweMQpfcTbMQIyOU6wYVBkHqgIX3SLIla8ZhC/IQ7Gkw5eAyht2xZo2BCXcIsuYbS+fTUv7mH2sIcJMu6yO9M8TtP9TBh7VoprOA8Blg5MYUEf1quT+paCH1MbhlvsK6LgxPU1frkqhyMknt+jvmtbYSrs1cjzz5ow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1607593048; h=Content-ID:Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Id:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=Oc/gNtw15OSPcscEBW6XOrJznukSMq5vOpr2ePAh3Os=; b=jZ9fyY0upoyOFLWwteKgSUV4YtpIhn+EAmK3QKnypVcrvZwxpPgdYiOngGRyHbKmTCQKK7fMAGW/l9EA8fyRjFxnM6GqbiMyffhWk6WA8U53w2n5gLCi9T2VVpkmKsxX3LLGKs1kKXpgl91O8/sHZZKOOJfmbOIxlmtpBRiFmf4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+68650+1787277+3901457@groups.io Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1607593048871595.5195686187346; Thu, 10 Dec 2020 01:37:28 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id mG3DYY1788612xKMM92ohBFU; Thu, 10 Dec 2020 01:37:28 -0800 X-Received: from smtp-fw-6001.amazon.com (smtp-fw-6001.amazon.com [52.95.48.154]) by mx.groups.io with SMTP id smtpd.web09.4838.1607511361421464504 for ; Wed, 09 Dec 2020 02:56:01 -0800 X-IronPort-AV: E=Sophos;i="5.78,405,1599523200"; d="scan'208,223";a="71481421" X-Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-1a-807d4a99.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-6001.iad6.amazon.com with ESMTP; 09 Dec 2020 10:55:53 +0000 X-Received: from EX13MTAUEE001.ant.amazon.com (iad12-ws-svc-p26-lb9-vlan2.iad.amazon.com [10.40.163.34]) by email-inbound-relay-1a-807d4a99.us-east-1.amazon.com (Postfix) with ESMTPS id 96578A1EBB for ; Wed, 9 Dec 2020 10:55:52 +0000 (UTC) X-Received: from EX13D08UEE004.ant.amazon.com (10.43.62.182) by EX13MTAUEE001.ant.amazon.com (10.43.62.226) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 9 Dec 2020 10:55:51 +0000 X-Received: from EX13D33EUC004.ant.amazon.com (10.43.164.63) by EX13D08UEE004.ant.amazon.com (10.43.62.182) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 9 Dec 2020 10:55:51 +0000 X-Received: from EX13D33EUC004.ant.amazon.com ([10.43.164.63]) by EX13D33EUC004.ant.amazon.com ([10.43.164.63]) with mapi id 15.00.1497.006; Wed, 9 Dec 2020 10:55:50 +0000 From: "Borghorst, Hendrik via groups.io" To: "devel@edk2.groups.io" CC: "Woodhouse, David" Subject: [edk2-devel] [PATCH] Ovmf: Set matching PCI routing values in PIIX4 Thread-Topic: [PATCH] Ovmf: Set matching PCI routing values in PIIX4 Thread-Index: AQHWzhnbZEq20RCQuUabx/9qgwfPmw== Date: Wed, 9 Dec 2020 10:55:50 +0000 Message-ID: <5730ec22e8ee60485046e40c131f61712ad81206.camel@amazon.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.43.164.29] MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,hborghor@amazon.de X-Gm-Message-State: DM1bMdeOS67xO6cHKwF2kVbCx1787277AA= Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <914AC9A309962C42B7D31003EE67DEA9@amazon.com> Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1607593048; bh=Oc/gNtw15OSPcscEBW6XOrJznukSMq5vOpr2ePAh3Os=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=e8oOIl74WQphjuUWzP6heIBVCDWJQXuYtp8Iy/7fTBHss3S9XCOqxyn3vehtyceQ0kj +v/lHUustFRhzzNA7FLZ+QRSiQvILKkaYdw9jyJFJfo4Fnnd8j/29+fh3RqPiuFljPM94 SOyyGCCFVo7ha0IQ+gSgu+VqMnIVnYA1hg8= X-ZohoMail-DKIM: pass (identity @groups.io) From 1d887726b2ff42ed2c90fcdaa8549c3ed8be4b7d Mon Sep 17 00:00:00 2001 From: Hendrik Borghorst Date: Tue, 8 Dec 2020 14:36:48 +0100 Subject: [PATCH] Ovmf: Set matching PCI routing values in PIIX4 The OVMF package tries to mimic the PCI initialization of SeaBIOS. Both set the PCI_INTERRUPT_LINE register according to the same logic with rotation based on IRQs (10, 10, 11, 11). However, while SeaBIOS applies these IRQs to the PCI interrupt routing register (0x60) of the PIIX4, OVMF wrongly applies (11, 11, 10, 10) which breaks legacy INTx routing. Signed-off-by: Hendrik Borghorst Reviewed-by: David Woodhouse --- .../PlatformBootManagerLib/BdsPlatform.c | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/OvmfPkg= /Library/PlatformBootManagerLib/BdsPlatform.c index 3c55ec9bd9..b8c3f54be6 100644 --- a/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c +++ b/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c @@ -1211,24 +1211,24 @@ PciAcpiInitialization ( // // 00:01.0 ISA Bridge (PIIX4) LNK routing targets // - PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x60), 0x0b); // A - PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x61), 0x0b); // B - PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x62), 0x0a); // C - PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x63), 0x0a); // D + PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x60), PciHostIrqs[0]); // A + PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x61), PciHostIrqs[1]); // B + PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x62), PciHostIrqs[2]); // C + PciWrite8 (PCI_LIB_ADDRESS (0, 1, 0, 0x63), PciHostIrqs[3]); // D break; case INTEL_Q35_MCH_DEVICE_ID: Pmba =3D POWER_MGMT_REGISTER_Q35 (ICH9_PMBASE); // // 00:1f.0 LPC Bridge (Q35) LNK routing targets // - PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x60), 0x0a); // A - PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x61), 0x0a); // B - PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x62), 0x0b); // C - PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x63), 0x0b); // D - PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x68), 0x0a); // E - PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x69), 0x0a); // F - PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x6a), 0x0b); // G - PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x6b), 0x0b); // H + PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x60), PciHostIrqs[0]); // A + PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x61), PciHostIrqs[1]); // B + PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x62), PciHostIrqs[2]); // C + PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x63), PciHostIrqs[3]); // D + PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x68), PciHostIrqs[0]); // E + PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x69), PciHostIrqs[1]); // F + PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x6a), PciHostIrqs[2]); // G + PciWrite8 (PCI_LIB_ADDRESS (0, 0x1f, 0, 0x6b), PciHostIrqs[3]); // H break; default: if (XenDetected ()) { --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#68650): https://edk2.groups.io/g/devel/message/68650 Mute This Topic: https://groups.io/mt/78850811/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-