From nobody Sat May 4 14:22:59 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+54705+1787277+3901457@groups.io; helo=web01.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54705+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1582264963; cv=none; d=zohomail.com; s=zohoarc; b=VWnl5J7tkY0ds8tPyUXvLDCohAmIMaieawIZw6RDnF56zcf28EETLNicYhQjUtp6OUmaQV7H3h3hcws7iux2NPVd+AoLWQY+f4RxjjAr16N/YbuiMCf2LRwTTRSbBi60XfefMiClzEk/bu9GHzg5Sw0b6ieVDSSzmrtIi8So//k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582264963; h=Cc:Date:From:List-Id:List-Unsubscribe:Message-ID:Reply-To:Sender:Subject:To; bh=t3IXreE35yVEVwHBPeK1qLCyxs7ZFWLFwq/vBbR1sQU=; b=W64lEE0yKF2jLfidec63hW4LbD3Pxm8lxls7gi3HW5n6cAV6eQKZu/aN7cZ/RLR73AnMHalrUUTi7PoDn9FDbJoyLMJA0OiwpLLrAwY96xQ5Eg1WZ2YE8Lf2Iiitl7M7ZNV1Jj75h5ymRNO7qSstvc6onkAKuuUMpCwZ6U4YCx4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+54705+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) header.from= Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 158226496346070.40256464675167; Thu, 20 Feb 2020 22:02:43 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id J3fYYY1788612x38ArEhcWDV; Thu, 20 Feb 2020 22:02:43 -0800 X-Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by mx.groups.io with SMTP id smtpd.web12.5044.1582264962525323536 for ; Thu, 20 Feb 2020 22:02:42 -0800 X-Received: by mail-pl1-f195.google.com with SMTP id d9so389884plo.11 for ; Thu, 20 Feb 2020 22:02:42 -0800 (PST) X-Gm-Message-State: wo4yf3mU3v2ke9FcBeZcxLeBx1787277AA= X-Google-Smtp-Source: APXvYqzN3aPP/x04F2LXrRbD/4GvTcK3QAtLG8G2IidESyn+rjuEyRWW5S8hM2QroEQg7sWJT+8zKg== X-Received: by 2002:a17:90b:4382:: with SMTP id in2mr1152966pjb.29.1582264961652; Thu, 20 Feb 2020 22:02:41 -0800 (PST) X-Received: from localhost.localdomain ([117.136.46.31]) by smtp.gmail.com with ESMTPSA id t189sm1369928pfd.168.2020.02.20.22.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Feb 2020 22:02:40 -0800 (PST) From: "GuoMinJ" To: devel@edk2.groups.io Cc: GuoMinJ Subject: [edk2-devel] [PATCH] MdeModulePkg/Bus: Potential NULL pointer on Token Date: Fri, 21 Feb 2020 14:00:25 +0800 Message-Id: <4ed94d8e2d027528621074754169fbcb9bea0a22.1582261089.git.newexplorerj@gmail.com> Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,newexplorerj@gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1582264963; bh=/WFb8tVeFZZtMvVYqFP49qHeEijjpUNDqavTpiQsl7g=; h=Cc:Date:From:Reply-To:Subject:To; b=ZT1A/ZLdw8Cf853n+XPxaljMORWZfCEeK1SQLiZoOFwGxfU3F2OKPF1kkxDAdZQkIYw 0Ak7mxt+ypkHQFZKbceHoLs1y2a/v5XHghRoGdFp3CIOlKyVLCXFOnkcOi9+Z36aCtqqV Eck9T8yLE3wW00VbtLtC3n52PMaZES69DBQ= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2286 Token pointer may be NULL, it is should be check before use it. Signed-off-by: GuoMinJ --- MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c b/MdeModulePkg/Bus/Sd/Sd= Dxe/SdBlockIo.c index 9f42abe7e2..25ab5abb2d 100644 --- a/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c +++ b/MdeModulePkg/Bus/Sd/SdDxe/SdBlockIo.c @@ -1367,7 +1367,12 @@ SdEraseBlocks ( return Status; } =20 - DEBUG ((EFI_D_ERROR, "SdEraseBlocks(): Lba 0x%x BlkNo 0x%x Event %p with= %r\n", Lba, BlockNum, Token->Event, Status)); + DEBUG ((DEBUG_ERROR, "SdEraseBlocks(): Lba 0x%x BlkNo 0x%x with %r, ", L= ba, BlockNum, Status)); + if ((Token !=3D NULL) && (Token->Event !=3D NULL)) { + DEBUG ((DEBUG_ERROR, "Event pointer is %p\n", Token->Event)); + else { + DEBUG ((DEBUG_ERROR, "Event is meaningless\n")); + } =20 return Status; } --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54705): https://edk2.groups.io/g/devel/message/54705 Mute This Topic: https://groups.io/mt/71445850/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-