From nobody Sun Feb 8 23:41:04 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) smtp.mailfrom=bounce+27952+53774+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from web01.groups.io (web01.groups.io [66.175.222.12]) by mx.zohomail.com with SMTPS id 1580857354770612.5552563313394; Tue, 4 Feb 2020 15:02:34 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id TEV4YY1788612x55GIruxuSE; Tue, 04 Feb 2020 15:02:34 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (NAM10-BN7-obe.outbound.protection.outlook.com [40.107.92.56]) by mx.groups.io with SMTP id smtpd.web09.1705.1580857353471612661 for ; Tue, 04 Feb 2020 15:02:33 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ayp4suHUMklWW6RKRGYLFWcCGJ5gIowkari1FvrIcHjFpItYgGw805vKxK39+R1NwD6MYeXdrkJOGcOnDs23NP4OsRzOfYswo3jspCSPat+ait5bYdVxLIXQ/Uo/sccTdl2SYN/dfAp3aLGUzY8XDlzEyBMuhkMBxDK4QCTMH9STQM3PaQdMLOUGZ2MJHsWxvNe3xB6KEjn34NirizVOj8XKvgcQ8q79+6o5uoTOgMu2XVMbiPy+OCQv9SaEtxaXLZ1lI9qKcLs9A0SdlKJs11koF+ZcZiqcAaxQQ7IvlWrTMEqfqB8lW9MDFf4/zid0UuHjvUUoYU+8w8R1yn4/Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cxdxAcO3q/b5tcDM+fdGTldTlNcA+yYTVSxHNlhBx4o=; b=VrjCKDAXsz0XnioQW9HTly/SPE77lPs8mrG6cwhBjLZKNAgzbC7+7LeeqVMC05z9ok3CnA749wpX3KIypNMDcLpGBNzpB5Zwdd2/BrJyZXqc7nS/nyKqPnDXGQM+fjRqZNJzQqYs1oex3HZBqVA//9bQgFcF2NlFR8baFxY8ngZdqYuRA2zDpY1NYATMSbLTMrbdadJtZtLCCY9utPCAa9kD8t7TboBNZ0E15iGFxmGN4LlL7gbBwaiWMlAtlZ/9iZcS1g7TzEwIwPKQdeW9gKGo33h24YXXQXyYDI+6qu+Ll9IK456MbJ2/eZzzb4qjJLhllE8BMtFDNcZTC4wPtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none X-Received: from DM6PR12MB3163.namprd12.prod.outlook.com (20.179.71.154) by DM6PR12MB3930.namprd12.prod.outlook.com (10.255.174.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.29; Tue, 4 Feb 2020 23:02:32 +0000 X-Received: from DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::a0cd:463:f444:c270]) by DM6PR12MB3163.namprd12.prod.outlook.com ([fe80::a0cd:463:f444:c270%7]) with mapi id 15.20.2707.020; Tue, 4 Feb 2020 23:02:32 +0000 From: "Lendacky, Thomas" To: devel@edk2.groups.io Cc: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Michael D Kinney , Liming Gao , Eric Dong , Ray Ni , Brijesh Singh Subject: [edk2-devel] [PATCH v4 28/40] OvmfPkg/PlatformPei: Move early GDT into ram when SEV-ES is enabled Date: Tue, 4 Feb 2020 17:01:32 -0600 Message-Id: <478fad59616ff4d60c329dd9eaa9d56a9e448610.1580857303.git.thomas.lendacky@amd.com> In-Reply-To: References: X-ClientProxiedBy: SN6PR16CA0062.namprd16.prod.outlook.com (2603:10b6:805:ca::39) To DM6PR12MB3163.namprd12.prod.outlook.com (2603:10b6:5:15e::26) MIME-Version: 1.0 X-Received: from tlendack-t1.amd.com (165.204.77.1) by SN6PR16CA0062.namprd16.prod.outlook.com (2603:10b6:805:ca::39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.32 via Frontend Transport; Tue, 4 Feb 2020 23:02:31 +0000 X-Originating-IP: [165.204.77.1] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 08d5cd28-8f15-49e6-8ef8-08d7a9c650ab X-MS-TrafficTypeDiagnostic: DM6PR12MB3930:|DM6PR12MB3930: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.12 as permitted sender) client-ip=66.175.222.12; envelope-from=bounce+27952+53774+1787277+3901457@groups.io; helo=web01.groups.io; Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: VX81UNz7xnDubzCqWWUbuIkkGPmXLhKY0I1WAmA9E+PgF+F85sw88ScyvkeFJiBCs4MgAkj2moSvmAkovqTBctGs+K/L9ASTlyNMstCDtki3R8ZMdcTewB9QEF9qpul7Qz9DAhLBvu5tXe1imyAHQ7t7PUsGrU0rzN3ukdvRFIqQ0wolq9RRGO3ly5GcEOySBZ24BDRcKromJIthjI09gPrcAAmkoaSsdt8KS1xQFOo51+1f39ueF+Fnf3RegpwQnG7RPAxuNX8iGzCbZYehF0DmyJ+KlvT5PJi6LcBfRHI2m5BgZJ90ktIkgtGd3rdfmFvnXJVjgSrP39UVBA+qmZLz8BjCQPw959BI7ETScROIJzg+VEveYjfunelUd3rd9pba9B84msI0QIQki6E8l+f7a6nvJ7yA0ymd5mU74uYVCkK7U2NCq9AWwwgg3jUsUKrqrTST3q9vEfMPL0smXm4/pmmqVygY+JjPUIru/dyKgCJG+05JzeBodiLRZptwDdml2IvcfQ37fljgVd+H8g== X-MS-Exchange-AntiSpam-MessageData: L94UV/DEMWK5x0fP2cKCqYz+wiJt6CW5DEfbzGcKCy+9MRea2NtYcA2D/hIzjfHrPq0Koa0pgJA1r5FVkwx8FSLMfwjPrWoSog1dQ1c64fcbOT+V04ZLa0LW3qR0cPb/4wa99EIVxOO7ptFkodVc2w== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 08d5cd28-8f15-49e6-8ef8-08d7a9c650ab X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Feb 2020 23:02:32.0822 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2RBFjBL5wp5g991Agt6WlSx+En/PXfGPkKLi6wZP5cLPf1Rs5MSAr6RN8dYvj6B3ddnQfKMWaNuGaX3vO4+Rdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3930 Precedence: Bulk List-Unsubscribe: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,thomas.lendacky@amd.com X-Gm-Message-State: ZlTSGlSyGFoueNigeK8Hpj1Qx1787277AA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1580857354; bh=UjhtUBRfjB48cdvTRMBN6nCQbLcILVfHOVejPDHZN1Q=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=EaS6XY2CU2XPycHm0S9uFSDnIdcQD//0zdi4BgE0CC/SiH8xMhfeRilMgQoN7ktxo+Y 0gmTu2dfkNPBSSBm3kmoZRG5KyyITtbTOU08TLN1+NZD9O/JAOQQn8kWVgllU6I5tx2S+ G7nARVueyo0wViGgK2ejlG7iewcggDVYFbk= X-ZohoMail-DKIM: pass (identity @groups.io) Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2198 The SEV support will clear the C-bit from non-RAM areas. The early GDT lives in a non-RAM area, so when an exception occurs (like a #VC) the GDT will be read as un-encrypted even though it is encrypted. This will result in a failure to be able to handle the exception. Move the GDT into RAM so it can be accessed without error when running as an SEV-ES guest. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Reviewed-by: Laszlo Ersek Signed-off-by: Tom Lendacky --- OvmfPkg/PlatformPei/AmdSev.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c index 900b0d977d61..b3fd2d86541a 100644 --- a/OvmfPkg/PlatformPei/AmdSev.c +++ b/OvmfPkg/PlatformPei/AmdSev.c @@ -37,6 +37,8 @@ AmdSevEsInitialize ( PHYSICAL_ADDRESS GhcbBasePa; UINTN GhcbPageCount; RETURN_STATUS PcdStatus, DecryptStatus; + IA32_DESCRIPTOR Gdtr; + VOID *Gdt; =20 if (!MemEncryptSevEsIsEnabled ()) { return; @@ -74,6 +76,22 @@ AmdSevEsInitialize ( (UINT64)GhcbPageCount, GhcbBase)); =20 AsmWriteMsr64 (MSR_SEV_ES_GHCB, GhcbBasePa); + + // + // The SEV support will clear the C-bit from non-RAM areas. The early G= DT + // lives in a non-RAM area, so when an exception occurs (like a #VC) the= GDT + // will be read as un-encrypted even though it was created before the C-= bit + // was cleared (encrypted). This will result in a failure to be able to + // handle the exception. + // + AsmReadGdtr (&Gdtr); + + Gdt =3D AllocatePages (EFI_SIZE_TO_PAGES ((UINTN) Gdtr.Limit + 1)); + ASSERT (Gdt !=3D NULL); + + CopyMem (Gdt, (VOID *) Gdtr.Base, Gdtr.Limit + 1); + Gdtr.Base =3D (UINTN) Gdt; + AsmWriteGdtr (&Gdtr); } =20 /** --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#53774): https://edk2.groups.io/g/devel/message/53774 Mute This Topic: https://groups.io/mt/70984950/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-