From nobody Mon Feb 9 03:47:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+78945+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78945+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=posteo.de ARC-Seal: i=1; a=rsa-sha256; t=1628502720; cv=none; d=zohomail.com; s=zohoarc; b=AXFf4+FRY7id7Ac8eqGZAW8jW70sizhqrOsI9VGUjetbVVhF2DygToeRdLgiTZGOGBqHo0oaw4X+7yQTcF7bspZUYRHRbA+eL6Vw7AfWEYqr0DAWPxeBQ8P+VJPRTjdU6IZWKpjYnrced/dIdgIZH25Wjspk8x84es1L12zGtuw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1628502720; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=z8I8ljzIupIoIUGfeNRZTmWpmQIqWL3TaAvfA3Lftvs=; b=C8HlM1ouqg/ML2O3N4nuubh9JTRSm8KC29PuW68HwRvCABYfK8/qVKayqePEunIPVcL/ZdRRgIfO4YW8VwUkAoMX8b7JjYjj54iJXsmhhZ8XwC+cjNBPMQjFs4Nv3RW5WnMLMJYQSSqkXLmlq/+YReFMT2EhazrPHab7V1Dm9UQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+78945+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1628502720780604.1903330781206; Mon, 9 Aug 2021 02:52:00 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id xg5dYY1788612xTtocbOCvSk; Mon, 09 Aug 2021 02:51:59 -0700 X-Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by mx.groups.io with SMTP id smtpd.web10.20763.1628502715985312017 for ; Mon, 09 Aug 2021 02:51:56 -0700 X-Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 47EA2240029 for ; Mon, 9 Aug 2021 11:51:53 +0200 (CEST) X-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Gjrvr4LY8z6tmQ; Mon, 9 Aug 2021 11:51:52 +0200 (CEST) From: =?UTF-8?B?TWFydmluIEjDpHVzZXI=?= To: devel@edk2.groups.io Cc: Leif Lindholm , Ard Biesheuvel , Abner Chang , Daniel Schaefer , Vitaly Cheptsov Subject: [edk2-devel] [PATCH v2 3/7] EmbeddedPkg/GdbStub: Check DebugImageInfoTable type safely Date: Mon, 9 Aug 2021 09:51:28 +0000 Message-Id: <42cbdbb34573448bff594229f93ae99d8d792db0.1628502345.git.mhaeuser@posteo.de> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mhaeuser@posteo.de X-Gm-Message-State: RD2p0pC7p7EOiOPtYnyA9gQYx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1628502719; bh=VGyLZYLQe1e/WUEYOkDNgvBMNlOgrB78aqIegj667Gs=; h=Cc:Content-Type:Date:From:Reply-To:Subject:To; b=aIcRjcrsFyHOrJ5r5N/XAfBQ8D4AupwbrTmtJggvxqaUNq7AjjCnA1s74ujMbiwfYhk kxP92M4+BtjHAzjH5T301nNYLYIw22sNJHVhuOs8BewyJynxhWowiV96jrODvJCIC+w5s +4/eDtXpMRejSpj7fe7h/OeRGhSS4dPHNRA= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1628502722835100041 Content-Type: text/plain; charset="utf-8" C does not allow casting to or dereferencing incompatible pointer types. Use the ImageInfoType member of the union first to determine the data type before dereferencing NormalImage. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Cc: Vitaly Cheptsov Signed-off-by: Marvin H=C3=A4user --- EmbeddedPkg/GdbStub/GdbStub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/EmbeddedPkg/GdbStub/GdbStub.c b/EmbeddedPkg/GdbStub/GdbStub.c index 7f2a5ed20011..09167fdafb4d 100644 --- a/EmbeddedPkg/GdbStub/GdbStub.c +++ b/EmbeddedPkg/GdbStub/GdbStub.c @@ -1043,8 +1043,8 @@ QxferLibrary ( =20 if (gDebugTable !=3D NULL) { for (; gEfiDebugImageTableEntry < gDebugImageTableHeader->TableSize; g= EfiDebugImageTableEntry++, gDebugTable++) { - if (gDebugTable->NormalImage !=3D NULL) { - if ((gDebugTable->NormalImage->ImageInfoType =3D=3D EFI_DEBUG_IMAG= E_INFO_TYPE_NORMAL) && + if (gDebugTable->ImageInfoType !=3D NULL) { + if ((*gDebugTable->ImageInfoType =3D=3D EFI_DEBUG_IMAGE_INFO_TYPE_= NORMAL) && (gDebugTable->NormalImage->LoadedImageProtocolInstance !=3D NU= LL)) { Pdb =3D PeCoffLoaderGetDebuggerInfo ( gDebugTable->NormalImage->LoadedImageProtocolInstance->Im= ageBase, --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78945): https://edk2.groups.io/g/devel/message/78945 Mute This Topic: https://groups.io/mt/84764908/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-