From nobody Sun Feb 8 11:59:16 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+106544+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 168807973991752.868234679492275; Thu, 29 Jun 2023 16:02:19 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id sHyMYY1788612xWsdCq12p55; Thu, 29 Jun 2023 16:02:19 -0700 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (NAM02-SN1-obe.outbound.protection.outlook.com [40.107.96.55]) by mx.groups.io with SMTP id smtpd.web10.103.1688079739011282977 for ; Thu, 29 Jun 2023 16:02:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XuV6ouPKzEfTYqyXh4rHfUMnEpIGbdA5LUnwbayvfLTeIId/vqql4G68hlamXdNLttUJtXDTn/N25jTtVZDEydcf3h/CWGy2moPAxS7wsera6MJRsTtvQ6dUxP2DtRNE3Sl3p2Elh2B0yCvBS2cRMRKUnbUv3e1Cn8VGhpRDbVqCy2RxoiloExO2Cf39l3ZUmj0eulViPpF1nsuF1rRhDOPQiY5S5mnG62eIzW5KVux3D28KVtozKk1+0Brgl2eZW68jfYC9P39l76bWbRFE3udkoVQB8bG/K/cSUmiZWPs5/Lptd2MN7d8sLuhQbELicAZG+9x+XHrUKLsztFE10g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TNXvHSJ2I5MRdtQJe8CzBoOmfqtrIP7cT4M0HxDKhsY=; b=EvDiP68YxB7+OVBp5nJpZGkBPSTQt+38fr6wjoSaJNP2va4picDtUKD8sUH3w+XG3un/KXtfi32fwM8wYt0VxAgZpxiNisZdkLVwlOiRmlxnrUwPZmOjYD5n0GGRtxd4bXPa48BwyjloV+KJBp8+z3HZ3ieHhf0eSJm8pbpHvEC0azV37P7hxcybfFLr9wWxjU9WnKZGS64aIisqRWW8h5ccWihGUTmjZ30j7pgHyVqM0RfCEK6etRWx/EFbKPiXeZp2rGju/vK06YxHBHs/Az2kKok8clSG38LkiOZUIsqJgF/z6kQLwgMx9rsYYLWV6Z36aLKunibJ+07/bO8/NQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from BN0PR04CA0091.namprd04.prod.outlook.com (2603:10b6:408:ec::6) by CO6PR12MB5410.namprd12.prod.outlook.com (2603:10b6:5:35b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Thu, 29 Jun 2023 23:02:14 +0000 X-Received: from BN8NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ec:cafe::df) by BN0PR04CA0091.outlook.office365.com (2603:10b6:408:ec::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Thu, 29 Jun 2023 23:02:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+106544+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT061.mail.protection.outlook.com (10.13.177.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.50 via Frontend Transport; Thu, 29 Jun 2023 23:02:14 +0000 X-Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 29 Jun 2023 16:01:59 -0700 X-Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 29 Jun 2023 16:01:59 -0700 X-Received: from 6cd8174ac25c.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 29 Jun 2023 16:01:58 -0700 From: "Jeff Brasen via groups.io" To: CC: , , , Jeff Brasen , "Swatisri Kantamsetti" , Ashish Singhal Subject: [edk2-devel] [PATCH 3/4] DynamicTablesPkg: Add support to add Strings to package Date: Thu, 29 Jun 2023 23:01:48 +0000 Message-ID: <407dc3cb79752a0a49fc06d8b85abd91733cb360.1688079404.git.jbrasen@nvidia.com> In-Reply-To: References: MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT061:EE_|CO6PR12MB5410:EE_ X-MS-Office365-Filtering-Correlation-Id: 4afa61f2-9143-434f-1543-08db78f4e0f4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: R72rTCcL+rz/jY1Qt68FK12Xx84FeGbPldUQ1xbSwxVuPvRRMhm8XqRzU2oibuTyGUwIHWNRk5gnTOZgh1Uy2OWNl9Cmumw2kLzuxvhSRoA8iNTH55VMscY8Ck45FQfPeqBitkWwVPbs7/4EgVGTObNRzeYvF2vxaAYLY97Af3cX/tqE/hXiVa5xdS7nyB8npNTzypWmZ7qr1HVFhzJoQs4Sue/OHh4j3nhi+o5Br+VEvYywXnwnU7I5o1rHdjWiMsk6xyFHPCDBTLDFNqggYnuOjvmSSZkv7lievPHDi3FN0ZIbTWn8fB5z/VUCUaG2l7ey5opNxXQiyjWQRcqzL/p/fHQJxCHPnK8LLuRBFu47r+5gqM4V1x0BJ/EAaLD3dgSqz0dgydbeRWpizaITooOwQuNsMvAZG5hJqxjdNTeg7QKN8ZGDPv3IOhOjgxQ6fHfZ/E0DtBfeL8yas3PilRKHKV0XE8k+3aA9kjhQzwAQYCoxjB+xZeSR886MFZwFgwt5itaYlloZ47tNgbCaimikcvEmjyyO4SlwpheDr1LrFEEDA4h0MWOdQArSZBOEUmPrKkUcp5uhf3DYKPxoS49lIDg5MoKo7AtV9NEB6M85N6bYJMe9XfePttb5Ru97vih8LGB6ctYex/Dk9pV9exOEihKbHD+h7clXgf8x2dpToAAAC00w/RyG48AZ1FPp/zIyP2s/pE9+M99w6Sh0jMcOinkrq482G+Gucoqnm5Q= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 23:02:14.2315 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4afa61f2-9143-434f-1543-08db78f4e0f4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO6PR12MB5410 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,jbrasen@nvidia.com X-Gm-Message-State: H2V0frRv6MpbTEPBT5d87XdKx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1688079739; bh=chziIl2QMGyoDV9i9nRig/1bqhS9FLEIgFtAyJcARqI=; h=CC:Content-Type:Date:From:Reply-To:Subject:To; b=BFrPM6dvmddT83p0vrkNQwktTy5zhL6y6dlGU2ZSdassdosJhZ0gqLLVi+wU49DB/Mb n/gN65no3ynlYrrdGBeCf+6gIoGEWdZzqw08zGjdIps1G8k7lgrLR3Axdh0fsFkjenOTu QYwjDgo5INF3a5Da8rXPm4l/d7eHDM0yH3E= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1688079742102100015 Content-Type: text/plain; charset="utf-8" Add API to add a String to a package created with NamedPackage API. Signed-off-by: Jeff Brasen Reviewed-by: Swatisri Kantamsetti Reviewed-by: Ashish Singhal --- .../Include/Library/AmlLib/AmlLib.h | 17 ++++ .../Common/AmlLib/CodeGen/AmlCodeGen.c | 82 +++++++++++++++++++ 2 files changed, 99 insertions(+) diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h index b82c7a3ce8..043e7ee901 100644 --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h @@ -1472,4 +1472,21 @@ AmlCreateCpcNode ( OUT AML_OBJECT_NODE_HANDLE *NewCpcNode OPTIONAL ); =20 +/** AML code generation to add a string to the package in a named node. + + + @param [in] String String to add + @param [in] NamedNode Node to add the string to the included packa= ge. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlAddStringToNamedPackage ( + IN CHAR8 *String, + IN AML_OBJECT_NODE_HANDLE NamedNode + ); + #endif // AML_LIB_H_ diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c index 2b95839e4c..a0d01032d5 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c @@ -3665,3 +3665,85 @@ error_handler: AmlDeleteTree ((AML_NODE_HANDLE)CpcNode); return Status; } + +/** AML code generation to add a string to the package in a named node. + + + @param [in] Name String to add + @param [in] NamedNode Node to add the string to the included packa= ge. + + @retval EFI_SUCCESS Success. + @retval EFI_INVALID_PARAMETER Invalid parameter. + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory. +**/ +EFI_STATUS +EFIAPI +AmlAddStringToNamedPackage ( + IN CHAR8 *String, + IN AML_OBJECT_NODE_HANDLE NamedNode + ) +{ + EFI_STATUS Status; + AML_DATA_NODE *DataNode; + CHAR8 *AmlNameString; + UINT32 AmlNameStringSize; + AML_OBJECT_NODE_HANDLE PackageNode; + + DataNode =3D NULL; + + if ((NamedNode =3D=3D NULL) = || + (AmlGetNodeType ((AML_NODE_HANDLE)NamedNode) !=3D EAmlNodeObject) || + (!AmlNodeHasOpCode (NamedNode, AML_NAME_OP, 0))) + { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + PackageNode =3D (AML_OBJECT_NODE_HANDLE)AmlGetFixedArgument ( + NamedNode, + EAmlParseIndexTerm1 + ); + if ((PackageNode =3D=3D NULL) = || + (AmlGetNodeType ((AML_NODE_HANDLE)PackageNode) !=3D EAmlNodeObject) = || + (!AmlNodeHasOpCode (PackageNode, AML_PACKAGE_OP, 0))) + { + ASSERT (0); + return EFI_INVALID_PARAMETER; + } + + Status =3D ConvertAslNameToAmlName (String, &AmlNameString); + if (EFI_ERROR (Status)) { + ASSERT (0); + return Status; + } + + Status =3D AmlGetNameStringSize (AmlNameString, &AmlNameStringSize); + if (EFI_ERROR (Status)) { + ASSERT (0); + goto exit_handler; + } + + Status =3D AmlCreateDataNode ( + EAmlNodeDataTypeNameString, + (UINT8 *)AmlNameString, + AmlNameStringSize, + &DataNode + ); + if (EFI_ERROR (Status)) { + ASSERT (0); + goto exit_handler; + } + + Status =3D AmlVarListAddTail ( + (AML_NODE_HANDLE)PackageNode, + (AML_NODE_HANDLE)DataNode + ); + ASSERT_EFI_ERROR (Status); + +exit_handler: + if (AmlNameString !=3D NULL) { + FreePool (AmlNameString); + } + + return Status; +} --=20 2.25.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#106544): https://edk2.groups.io/g/devel/message/106544 Mute This Topic: https://groups.io/mt/99861341/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-