From nobody Wed May 1 21:55:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+85259+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85259+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1641141249; cv=none; d=zohomail.com; s=zohoarc; b=e/vBHMegtT0wKRgC5jsTGzpZN+Lf1knKmXwKIqq8YCa3upll0S240dDhQ0nJUapvXPceKbzyGNGqA4igI0VsFj6XG7h8jcDI4Q5+zH8/TNqxfSETz3FJ4neaKu4HfO5KvyMUn6nHJNhPwxehe5Iton2y4hGKobbpSGf1c7WAPAg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1641141249; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=y+apI1FbNJ4BEJzxQBB8XJxhrYUwGjZ8k7nVpsm4lCY=; b=b40rnZSW7zV2iJHOW/4AzaHT0bW0xfnUb9zZ6r0+EUtOGpO+MT2e5wKutFFSlI3lPlSKVwaGRm6vrrwP16qXdO/GbXqz58Q4VlR2ToqE2DJJnwaD9AUjdFA3uGhZVJ8UFuNM3FaeFXa9wKMH9zC0dGG5s5tlVQhcXIGu3n3yERg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85259+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1641141249262839.411334936507; Sun, 2 Jan 2022 08:34:09 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id FYwnYY1788612x1adNGjpKAM; Sun, 02 Jan 2022 08:34:08 -0800 X-Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.14801.1641141247525986063 for ; Sun, 02 Jan 2022 08:34:08 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10214"; a="239520868" X-IronPort-AV: E=Sophos;i="5.88,256,1635231600"; d="scan'208";a="239520868" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2022 08:34:06 -0800 X-IronPort-AV: E=Sophos;i="5.88,256,1635231600"; d="scan'208";a="487598105" X-Received: from basfe004.gar.corp.intel.com ([10.66.129.57]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jan 2022 08:34:03 -0800 From: "Ashraf Ali S" To: devel@edk2.groups.io Cc: Ashraf Ali S , Rangasai V Chaganty , Digant H Solanki , Sangeetha V , Ray Ni , Michael D Kinney , Liming Gao , Zhiguang Liu Subject: [edk2-devel] [PATCH] Update Graphics Info Hob FrameBufferSize Based on UEFI Spec 2.0 Date: Sun, 2 Jan 2022 22:03:51 +0530 Message-Id: <3a8e50cf4d5d293d4ce53ffbdad4b5be9bb64a41.1641141173.git.ashraf.ali.s@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com X-Gm-Message-State: 8XwkFRB20wistdpCF7KLf4hlx1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1641141248; bh=i0QkPqDz+7hkqJR2ZsDUC4kvLV1KMoo0gmfLX+ILIF0=; h=Cc:Date:From:Reply-To:Subject:To; b=uJ0RsjzzRWb5hU3544xKlcC89OIqRU6s1ky/ZjVOubkZ9h4+90tWE4JcoMjPQn3kxYN NZTuwZ0KaC6CqbZsUlKU3cmLSpffzzubeNTlnAcDkeGWT6Z5B0EHsm1MdWwxoiEEmeoQ7 IXwQmb74CIdzOIQ+7UgmPFrh9S+Fmsg7OzE= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1641141251246100001 Content-Type: text/plain; charset="utf-8" REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3793 Basede on UEFI Spec 2.0 section 17.7.1 structure EFI_GRAPHICS_OUTPUT_PROTOCOL_MODE say FrameBufferSize should be size of UINTN, in MdePkg\Include\Guid\GraphicsInfoHob.h EFI_PEI_GRAPHICS_INFO_HOB FrameBufferSize is UINT32, UefiPayloadPkg\GraphicsOutputDxe\GraphicsOutput.c MdeModulePkg\Universal\Console\GraphicsOutputDxe\GraphicsOutput.c Private->GraphicsOutputMode.FrameBufferSize =3D \ GraphicsInfo->FrameBufferSize; UINT32 value is getting assigned to UINTN, in X64 build compiler will throw possible loss of data error. so update the EFI_PEI_GRAPHICS_INFO_HOB based on UEFI Spec 2.0 Signed-off-by: Ashraf Ali S Cc: Rangasai V Chaganty Cc: Digant H Solanki Cc: Sangeetha V Cc: Ray Ni Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu --- MdePkg/Include/Guid/GraphicsInfoHob.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MdePkg/Include/Guid/GraphicsInfoHob.h b/MdePkg/Include/Guid/Gr= aphicsInfoHob.h index 237911e63a..92bd907f20 100644 --- a/MdePkg/Include/Guid/GraphicsInfoHob.h +++ b/MdePkg/Include/Guid/GraphicsInfoHob.h @@ -26,7 +26,7 @@ =20 typedef struct { EFI_PHYSICAL_ADDRESS FrameBufferBase; - UINT32 FrameBufferSize; + UINTN FrameBufferSize; EFI_GRAPHICS_OUTPUT_MODE_INFORMATION GraphicsMode; } EFI_PEI_GRAPHICS_INFO_HOB; =20 --=20 2.30.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85259): https://edk2.groups.io/g/devel/message/85259 Mute This Topic: https://groups.io/mt/88094322/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-