From nobody Mon May 6 06:29:36 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+85052+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85052+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1639728609; cv=none; d=zohomail.com; s=zohoarc; b=OvobW6Dma2fJVZnXytTR1U0m8br8G6CKFxPFXaoNQJ8839xDKWSshOXf3dfPCCQ1I64dEJ7w6bP/Acc4PsrGaOeg0YlM/hXEXzCd7WnL79w3lSZfwvUYjnOhYm/S22iauGsm0/ypblizsA9+d8yR1N4n7u54P8vkEIPzuIUGFKA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1639728609; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Sender:Subject:To; bh=hbbIlwNnkPlu7BX8qdMGikPnqMdHhRC34bqOSfYeN0k=; b=VvvDbfJEpGz3SkOG6wBKbEJB/BDedBRXuXnkJHhFlnpT4HVtBp7EXlxs4fYMI2sL+LqBR9fxX/s/B2JIzxKNpGYZIPdLLGx68+jzsrhqFFHVgxGipN5MONBR12tI4uOel2DRlTR7bZ0F/j4ns+BBbsnjLeRC7DjxhtKI7nkYWb4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+85052+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1639728609810986.705238362469; Fri, 17 Dec 2021 00:10:09 -0800 (PST) Return-Path: X-Received: by 127.0.0.2 with SMTP id 0gCvYY1788612x40PxlEPeOx; Fri, 17 Dec 2021 00:10:09 -0800 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.3792.1639728607499767309 for ; Fri, 17 Dec 2021 00:10:08 -0800 X-IronPort-AV: E=McAfee;i="6200,9189,10200"; a="226566943" X-IronPort-AV: E=Sophos;i="5.88,213,1635231600"; d="scan'208";a="226566943" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2021 00:10:05 -0800 X-IronPort-AV: E=Sophos;i="5.88,213,1635231600"; d="scan'208";a="605830872" X-Received: from kxinfux-win10.gar.corp.intel.com ([10.227.107.41]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2021 00:10:04 -0800 From: "VincentX Ke" To: devel@edk2.groups.io Cc: VincentX Ke , Hao A Wu , Ray Ni , Ian Chiu , Maggie Chu Subject: [edk2-devel] [PATCH v4] MdeModulePkg: Replace with UFS_UNIT_DESC to fix timeout problem Date: Fri, 17 Dec 2021 16:09:39 +0800 Message-Id: <3251e10d5f7b004a93bccba80d3e82916e0bb672.1639728124.git.vincentx.ke@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,vincentx.ke@intel.com X-Gm-Message-State: ZndWyjgIF7ynV7NBQoNIbmj1x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1639728609; bh=ngnZbk0iZq3Uj+6JMp3StOyjR95TTAlvTxQfUXA3HE4=; h=Cc:Date:From:Reply-To:Subject:To; b=TBfWvs3JmFYkaW0prszSQ6uf3OwHs8oXpGAOqSCVYt+3nimkGX6qE46932qKiy8PWbk hx+D/T0tIiI4qPF+Aah39FY/xdGeSFjGTFnU9hQlnBLCYvloNk9jwliezcIxYJKfMo5gk fn16HHTjuzhIZfDF7v2KtVUC1Af32+ySuBk= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1639728612545100001 Content-Type: text/plain; charset="utf-8" BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3714 Replace with UFS_UNIT_DESC to fix response timeout problem. Cc: Hao A Wu Cc: Ray Ni Cc: Ian Chiu Cc: Maggie Chu Signed-off-by: VincentX Ke Reviewed-by: Hao A Wu --- .../Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c | 20 +++++++++---------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c b/MdeModule= Pkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c index b331c0f3e3..9ad1e19fe0 100644 --- a/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c +++ b/MdeModulePkg/Bus/Ufs/UfsBlockIoPei/UfsBlockIoPei.c @@ -1037,9 +1037,9 @@ InitializeUfsBlockIoPeim ( UFS_PEIM_HC_PRIVATE_DATA *Private; EDKII_UFS_HOST_CONTROLLER_PPI *UfsHcPpi; UINT32 Index; - UFS_CONFIG_DESC Config; UINTN MmioBase; UINT8 Controller; + UFS_UNIT_DESC UnitDescriptor; =20 // // Shadow this PEIM to run from memory @@ -1126,19 +1126,17 @@ InitializeUfsBlockIoPeim ( } =20 // - // Get Ufs Device's Lun Info by reading Configuration Descriptor. + // Check if 8 common luns are active and set corresponding bit mask. // - Status =3D UfsRwDeviceDesc (Private, TRUE, UfsConfigDesc, 0, 0, &Confi= g, sizeof (UFS_CONFIG_DESC)); - if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "Ufs Get Configuration Descriptor Error, Status= =3D %r\n", Status)); - Controller++; - continue; - } - for (Index =3D 0; Index < UFS_PEIM_MAX_LUNS; Index++) { - if (Config.UnitDescConfParams[Index].LunEn !=3D 0) { - Private->Luns.BitMask |=3D (BIT0 << Index); + Status =3D UfsRwDeviceDesc (Private, TRUE, UfsUnitDesc, (UINT8) Inde= x, 0, &UnitDescriptor, sizeof (UFS_UNIT_DESC)); + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "Fail to read UFS Unit Descriptor, Index =3D = %X, Status =3D %r\n", Index, Status)); + continue; + } + if (UnitDescriptor.LunEn =3D=3D 0x1) { DEBUG ((DEBUG_INFO, "Ufs %d Lun %d is enabled\n", Controller, Inde= x)); + Private->Luns.BitMask |=3D (BIT0 << Index); } } =20 --=20 2.18.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85052): https://edk2.groups.io/g/devel/message/85052 Mute This Topic: https://groups.io/mt/87785543/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-