[edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17.

xueshengfeng via groups.io posted 1 patch 1 year, 7 months ago
Failed in applying to current master (apply log)
.../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c        | 5 +++++
1 file changed, 5 insertions(+)
[edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17.
Posted by xueshengfeng via groups.io 1 year, 7 months ago
From: Shengfengx Xue <shengfengx.xue@intel.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4014

if Configured Memory Speed is 65,535 MT/s or greater,
and the actual speed is stored in the Extended Configured Memory Speed
field. but current Smbiosview have no this logic.

Signed-off-by: Shengfengx Xue <shengfengx.xue@intel.com>
---
 .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c        | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
index a0ee286c9a..0ab9f5063a 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
@@ -878,6 +878,11 @@ SmbiosPrintStructure (
         }
       }
 
+      if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)) {
+        PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed);
+        PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedConfiguredMemorySpeed);
+      }
+
       break;
 
     //
-- 
2.26.2.windows.1




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92208): https://edk2.groups.io/g/devel/message/92208
Mute This Topic: https://groups.io/mt/92898444/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-
Re: [edk2-devel] [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show Extended Speed and Extended Configured Memory Speed in type 17.
Posted by Gao, Zhichao 1 year, 7 months ago
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: xueshengfeng <xueshengfeng@byosoft.com.cn>
> Sent: Saturday, August 6, 2022 10:02 AM
> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>; Gao, Zhichao
> <zhichao.gao@intel.com>
> Cc: Gao, Liming <gaoliming@byosoft.com.cn>; Xue, ShengfengX
> <shengfengx.xue@intel.com>
> Subject: [PATCH] ShellPkg/SmbiosView: Smbiosview tool is not show
> Extended Speed and Extended Configured Memory Speed in type 17.
> 
> From: Shengfengx Xue <shengfengx.xue@intel.com>
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4014
> 
> if Configured Memory Speed is 65,535 MT/s or greater, and the actual speed
> is stored in the Extended Configured Memory Speed field. but current
> Smbiosview have no this logic.
> 
> Signed-off-by: Shengfengx Xue <shengfengx.xue@intel.com>
> ---
>  .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c        | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index a0ee286c9a..0ab9f5063a 100644
> ---
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -878,6 +878,11 @@ SmbiosPrintStructure (
>          }
>        }
> 
> +      if (AE_SMBIOS_VERSION (0x3, 0x3) && (Struct->Hdr->Length > 0x54)) {
> +        PRINT_STRUCT_VALUE_H (Struct, Type17, ExtendedSpeed);
> +        PRINT_STRUCT_VALUE_H (Struct, Type17,
> ExtendedConfiguredMemorySpeed);
> +      }
> +
>        break;
> 
>      //
> --
> 2.26.2.windows.1
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92244): https://edk2.groups.io/g/devel/message/92244
Mute This Topic: https://groups.io/mt/92898444/1787277
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org]
-=-=-=-=-=-=-=-=-=-=-=-