From nobody Sun May 12 19:32:34 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112884+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112884+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1703518096; cv=none; d=zohomail.com; s=zohoarc; b=GHiyFxh1Z4U5Kf/xwrfkdtQ4R24h7s9SosUcygGWK+Gq3CoRrLE+Xo5FOxd6prtlWJ+rIaX1qabAjqXvSn5fEsScX7Pe/xSA628xJSl2N2nz/aqZAXhsKZoyg97tBGYBPozcenui0w4YSYYeLmjPdYHza+byA8505JK+/DmDVgM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1703518096; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Sender:Subject:Subject:To:To:Message-Id; bh=AjBVT2N0o9tqvwqdCfv6j4mzAtt9/9SuifWGKklxkRQ=; b=RGIaqBB5BkTVsVPqiw7bx1eVM7Az2+PVUpxBzMabY6+kARGAy0O46YODXaSm5JqemhIl/Lr+q+J59kiqn3ginpDPHDaj2TliNwT5I+p8y19g1igmzCkgFG5KOjJtA595Yqk4V/uBdDW0/jFiGP0jGB7yHKFKkoH/ahBd1uiMxBc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112884+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1703518096243226.46669058112388; Mon, 25 Dec 2023 07:28:16 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=jXTSef/CQ4h5KlpmS1CTGAmXtyknAJudI9BeCPRHFMQ=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1703518095; v=1; b=BuYWe5ACeZ1pb4Qos2RPSWKjtWxdyEAzLQOepIM3abgcP1LEJ39Kol0U4/D7+lq77TxNfJzy owXYW2ZzOI5+zodH9wY/LLAYWcErBH3qAVB1GnBqw5TVcieRp7ZBIqzLpR+W/UbhAg4jALAfWon Ha0QlcrqVok0YRny679OZ9vA= X-Received: by 127.0.0.2 with SMTP id nZ29YY1788612xYt3SNiNtqh; Mon, 25 Dec 2023 07:28:15 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by mx.groups.io with SMTP id smtpd.web10.61327.1703518093960816663 for ; Mon, 25 Dec 2023 07:28:14 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="9819480" X-IronPort-AV: E=Sophos;i="6.04,303,1695711600"; d="scan'208";a="9819480" X-Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2023 07:28:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="753958276" X-IronPort-AV: E=Sophos;i="6.04,303,1695711600"; d="scan'208";a="753958276" X-Received: from ashrafal-mobl4.gar.corp.intel.com ([10.213.112.137]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2023 07:28:09 -0800 From: "Ashraf Ali S" To: devel@edk2.groups.io Cc: Ashraf Ali S , Yuwei Chen , Rebecca Cran , Liming Gao , Bob Feng , Amy Chan , Sai Chaganty Subject: [edk2-devel] [PATCH] BaseTools: Remove Duplicate sets of SkuName and SkuId from allskuset Date: Mon, 25 Dec 2023 20:57:52 +0530 Message-Id: <2fcb6a95d99dffa093011850548712054ef7e813.1703518030.git.ashraf.ali.s@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ashraf.ali.s@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: XD50BHPrnvdl6cPE6SObZ9Alx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1703518098501100002 Content-Type: text/plain; charset="utf-8" Currently when the platform has many SKUs then allskuset will be having so many duplicate. and while parsing the allskuset will take longer time while assing Pcd.SkuInfoList. This patch is to eliminate those duplicate entires to reduce the build time Cc: Yuwei Chen Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Amy Chan Cc: Sai Chaganty Signed-off-by: Ashraf Ali S Reviewed-by: Amy Chan Reviewed-by: Yuwei Chen --- BaseTools/Source/Python/AutoGen/PlatformAutoGen.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py b/BaseTools= /Source/Python/AutoGen/PlatformAutoGen.py index 592d4824a4..dac81454a9 100644 --- a/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/PlatformAutoGen.py @@ -707,6 +707,8 @@ class PlatformAutoGen(AutoGen): self._DynamicPcdList.extend(list(OtherPcdArray)) self._DynamicPcdList.sort() allskuset =3D [(SkuName, Sku.SkuId) for pcd in self._DynamicPcdLis= t for (SkuName, Sku) in pcd.SkuInfoList.items()] + # Remove duplicate sets in the list + allskuset =3D list(set(allskuset)) for pcd in self._DynamicPcdList: if len(pcd.SkuInfoList) =3D=3D 1: for (SkuName, SkuId) in allskuset: --=20 2.39.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112884): https://edk2.groups.io/g/devel/message/112884 Mute This Topic: https://groups.io/mt/103360241/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-