From nobody Mon Feb 9 09:29:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+82166+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82166+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1634333149; cv=none; d=zohomail.com; s=zohoarc; b=RkcWEg76ltLFR0IBpdpjAcW0YMBgdFX+AAKHLlM4GhrMFTOm6KNNBCTjPW/tle9W0DYUDwGpxBkC8N2A/6jNxjfpFursoceK8Evmj3mpLCMhxR9qM4kQXJbrmPhM1JcF+G5ThUqTZNWP55mY0rtGkNBdoKEj1ufWx3KUZYfuVCY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1634333149; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:References:Sender:Subject:To; bh=dqQQNWEgMceqRB0mZgdILYmfOxUnz9FNkjJ4aRXS7KY=; b=gGrIz3lo6sRcB6RrFdPYIuj8yeAdJkzKP+aDNcuWQL1hX+DYaOJ4phhVpe8ua3sj0dW3NY4YUO7M2+m2dAX22amvc9dh9cZIhOpqSotJD98y9T4I3SQmAONqLSnfxxmoEIjwx5uoqu2AnWtxih37SRejpNUIR6x0XwK3Ux8qqq0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+82166+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1634333149525410.97503119341263; Fri, 15 Oct 2021 14:25:49 -0700 (PDT) Return-Path: X-Received: by 127.0.0.2 with SMTP id I6jRYY1788612xL10NycvjrO; Fri, 15 Oct 2021 14:25:49 -0700 X-Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.3341.1634333146761283299 for ; Fri, 15 Oct 2021 14:25:48 -0700 X-IronPort-AV: E=McAfee;i="6200,9189,10138"; a="314187540" X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="314187540" X-Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 14:25:47 -0700 X-IronPort-AV: E=Sophos;i="5.85,376,1624345200"; d="scan'208";a="492709812" X-Received: from iworam-desk.amr.corp.intel.com ([10.7.150.79]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Oct 2021 14:25:44 -0700 From: "Oram, Isaac W" To: devel@edk2.groups.io Cc: Chasel Chiu , Nate DeSimone , Liming Gao , Eric Dong Subject: [edk2-devel][edk2-platforms][PATCH V1 11/11] MinPlatformPkg/ReportFvLib: Remove obsolete PeiReportFvLib instance Date: Fri, 15 Oct 2021 14:25:34 -0700 Message-Id: <2a1dffbb6cb2d460bfa0421426a880faeb03148d.1634331939.git.isaac.w.oram@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Unsubscribe: List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,isaac.w.oram@intel.com X-Gm-Message-State: WSvKQl2xAxuS2S6BaqJNJMT5x1787277AA= Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=groups.io; q=dns/txt; s=20140610; t=1634333149; bh=/6gwRBXldTBQKWmhWyVIHu+vTKJItoaPGi/84An8fGE=; h=Cc:Date:From:Reply-To:Subject:To; b=DcINepKSC3dAPQ/vdjVAY6pFixFaNJlxtpHcSZRwCCCgMhCDc7tR4w9IFCZGZRwmS5D ERIB6pug5oRaMuEfWpkcqh95WyIB7yvF0fUl24yKTwL8X1b39tj1k4cNE65a4b0FUTDfo 5UJRqVj5Zgr0uUX+KPdjEFVykXb2xL4LQ84= X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1634333150615100037 Content-Type: text/plain; charset="utf-8" All boards have been updated to use the new libraries or custom instances. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Isaac Oram Reviewed-by: Nate DeSimone --- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc = | 1 - Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRepor= tFvLib.c | 143 -------------------- Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRepor= tFvLib.inf | 50 ------- 3 files changed, 194 deletions(-) diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/In= tel/MinPlatformPkg/MinPlatformPkg.dsc index 1dfca06a10..58415326f4 100644 --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc @@ -93,7 +93,6 @@ # PEI phase common # FspWrapperPlatformLib|MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPla= tformLib/PeiFspWrapperPlatformLib.inf - ReportFvLib|MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReport= FvLib.inf ReportCpuHobLib|IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.= inf TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestP= ointCheckLib.inf TestPointLib|MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFv= Lib/PeiReportFvLib.c b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/P= eiReportFvLib/PeiReportFvLib.c deleted file mode 100644 index 833a77c702..0000000000 --- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/Pei= ReportFvLib.c +++ /dev/null @@ -1,143 +0,0 @@ -/** @file - Source code file for Report Firmware Volume (FV) library - -Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.
-SPDX-License-Identifier: BSD-2-Clause-Patent - -**/ - -#include -#include -#include -#include -#include -#include -#include -#include - -VOID -ReportPreMemFv ( - VOID - ) -{ - /// - /// Note : FSP FVs except FSP-T FV are installed in IntelFsp2WrapperPkg = in Dispatch mode. - /// - if (PcdGetBool(PcdFspWrapperBootMode)) { - DEBUG ((DEBUG_INFO, "Install FlashFvFspT - 0x%x, 0x%x\n", PcdGet32 (Pc= dFlashFvFspTBase), PcdGet32 (PcdFlashFvFspTSize))); - PeiServicesInstallFvInfo2Ppi ( - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 (PcdFlashFvFspTBa= se))->FileSystemGuid), - (VOID *) (UINTN) PcdGet32 (PcdFlashFvFspTBase), - PcdGet32 (PcdFlashFvFspTSize), - NULL, - NULL, - 0 - ); - } - DEBUG ((DEBUG_INFO, "Install FlashFvSecurity - 0x%x, 0x%x\n", PcdGet32 (= PcdFlashFvSecurityBase), PcdGet32 (PcdFlashFvSecuritySize))); - PeiServicesInstallFvInfo2Ppi ( - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 (PcdFlashFvSecurity= Base))->FileSystemGuid), - (VOID *) (UINTN) PcdGet32 (PcdFlashFvSecurityBase), - PcdGet32 (PcdFlashFvSecuritySize), - NULL, - NULL, - 0 - ); - if (PcdGet8 (PcdBootStage) >=3D 6) { - DEBUG (( - DEBUG_INFO, - "Install FlashFvAdvancedPreMemory - 0x%x, 0x%x\n", - PcdGet32 (PcdFlashFvAdvancedPreMemoryBase), - PcdGet32 (PcdFlashFvAdvancedPreMemorySize) - )); - PeiServicesInstallFvInfo2Ppi ( - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 (PcdFlashFvAdvanc= edPreMemoryBase))->FileSystemGuid), - (VOID *) (UINTN) PcdGet32 (PcdFlashFvAdvancedPreMemoryBase), - PcdGet32 (PcdFlashFvAdvancedPreMemorySize), - NULL, - NULL, - 0 - ); - } -} - -VOID -ReportPostMemFv ( - VOID - ) -{ - EFI_STATUS Status; - EFI_BOOT_MODE BootMode; - - Status =3D PeiServicesGetBootMode (&BootMode); - ASSERT_EFI_ERROR (Status); - - /// - /// Note : FSP FVs except FSP-T FV are installed in IntelFsp2WrapperPkg = in Dispatch mode. - /// - - /// - /// Build HOB for DXE - /// - if (BootMode =3D=3D BOOT_IN_RECOVERY_MODE) { - /// - /// Prepare the recovery service - /// - } else { - DEBUG ((DEBUG_INFO, "Install FlashFvPostMemory - 0x%x, 0x%x\n", PcdGet= 32 (PcdFlashFvPostMemoryBase), PcdGet32 (PcdFlashFvPostMemorySize))); - PeiServicesInstallFvInfo2Ppi ( - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 (PcdFlashFvPostMe= moryBase))->FileSystemGuid), - (VOID *) (UINTN) PcdGet32 (PcdFlashFvPostMemoryBase), - PcdGet32 (PcdFlashFvPostMemorySize), - NULL, - NULL, - 0 - ); - DEBUG ((DEBUG_INFO, "Install FlashFvUefiBoot - 0x%x, 0x%x\n", PcdGet32= (PcdFlashFvUefiBootBase), PcdGet32 (PcdFlashFvUefiBootSize))); - PeiServicesInstallFvInfo2Ppi ( - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 (PcdFlashFvUefiBo= otBase))->FileSystemGuid), - (VOID *) (UINTN) PcdGet32 (PcdFlashFvUefiBootBase), - PcdGet32 (PcdFlashFvUefiBootSize), - NULL, - NULL, - 0 - ); - DEBUG ((DEBUG_INFO, "Install FlashFvOsBoot - 0x%x, 0x%x\n", PcdGet32 (= PcdFlashFvOsBootBase), PcdGet32 (PcdFlashFvOsBootSize))); - PeiServicesInstallFvInfo2Ppi ( - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 (PcdFlashFvOsBoot= Base))->FileSystemGuid), - (VOID *) (UINTN) PcdGet32 (PcdFlashFvOsBootBase), - PcdGet32 (PcdFlashFvOsBootSize), - NULL, - NULL, - 0 - ); - if (PcdGet8 (PcdBootStage) >=3D 6) { - DEBUG ((DEBUG_INFO, "Install FlashFvAdvanced - 0x%x, 0x%x\n", PcdGet= 32 (PcdFlashFvAdvancedBase), PcdGet32 (PcdFlashFvAdvancedSize))); - PeiServicesInstallFvInfo2Ppi ( - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 (PcdFlashFvAdva= ncedBase))->FileSystemGuid), - (VOID *) (UINTN) PcdGet32 (PcdFlashFvAdvancedBase), - PcdGet32 (PcdFlashFvAdvancedSize), - NULL, - NULL, - 0 - ); - } - } - - // - // Report resource HOB for flash FV - // - BuildResourceDescriptorHob ( - EFI_RESOURCE_MEMORY_MAPPED_IO, - (EFI_RESOURCE_ATTRIBUTE_PRESENT | - EFI_RESOURCE_ATTRIBUTE_INITIALIZED | - EFI_RESOURCE_ATTRIBUTE_UNCACHEABLE), - (UINTN) PcdGet32 (PcdFlashAreaBaseAddress), - (UINTN) PcdGet32 (PcdFlashAreaSize) - ); - BuildMemoryAllocationHob ( - (UINTN) PcdGet32 (PcdFlashAreaBaseAddress), - (UINTN) PcdGet32 (PcdFlashAreaSize), - EfiMemoryMappedIO - ); -} diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFv= Lib/PeiReportFvLib.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/Library= /PeiReportFvLib/PeiReportFvLib.inf deleted file mode 100644 index 4258d0f2e7..0000000000 --- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/Pei= ReportFvLib.inf +++ /dev/null @@ -1,50 +0,0 @@ -### @file -# Component information file for the Report Firmware Volume (FV) library. -# -# Copyright (c) 2018 - 2020, Intel Corporation. All rights reserved.
-# -# SPDX-License-Identifier: BSD-2-Clause-Patent -# -### - -[Defines] - INF_VERSION =3D 0x00010017 - BASE_NAME =3D PeiReportFvLib - FILE_GUID =3D 44328FA5-E4DD-4A15-ABDF-C6584AC363D9 - VERSION_STRING =3D 1.0 - MODULE_TYPE =3D PEIM - LIBRARY_CLASS =3D ReportFvLib - -[LibraryClasses] - BaseMemoryLib - DebugLib - HobLib - PeiServicesLib - -[Packages] - MdePkg/MdePkg.dec - MdeModulePkg/MdeModulePkg.dec - MinPlatformPkg/MinPlatformPkg.dec - -[Sources] - PeiReportFvLib.c - -[Pcd] - gMinPlatformPkgTokenSpaceGuid.PcdBootStage ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTBase ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemoryBase ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootBase ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootSize ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootBase ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvOsBootSize ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecurityBase ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvSecuritySize ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedPreMemoryBase ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedPreMemorySize ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedBase ## CONSU= MES - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvAdvancedSize ## CONSU= MES --=20 2.27.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82166): https://edk2.groups.io/g/devel/message/82166 Mute This Topic: https://groups.io/mt/86360118/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-