From nobody Sun Feb 8 20:13:14 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112768+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112768+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1703091729; cv=none; d=zohomail.com; s=zohoarc; b=Ms5bdJzzYpn52dri2ZXp9X8f/L7wIhe+EjbE2jgg3FgznRJ5Eau40YoQmZime4HYbVWF/9s4XWAZ8eBJuKhld9+c4Rp2j7BKJwaPG20f0eV4A5WbgQpVjPAOfgCes1261ybCq5IzvPalEq2H9yzW+VdDVbxomPNyqBhQBBnufgc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1703091729; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=52l6v0nZgCeTozTUozCjwSEQWDxIC4D4KfktcYorpCY=; b=gY9PV1N2zhTfvQ1DTnL9FIy6rXbxhAENS2HPeToGecyntWbqTPLfvqFZVLpigcJ7BLEKGui4FNduwp1+rJiXcUjfihYrodAuJyFA+qwjgutTD5jX6JKbbTHSz8V7VEWdUy4I+CPZwdnUPGXOEe+nzP+8PzQJjINMgPedBw/25D4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112768+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1703091729730547.2562368770685; Wed, 20 Dec 2023 09:02:09 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=GH7JfOhvG7xJroNu56Hp4Iy4JWLAE3hBxSabJ5OtAAk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1703091729; v=1; b=k6IUTFR+ba1y3i71Dbs1p/6bS7+7WVSWhnFpsfHX3VASI/9JR3PX8mXnNLH+jzjxPl7a/LJ1 f69ygL+g4cxK6YVRJauFTFqkyWiNP1RZElYcQJb3tbbVHej/8SWaESMAo0h9asKoQCn1wFk6D0n m2ZgF+YTkszQXWkYfE8h29AA= X-Received: by 127.0.0.2 with SMTP id BrXqYY1788612x8rmtxnLaKp; Wed, 20 Dec 2023 09:02:09 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by mx.groups.io with SMTP id smtpd.web10.26890.1703091715141496173 for ; Wed, 20 Dec 2023 09:02:08 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="2671123" X-IronPort-AV: E=Sophos;i="6.04,291,1695711600"; d="scan'208";a="2671123" X-Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Dec 2023 09:02:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10930"; a="920029768" X-IronPort-AV: E=Sophos;i="6.04,291,1695711600"; d="scan'208";a="920029768" X-Received: from shpfwdbuild003.ccr.corp.intel.com ([10.239.56.82]) by fmsmga001.fm.intel.com with ESMTP; 20 Dec 2023 09:02:07 -0800 From: "Xu, Wei6" To: devel@edk2.groups.io Cc: Wei6 Xu , Abner Chang , Nate DeSimone , Lixia Huang Subject: [edk2-devel] [PATCH edk2-platforms 4/4] IpmiFeaturePkg/BmcElog: Support Standalone MM Date: Thu, 21 Dec 2023 01:01:45 +0800 Message-Id: <2191e4b069e111eca0ecf0802f47496415fa98b5.1703090380.git.wei6.xu@intel.com> In-Reply-To: References: MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,wei6.xu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oKQjpREFH9ccEq4x26Rs2ONmx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1703091731102100009 Content-Type: text/plain; charset="utf-8" Refactor BmcElog to support Standalone MM. Remove unused code. Cc: Abner Chang Cc: Nate DeSimone Signed-off-by: Lixia Huang --- .../IpmiFeaturePkg/BmcElog/Smm/BmcElog.c | 14 ++---- .../IpmiFeaturePkg/BmcElog/Smm/BmcElog.h | 15 +++++-- .../BmcElog/Smm/BmcElogStandaloneMm.c | 28 ++++++++++++ .../BmcElog/Smm/BmcElogTraditionalMm.c | 28 ++++++++++++ .../IpmiFeaturePkg/BmcElog/SmmBmcElog.inf | 6 +-- .../BmcElog/StandaloneMmBmcElog.inf | 44 +++++++++++++++++++ .../IpmiFeaturePkg/Include/IpmiFeature.dsc | 1 + 7 files changed, 119 insertions(+), 17 deletions(-) create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcEl= og/Smm/BmcElogStandaloneMm.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcEl= og/Smm/BmcElogTraditionalMm.c create mode 100644 Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcEl= og/StandaloneMmBmcElog.inf diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/= BmcElog.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/B= mcElog.c index efaa61f43869..0c166f733a7d 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/BmcElog= .c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/BmcElog= .c @@ -228,7 +228,7 @@ SetElogRedirInstall ( // Now install the Protocol // NewHandle =3D NULL; - Status =3D gSmst->SmmInstallProtocolInterface ( + Status =3D gMmst->MmInstallProtocolInterface ( &NewHandle, &gSmmRedirElogProtocolGuid, EFI_NATIVE_INTERFACE, @@ -249,28 +249,20 @@ SetElogRedirInstall ( } =20 /** - InitializeBmcElogLayer. - - @param ImageHandle - ImageHandle of the loaded driver - @param SystemTable - Pointer to the System Table + InitializeSmBmcElogLayer. =20 @retval EFI_STATUS =20 **/ EFI_STATUS -EFIAPI InitializeSmBmcElogLayer ( - IN EFI_HANDLE ImageHandle, - IN EFI_SYSTEM_TABLE *SystemTable + VOID ) { EFI_STATUS Status; =20 Status =3D EFI_SUCCESS; =20 - gST =3D SystemTable; - gBS =3D gST->BootServices; - mRedirProtoPrivate =3D AllocatePool (sizeof (EFI_BMC_ELOG_INSTANCE_DATA)= ); ASSERT (mRedirProtoPrivate !=3D NULL); if (mRedirProtoPrivate =3D=3D NULL) { diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/= BmcElog.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/B= mcElog.h index 218af380a229..89680f2f0ff1 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/BmcElog= .h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/BmcElog= .h @@ -13,9 +13,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent // Statements that include other files // =20 -#include -#include -#include +#include #include #include #include "BmcElogCommon.h" @@ -40,4 +38,15 @@ typedef struct { =20 #define INSTANCE_FROM_EFI_SM_ELOG_REDIR_THIS(a) CR (a, EFI_BMC_ELOG_INSTA= NCE_DATA, BmcElog, SM_ELOG_REDIR_SIGNATURE) =20 +/** + InitializeSmBmcElogLayer. + + @retval EFI_STATUS + +**/ +EFI_STATUS +InitializeSmBmcElogLayer ( + VOID + ); + #endif //_SMM_BMCELOG_H_ diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/= BmcElogStandaloneMm.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/B= mcElog/Smm/BmcElogStandaloneMm.c new file mode 100644 index 000000000000..1d883a6cd1e7 --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/BmcElog= StandaloneMm.c @@ -0,0 +1,28 @@ +/** @file + Entry Piont of Bmc Elog Standalone MM Driver. + +Copyright (c) 2023, Intel Corporation. All rights reserved.
+SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include "BmcElog.h" + +/** + InitializeBmcElogLayerStandaloneMm. + + @param[in] ImageHandle ImageHandle of the loaded driver + @param[in] SystemTable Pointer to the MM System Table + + @retval EFI_STATUS + +**/ +EFI_STATUS +EFIAPI +InitializeSmBmcElogLayerStandaloneMm ( + IN EFI_HANDLE ImageHandle, + IN EFI_MM_SYSTEM_TABLE *SystemTable + ) +{ + return InitializeSmBmcElogLayer (); +} diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/= BmcElogTraditionalMm.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/= BmcElog/Smm/BmcElogTraditionalMm.c new file mode 100644 index 000000000000..16113f8bec27 --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Smm/BmcElog= TraditionalMm.c @@ -0,0 +1,28 @@ +/** @file + Entry Piont of Bmc Elog SMM Driver. + +Copyright (c) 2023, Intel Corporation. All rights reserved.
+SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include "BmcElog.h" + +/** + InitializeBmcElogLayerSmm. + + @param[in] ImageHandle ImageHandle of the loaded driver + @param[in] SystemTable Pointer to the System Table + + @retval EFI_STATUS + +**/ +EFI_STATUS +EFIAPI +InitializeSmBmcElogLayerSmm ( + IN EFI_HANDLE ImageHandle, + IN EFI_SYSTEM_TABLE *SystemTable + ) +{ + return InitializeSmBmcElogLayer (); +} diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/SmmB= mcElog.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/SmmB= mcElog.inf index d6880f8baa1b..8fa60fe6ac02 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/SmmBmcElog.= inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/SmmBmcElog.= inf @@ -14,11 +14,12 @@ MODULE_TYPE =3D DXE_SMM_DRIVER PI_SPECIFICATION_VERSION =3D 0x0001000A VERSION_STRING =3D 1.0 - ENTRY_POINT =3D InitializeSmBmcElogLayer + ENTRY_POINT =3D InitializeSmBmcElogLayerSmm =20 [Sources] Smm/BmcElog.c Smm/BmcElog.h + Smm/BmcElogTraditionalMm.c Common/BmcElogCommon.h Common/BmcElogCommon.c =20 @@ -30,9 +31,8 @@ [LibraryClasses] UefiDriverEntryPoint DebugLib - UefiBootServicesTableLib ReportStatusCodeLib - SmmServicesTableLib + MmServicesTableLib IpmiBaseLib =20 [Protocols] diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/Stan= daloneMmBmcElog.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Bmc= Elog/StandaloneMmBmcElog.inf new file mode 100644 index 000000000000..9a229ab7abac --- /dev/null +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/StandaloneM= mBmcElog.inf @@ -0,0 +1,44 @@ +### @file +# +# Copyright (c) 2023, Intel Corporation. All rights reserved.
+# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# +### + + +[Defines] + INF_VERSION =3D 0x00010005 + BASE_NAME =3D SmBmcElogStandaloneMm + FILE_GUID =3D 802bc368-2f35-4fb5-9675-bf76a7601690 + MODULE_TYPE =3D MM_STANDALONE + PI_SPECIFICATION_VERSION =3D 0x00010032 + VERSION_STRING =3D 1.0 + ENTRY_POINT =3D InitializeSmBmcElogLayerStandaloneMm + +[Sources] + Smm/BmcElog.c + Smm/BmcElog.h + Smm/BmcElogStandaloneMm.c + Common/BmcElogCommon.h + Common/BmcElogCommon.c + +[Packages] + IpmiFeaturePkg/IpmiFeaturePkg.dec + MdePkg/MdePkg.dec + MdeModulePkg/MdeModulePkg.dec + +[LibraryClasses] + StandaloneMmDriverEntryPoint + DebugLib + ReportStatusCodeLib + MmServicesTableLib + IpmiBaseLib + +[Protocols] + gSmmRedirElogProtocolGuid # PROTOCOL ALWAYS_PRODUCED + +[Depex] + gEfiLoadedImageProtocolGuid AND + gSmmIpmiTransportProtocolGuid + diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ipmi= Feature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ipm= iFeature.dsc index 12060d156ef4..bf8244469063 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature= .dsc +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature= .dsc @@ -130,6 +130,7 @@ IpmiFeaturePkg/BmcAcpiSwChild/BmcAcpiSwChildStandaloneMm.inf IpmiFeaturePkg/BmcElog/DxeBmcElog.inf IpmiFeaturePkg/BmcElog/SmmBmcElog.inf + IpmiFeaturePkg/BmcElog/StandaloneMmBmcElog.inf IpmiFeaturePkg/GenericElog/Dxe/GenericElog.inf IpmiFeaturePkg/GenericElog/Smm/GenericElog.inf IpmiFeaturePkg/GenericElog/Smm/GenericElogStandaloneMm.inf --=20 2.29.2.windows.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112768): https://edk2.groups.io/g/devel/message/112768 Mute This Topic: https://groups.io/mt/103284565/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-