From nobody Mon Sep 16 19:54:44 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+114591+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1706274749936924.502693895765; Fri, 26 Jan 2024 05:12:29 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=oBMnUwpDnh07RF7sVY7hjtnWxd0z/j69eGUj2DseLo4=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1706274749; v=1; b=ACX0bgtI23oWbHzuLI4JEVFsWBPTOF8XcRyqgurspdb+yHnybWKTIfmsbqgcQ6gmjASynI4T fj3JemnzvZxcqd8zSqCEmimCkP1MVIjYQtmS/Nr9/ZFtf3/oeJ7Bxa4VHtDHkOLqau1QHNBECWN xxoBsJ9HOasI/kuC+z0ScEOM= X-Received: by 127.0.0.2 with SMTP id tqksYY1788612xJ2CmbWixpK; Fri, 26 Jan 2024 05:12:29 -0800 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (NAM04-MW2-obe.outbound.protection.outlook.com [40.107.101.81]) by mx.groups.io with SMTP id smtpd.web11.15448.1706274748921219950 for ; Fri, 26 Jan 2024 05:12:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BS2m8NMtivwfRPvy0WUoZZkel/L+y74zDoDb8/7mijeFwbJcVlp1IyBD72Tdujpm6Ws8+fd8w6FFnH4ky+pxL7By4Mqip4Yzqv4F0KDyItNYMCZDQn1tXn5rI3lnRg7oQyanFfqEZvBd6Wa/vGF7+Rubve2XNHwQphuH91gsT7FGNMjY+tYnIHTQDJt23JQKK4xM1bs5z+MRMVLoccsmlf9Jbiqc72jMo3avijsOatLo3MNQTNVzCdkzDQos+O0SSk3FP9ktjQg/tqFz4x4Pwq+5jGQibE84htT+3vzz9juoIKPEswBSKIZefaf3rg2WSe2SwX6CxQ4ljxnfgjfnPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SreaIcVslUnmL2mn284EtCYZjwMVRvkiDWeJK9690xI=; b=DfnHBQCgujHO9ECLB8UP8VpWCDkffOioGqsdHtmggHTXFZU6Q213zBDhdcXIGbQ2UgIB/iaQDeeWsJocM0oM5PtEhotfFitOa8KOVWz7eLMzY9rjoJCymfWXl/nhQIpZWx1WW7y3wGAKahbpfOpVy5IhYWL6GDJq7ZA0/PvpdmgnUTLa78Wjupe5lAj8mNgkeAfa/0D4+9vpxX5cuB5e0JBVoZa/TZ1JVTsZGRDUzrr5MaJOvEoisPhwmerRYGg3X+tlLJgmzRb77mHCDudPSGMdZkbC2XYmJR0A79AiiRY3gV59iSrPMOUCeorzUEx/fGpsOz3XjG9fAebZplPIQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from CYZPR05CA0006.namprd05.prod.outlook.com (2603:10b6:930:89::10) by MN0PR12MB5881.namprd12.prod.outlook.com (2603:10b6:208:379::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.26; Fri, 26 Jan 2024 13:12:26 +0000 X-Received: from CY4PEPF0000E9D3.namprd03.prod.outlook.com (2603:10b6:930:89:cafe::7b) by CYZPR05CA0006.outlook.office365.com (2603:10b6:930:89::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.15 via Frontend Transport; Fri, 26 Jan 2024 13:12:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+114591+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CY4PEPF0000E9D3.mail.protection.outlook.com (10.167.241.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7228.16 via Frontend Transport; Fri, 26 Jan 2024 13:12:26 +0000 X-Received: from SHA-LX-MINGXZHA.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 26 Jan 2024 07:12:23 -0600 From: "Zhai, MingXin (Duke) via groups.io" To: CC: Eric Xing , Ken Yao , Igniculus Fu , Abner Chang Subject: [edk2-devel] [PATCH V3 15/32] AMD/VanGoghBoard: Check in SpiFlashDeviceLib Date: Fri, 26 Jan 2024 21:11:08 +0800 Message-ID: <20240126131125.1881-16-duke.zhai@amd.com> In-Reply-To: <20240126131125.1881-1-duke.zhai@amd.com> References: <20240126131125.1881-1-duke.zhai@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D3:EE_|MN0PR12MB5881:EE_ X-MS-Office365-Filtering-Correlation-Id: 9bb85198-3bb4-4c5d-3c45-08dc1e70711a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: nxsoS1XqbKpJLfmU2KLNcc0tTLwXYIQMEV4684uwMds9CC52L8o9Ae2zUvD6EkAH+e9A5GoguiZ9wme00R2u5Sl4RpXeB4koa7VAmCP1t1gF0PqnYXCBlZHi9zQQOKRh5nbm97jNNPUBSwOEceK5JuFDBcBnOgKsud+1KOmBedIERzJYJNYQLUqvt0JODLe/AsF5jk6vg3SvfH+QOv0eoGqdu4x80cM9l506EUJ+l2hrgTxjSCNuneJpjbiPodqhhSlK87nCNlfbp4B2lqo+oiXfrww4Ns8BVImTH7s3rH1zZ9sJl+ZIVJ7nIvvdPWhbd0nwALUljv9cbAr0wZ/SrmQ68SZ0/wVKVUBSt8RZRpBXhGys8XEGqIqZoRZe67Qsq9HeJfo2oPZYX56aNB6LDNooDAul8D8ymHhWTMR/0IQHmUv6lNRO1P4heawNoLgLGfUb2FwAMM+ma0DJJbRQYSX4/surZZljkWNFqQdDeqqCuLtK6zjU+RFE3jhh/xeWWM9AH4PzHTuTYw5WKkzg+QEHm8LWiTirXLRDPd4PXWVwucIutk60Fx+GtDJgB3N4yo/PNtAHq57OmubdtdGWOs7WGK+uYpfZvnSiqx/6uVDIpeJJRVBWlqw1tIkUAmMFtRkGtdiWGW7N/jN6gact5qOad6K7FwjX0BEX66TlXZdCzMU48aCAZqfZHqsZJj22fXeEjRPASHIVqOMyU/+v2LBSYFV8bFB1RpFCVYJ07wGzhZ3M+ye5lrsGOmLJLTf9RUsyAaTMcQXl4k4CUz01WA== X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jan 2024 13:12:26.1389 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9bb85198-3bb4-4c5d-3c45-08dc1e70711a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D3.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5881 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,duke.zhai@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bAuZ3Upbf1mYRmZ1nDQxRxAlx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1706274752012100019 Content-Type: text/plain; charset="utf-8" From: Duke Zhai BZ #:4640 In V2: Improve coding style. 1.Remove the leading underscore and use double underscore at trailing in = C header files. 2.Remove old tianocore licenses and redundant license description. 3.Improve coding style. For example: remove space between @param. In V1: Initial AMD SpiFlashDeviceLib for Chachani board flash IC. Chachani board use the W25Q256JW as flash IC. Signed-off-by: Duke Zhai Cc: Eric Xing Cc: Ken Yao Cc: Igniculus Fu Cc: Abner Chang --- .../SpiFlashDeviceLib/SpiFlashDeviceLib.c | 42 +++++++++++++++++++ .../SpiFlashDeviceLib/SpiFlashDeviceLib.inf | 29 +++++++++++++ 2 files changed, 71 insertions(+) create mode 100644 Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Library/SpiF= lashDeviceLib/SpiFlashDeviceLib.c create mode 100644 Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Library/SpiF= lashDeviceLib/SpiFlashDeviceLib.inf diff --git a/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Library/SpiFlashDev= iceLib/SpiFlashDeviceLib.c b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Lib= rary/SpiFlashDeviceLib/SpiFlashDeviceLib.c new file mode 100644 index 0000000000..49636f6a89 --- /dev/null +++ b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Library/SpiFlashDeviceLib/= SpiFlashDeviceLib.c @@ -0,0 +1,42 @@ +/** @file + Implements SpiFlashDeviceLib.c + + Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include + +SPI_INIT_TABLE mSpiInitTable[] =3D { + { // W25Q256JW/W74M25JW + SF_VENDOR_ID_WINBOND, + SF_DEVICE_ID0_W25Q256JW, + SF_DEVICE_ID1_W25Q256JW, + { + SPI_COMMAND_WRITE_ENABLE, + SPI_COMMAND_WRITE_S_EN + }, + { + { EnumSpiOpcodeReadNoAddr,SPI_COMMAND_JEDEC_ID, EnumSpiOper= ationJedecId }, + { EnumSpiOpcodeWriteNoAddr,SPI_COMMAND_WRITE_S, EnumSpiOpe= rationWriteStatus }, + { EnumSpiOpcodeWrite, SPI_COMMAND_WRITE, EnumSpiOpera= tionProgramData_1_Byte }, + { EnumSpiOpcodeRead, SPI_COMMAND_READ, EnumSpiOpera= tionReadData }, + { EnumSpiOpcodeWrite, SPI_COMMAND_ERASE, EnumSpiOpera= tionErase_4K_Byte }, + { EnumSpiOpcodeReadNoAddr,SPI_COMMAND_READ_S, EnumSpiOper= ationReadStatus }, + { EnumSpiOpcodeWriteNoAddr,SPI_COMMAND_CHIP_ERASE, EnumSpiOpe= rationFullChipErase }, + { EnumSpiOpcodeRead, SPI_COMMAND_READ_SFDP, EnumSpiOpera= tionReadData }, + { EnumSpiOpcodeWriteNoAddr,SPI_COMMAND_RPMC_OP1, EnumSpiOpe= rationOther }, + { EnumSpiOpcodeReadNoAddr,SPI_COMMAND_RPMC_OP2, EnumSpiOper= ationReadData }, + { EnumSpiOpcodeReadNoAddr,SPI_COMMAND_Enter_4Byte_Addr, EnumSpiOper= ationOther }, + { EnumSpiOpcodeReadNoAddr,SPI_COMMAND_Exit_4Byte_Addr, EnumSpiOper= ationOther } + }, + 0, + 0x2000000 // BIOS image size in flash + } +}; + +// +// The total number of support flash part +// +UINT8 mNumSpiFlashMax =3D sizeof (mSpiInitTable) / sizeof (mSpiInitTable[= 0]); diff --git a/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Library/SpiFlashDev= iceLib/SpiFlashDeviceLib.inf b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/L= ibrary/SpiFlashDeviceLib/SpiFlashDeviceLib.inf new file mode 100644 index 0000000000..951cf6c480 --- /dev/null +++ b/Platform/AMD/VanGoghBoard/VanGoghCommonPkg/Library/SpiFlashDeviceLib/= SpiFlashDeviceLib.inf @@ -0,0 +1,29 @@ +## @file +# SpiFlashDeviceLib +# +# Copyright (C) 2024 Advanced Micro Devices, Inc. All rights reserved.
+# SPDX-License-Identifier: BSD-2-Clause-Patent +# +## + +[Defines] + INF_VERSION =3D 0x00010005 + BASE_NAME =3D SpiFlashDeviceLib + FILE_GUID =3D D5A903A8-4D19-4E4C-AAF4-07C5D10D5939 + MODULE_TYPE =3D BASE + VERSION_STRING =3D 1.0 + LIBRARY_CLASS =3D SpiFlashDeviceLib + +# +# VALID_ARCHITECTURES =3D IA32 X64 +# + +[Sources] + SpiFlashDeviceLib.c + +[Packages] + MdePkg/MdePkg.dec + VanGoghCommonPkg/AmdCommonPkg.dec + +[LibraryClasses] + SpiFlashDeviceLib --=20 2.31.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114591): https://edk2.groups.io/g/devel/message/114591 Mute This Topic: https://groups.io/mt/103975457/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-