From nobody Mon May 25 10:49:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113920+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113920+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1705425076; cv=none; d=zohomail.com; s=zohoarc; b=kQuDcwlZhmmvpht2ftrWsyxwuwf+rZDw8i7mHBsEnE+uGzh4yCUlvyLf1/55pQF8TX42lawIbd6bcHEa40ogjVblthvHdJp/usW+Jqb211O816UGAJ30zq2P7FAxBLVkjZnYe9z289rFejauI8dYJ3hZOGYkF2mqfJrNlPgLzRM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1705425076; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=XYCtSgl9bcriLal3Wr2Mqr2aE8xd749yyxYopCQgUqQ=; b=KpgfjjH5lFDW2JL1nVaySiRqUhiGSvn66xEqQoGKWsbWfePkW7IgU+nwbMFr7XfZMh8ijsdKQv/rAM6VdPBYs6zgYGc6O3ucgmffuh6jV7LJeHm3ahjSDoMEGzqIkd8xfqC4VDX/wib1zavuqcjozkmYWOCi8if/D7k3vbN1+aI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113920+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1705425076488412.9870933137271; Tue, 16 Jan 2024 09:11:16 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=wbJtf7WQJgzk1QOqnK0E1v7+QAodJzoZ/RMECYhiYcs=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1705425076; v=1; b=gjgl8uiolrGtMoexxeiBuWjWVoMBDN2t4qwQ0MmXvRiWmQXWGbcjqVSK24GcRaSxLHOY+7qc MASjJK9u0z3vOnvDFh4GH1Wia7oaIVTYJAQ14UOPLcPHkUe+RfFl/swsTtopyjRPYK7clnWCuM8 e/RkLNjvciZH5k1T8U7hi9MM= X-Received: by 127.0.0.2 with SMTP id fQflYY1788612xPjpYkUiDlt; Tue, 16 Jan 2024 09:11:16 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.22114.1705425073746295000 for ; Tue, 16 Jan 2024 09:11:13 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-221-Y5EptwN6N5y2dEagSAym3Q-1; Tue, 16 Jan 2024 12:11:11 -0500 X-MC-Unique: Y5EptwN6N5y2dEagSAym3Q-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9B05385A58F for ; Tue, 16 Jan 2024 17:11:10 +0000 (UTC) X-Received: from dobby.home.kraxel.org (unknown [10.39.192.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A3CD2026D6F; Tue, 16 Jan 2024 17:11:10 +0000 (UTC) X-Received: by dobby.home.kraxel.org (Postfix, from userid 1000) id 66CB5AEDC2; Tue, 16 Jan 2024 18:11:05 +0100 (CET) From: "Gerd Hoffmann" To: devel@edk2.groups.io Cc: oliver@redhat.com, Gerd Hoffmann , Laszlo Ersek Subject: [edk2-devel] [PATCH v3 5/6] OvmfPkg/VirtNorFlashDxe: ValidateFvHeader: unwritten state is EOL too Date: Tue, 16 Jan 2024 18:11:04 +0100 Message-ID: <20240116171105.37831-6-kraxel@redhat.com> In-Reply-To: <20240116171105.37831-1-kraxel@redhat.com> References: <20240116171105.37831-1-kraxel@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: Km1Qxvo1ovaR0cvW13TYoIJpx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1705425077357100018 Content-Type: text/plain; charset="utf-8"; x-default="true" It is possible to find variable entries with State being 0xff, i.e. not updated since flash block erase. This indicates the variable driver could not complete the header write while appending a new entry, and therefore State was not set to VAR_HEADER_VALID_ONLY. This can only happen at the end of the variable list, so treat this as additional "end of variable list" condition. Signed-off-by: Gerd Hoffmann Reviewed-by: Laszlo Ersek --- OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c b/OvmfPkg/VirtNorFla= shDxe/VirtNorFlashFvb.c index 8fcd999ac6df..c8b5e0be1379 100644 --- a/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c +++ b/OvmfPkg/VirtNorFlashDxe/VirtNorFlashFvb.c @@ -302,6 +302,11 @@ ValidateFvHeader ( break; } =20 + if (VarHeader->State =3D=3D 0xff) { + DEBUG ((DEBUG_INFO, "%a: end of var list (unwritten state)\n", __fun= c__)); + break; + } + VarName =3D NULL; switch (VarHeader->State) { // usage: State =3D VAR_HEADER_VALID_ONLY --=20 2.43.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113920): https://edk2.groups.io/g/devel/message/113920 Mute This Topic: https://groups.io/mt/103766778/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-