From nobody Fri May 17 02:41:13 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113600+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113600+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1704963607; cv=none; d=zohomail.com; s=zohoarc; b=jK6YMqkEN+NsJCfd2vxTD5RjNYM/NOmKy7sa94KrrbZkqiXf+LHVD7HWLqgVhdndxSreelqGxeqQCoHT4oy9eXKg1cBz5KN1rtvXnQZeN0jMqES1+sRVoouroBiV14ulXYT8720Oi8iwqKm5/dn7xh1Jl9Tp+KaN5j8H/bGCFLE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704963607; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Sender:Subject:Subject:To:To:Message-Id; bh=XwE6ZaWxrZm0I6yT7+P4qIm8tjxJzY0u7ckqFeVrTBE=; b=J6+K4IhIlFVR1QpK/91malZmYfZeIFzNj0woFFQzmjHanFyDkwXoWmVzWzpybhLYTKUFKfArSyr+yt2/fHC5Vb/MasfdGAtKOYJ+NI88eTUekmMlVTFXqv6zqOFAnAM8McxltF7wWOpwMGdGyuo/Swlzpg/k573IxOm9fEb/4w4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113600+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704963607131315.42611322306425; Thu, 11 Jan 2024 01:00:07 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=etftVQqtOOox/ZEtRa6D6piUPW3fU/zIrExsZ1MZy7M=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704963606; v=1; b=WgU4SgV6n3LczM9MtRIJN1+pNs5PU8w7arrFxZfoWMA6NTNSa7ATc0MKtuRpdkZ8a6fbPv4j D0uEamGxON+nFeHbF0zCc+g/exXT9K2UN9BOP6uUvl0nYHIjq6JsD9v+MIbiyd/9Um9iaokMpu9 siYRWUYOB3NHw+1CIE6ltTEE= X-Received: by 127.0.0.2 with SMTP id mCfdYY1788612xpfIY0woGRv; Thu, 11 Jan 2024 01:00:06 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mx.groups.io with SMTP id smtpd.web11.7619.1704963605950076673 for ; Thu, 11 Jan 2024 01:00:06 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="6145502" X-IronPort-AV: E=Sophos;i="6.04,185,1695711600"; d="scan'208";a="6145502" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2024 01:00:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10949"; a="1029473239" X-IronPort-AV: E=Sophos;i="6.04,185,1695711600"; d="scan'208";a="1029473239" X-Received: from shwdeopenlab702.ccr.corp.intel.com ([10.239.55.43]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2024 00:59:59 -0800 From: "duntan" To: devel@edk2.groups.io Cc: Ray Ni , Laszlo Ersek , Rahul Kumar , Gerd Hoffmann Subject: [edk2-devel] [Patch V3] UefiCpuPkg:Limit PhysicalAddressBits in special case Date: Thu, 11 Jan 2024 16:59:47 +0800 Message-Id: <20240111085947.1105-1-dun.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AgTkwLA88etnstBg83QjJ2rgx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704963607920100003 Content-Type: text/plain; charset="utf-8" When creating smm page table, limit maximum supported physical address bits returned by CalculateMaximumSupportAddress() to 47 if 5-Level Paging is disabled. When 5-Level Paging is disabled and the PhysicalAddressBits retrived from CPU HOB or CpuId is bigger than 47, and since virtual addresses are sign-extended, only [0, 2^47-1] range in 52-bit physical address is mapped in page table. Signed-off-by: Dun Tan Reviewed-by: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann --- UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c b/UefiCpuPkg/PiSmmCpuD= xeSmm/X64/PageTbl.c index ddd9be66b5..35c282a771 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c @@ -137,11 +137,13 @@ GetSubEntriesNum ( /** Calculate the maximum support address. =20 + @param[in] Is5LevelPagingNeeded If 5-level paging enabling is needed. + @return the maximum support address. **/ UINT8 CalculateMaximumSupportAddress ( - VOID + BOOLEAN Is5LevelPagingNeeded ) { UINT32 RegEax; @@ -164,6 +166,15 @@ CalculateMaximumSupportAddress ( } } =20 + // + // Only [0, 2^47 -1] in 52-bit physical addresses is mapped in page table + // when 5-Level Paging is disabled. + // + ASSERT (PhysicalAddressBits <=3D 52); + if (!Is5LevelPagingNeeded && (PhysicalAddressBits > 47)) { + PhysicalAddressBits =3D 47; + } + return PhysicalAddressBits; } =20 @@ -197,7 +208,7 @@ SmmInitPageTable ( mCpuSmmRestrictedMemoryAccess =3D PcdGetBool (PcdCpuSmmRestrictedMemoryA= ccess); m1GPageTableSupport =3D Is1GPageSupport (); m5LevelPagingNeeded =3D Is5LevelPagingNeeded (); - mPhysicalAddressBits =3D CalculateMaximumSupportAddress (); + mPhysicalAddressBits =3D CalculateMaximumSupportAddress (m5Leve= lPagingNeeded); PatchInstructionX86 (gPatch5LevelPagingNeeded, m5LevelPagingNeeded, 1); if (m5LevelPagingNeeded) { mPagingMode =3D m1GPageTableSupport ? Paging5Level1GB : Paging5Level; --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113600): https://edk2.groups.io/g/devel/message/113600 Mute This Topic: https://groups.io/mt/103658816/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-