From nobody Fri May 17 05:26:25 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113514+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113514+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1704865409; cv=none; d=zohomail.com; s=zohoarc; b=RhqeqQmkPY9Q3crOEpmfuNY5diCSa5cx8ltMx9lWqiDjJnc1Q8zVBUtHP4h/9/jo4Sv+0xU08vUPWjMwa3DhncTFuIvN/yIMgOMP31drFncboHDsdS+YR6FIen1od7LmMayHOtdQhH4KeXuCI/CpBLMgp3xaA+x0wiUpQYHH7/0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704865409; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:Sender:Subject:Subject:To:To:Message-Id; bh=+HfPOsnm9w1ZRBjxGsmOrVnYLLJcdJ5INixaa1JVSSk=; b=OCuahtm1GoHW2J4gyrD9F7ERCeZnw+SCyMGNiSwUKuhFv2Fi6FgNDVlEX5/XnAKWXtiwTXoVZy8xIUGH5H5TaKBTreNtqPxRF8YSNyVwz8lNtkNoRPs1YfhbSQ1wUGzq8kIq1qgETDpIsuJWyVsIAaebQMwbqgiUs9LYbnkE3dU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113514+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704865409323934.4276911717155; Tue, 9 Jan 2024 21:43:29 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=ewvqkjXZ1LDjWNF7dtQl1mmRTGjt9dP3DEjpLFdGkP4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704865408; v=1; b=saG3JaB3Dm0zPdcGaoiE1W4+SzftqUaq/AIECrJWWklWQE/J1wG81+PdWkasaa9Z16HCbX11 9Cp77T2KvkbTVQIXhx3ybN9ym5HO04hNFQ8HQFm0MfWrca+ncyZ6+zlXhaHBUK9oPgn83A3QkSU Uj3Cl6x3Ic6WOBnbE8OOaIU4= X-Received: by 127.0.0.2 with SMTP id 4qmHYY1788612xILR2dr1QYD; Tue, 09 Jan 2024 21:43:28 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.6028.1704865407694700882 for ; Tue, 09 Jan 2024 21:43:28 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10947"; a="462700194" X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="462700194" X-Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 21:43:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,184,1695711600"; d="scan'208";a="16520155" X-Received: from shwdesfp01.ccr.corp.intel.com ([10.239.158.151]) by fmviesa002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2024 21:43:25 -0800 From: "Zhiguang Liu" To: devel@edk2.groups.io Cc: Zhiguang Liu , Ray Ni , Laszlo Ersek , Rahul Kumar , Gerd Hoffmann Subject: [edk2-devel] [PATCH] UefiCpuPkg/CpuMpPei: Don't write CR3 in ConvertMemoryPageToNotPresent Date: Wed, 10 Jan 2024 13:43:18 +0800 Message-Id: <20240110054318.997-1-zhiguang.liu@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,zhiguang.liu@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: zuMplNPhMmD0NEkj09mzzIBHx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704865410872100003 Content-Type: text/plain; charset="utf-8" After ConvertMemoryPageToNotPresent, there is always a flush TLB function. So, to improve performance, there is no need to write CR3 inside ConvertMemoryPageToNotPresent Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Zhiguang Liu Reviewed-by: Ray Ni --- UefiCpuPkg/CpuMpPei/CpuPaging.c | 1 - 1 file changed, 1 deletion(-) diff --git a/UefiCpuPkg/CpuMpPei/CpuPaging.c b/UefiCpuPkg/CpuMpPei/CpuPagin= g.c index 15c7015fb8..c6894458f7 100644 --- a/UefiCpuPkg/CpuMpPei/CpuPaging.c +++ b/UefiCpuPkg/CpuMpPei/CpuPaging.c @@ -167,7 +167,6 @@ ConvertMemoryPageToNotPresent ( } =20 ASSERT_EFI_ERROR (Status); - AsmWriteCr3 (PageTable); return Status; } =20 --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113514): https://edk2.groups.io/g/devel/message/113514 Mute This Topic: https://groups.io/mt/103636435/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-