From nobody Fri May 17 04:49:48 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113424+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704784488962901.7076501219475; Mon, 8 Jan 2024 23:14:48 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=hD4eezJqPO0ajqeTSK1pWRze3kh4Adruh+W8PnJRqEg=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1704784488; v=1; b=l+EaR5/oey1U9Jm2x02TTY2AC390WzvYjB1Pt4zYB/CXYNtiueJDNWgVK+Vpb1Ha7aj5tiPO PuLNA+dA+uCkkYC8sZ7DD48RkF9S0BrWIS6/bxYTGLziJR6KTu3Oh9AQZXLhs1tzWm90AEbFzxJ Yp7AS3SI3F/AQ81FvNKLckgk= X-Received: by 127.0.0.2 with SMTP id x8SEYY1788612xFzQE8FNO7o; Mon, 08 Jan 2024 23:14:48 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.58]) by mx.groups.io with SMTP id smtpd.web10.11812.1704784487906616743 for ; Mon, 08 Jan 2024 23:14:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VXZ7GkoOlg3yhyHp7PBVOOyQ00hO5k9x0Q3efUjfr/7gjTIkpl0vqQoNI3WSAV/LE5SVw4168ibuzUAuhG3k4WwbbTyPdLu+9LW6ZMQKvq4rjUCRi9KtWVq6gjoG7ybRAVHoL2oPwe9stEDT2/+hYVcVqsQCPbPnM8AIfNvSgw+WEVP9cHUayx8sukAozZ/9tV8ASQOqideHiHPkYwWleeX57CuJkW4hTUPvg+dNaXg4/JTzHWFBn312jFo+Q+UE4BV2IvidKj33jcvJCF5cJUScDi8RSVR4fycVBl4ZLkUpe2iW5piNpFbucAUAmlaTSmPTNlfpMAD1KZfiu64lSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jnXRHMDdWolsmqG2NzYMvXEa8POpRYtchwF0iwhCpQM=; b=ir8HqFydgb48WNy4YlGedebQ9GUHLwP3k6MwvQE2VLh0KoanbJXaqN9rC0Y7kyA6lpLgl/pEPKUiRRk2WyE/QiLYqT/vRrVNqZmIP2/0DdCEo9YrWfHxB2g79hossveDt0R5ObpR9NhCdylP3IhlbPWaWKUNuBq6uvdoWed3ChAlwfpkfkV1i+38tMmDlmcUpX3qb6c02dAI5eaNdNPbp7uV355/EQT5diwDlVLLBZ/MUWZ2MUkiOCc2sqLKo2peXra93iBEsCed3CxvoWZI97KWpA2cR9QeajS8MwXZs+VS1OYw8SIA507q9wkU1pAkLUGBdA6LcWntGlP9Wqw+sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) X-Received: from DM6PR21CA0024.namprd21.prod.outlook.com (2603:10b6:5:174::34) by SN7PR12MB8789.namprd12.prod.outlook.com (2603:10b6:806:34b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7159.21; Tue, 9 Jan 2024 07:14:44 +0000 X-Received: from DS2PEPF0000343A.namprd02.prod.outlook.com (2603:10b6:5:174:cafe::7a) by DM6PR21CA0024.outlook.office365.com (2603:10b6:5:174::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7202.6 via Frontend Transport; Tue, 9 Jan 2024 07:14:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113424+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.160) by DS2PEPF0000343A.mail.protection.outlook.com (10.167.18.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7181.13 via Frontend Transport; Tue, 9 Jan 2024 07:14:44 +0000 X-Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 8 Jan 2024 23:14:34 -0800 X-Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 8 Jan 2024 23:14:33 -0800 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Mon, 8 Jan 2024 23:14:32 -0800 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy , "Nick Ramirez" Subject: [edk2-devel] [PATCH] RedfishPkg/RedfishDebugLib: add function to print buffer. Date: Tue, 9 Jan 2024 15:14:32 +0800 Message-ID: <20240109071432.32648-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NVConfidentiality: public X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF0000343A:EE_|SN7PR12MB8789:EE_ X-MS-Office365-Filtering-Correlation-Id: a492bd5f-6445-4832-75e9-08dc10e2a806 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: po6j0AHQtnPV7hKTXCYEMXdKKFMAbQ88Q+oyaXS1PGoXd7LWGHnRINke1vuGxuC98IL5/oHJ+BSEQdxPXjDDSRVm/H7s8uhuB+baNqw3LvlOrBM/RpM1pyg1cBU2Lm1CznBGfhmhOkwfMzi1By9i6t00qM1ZGEEsYX9+GM4CLS06Ozjf1EOwZlqOYQcire3nURLiRxulCUW2isxYUT1cnef18bnQ3bZrI6RE0k7w1eeMXk3fLcnZApu1Bc0CIp8kkZ0Fo2mLXylqDhwZ8kjXtcXQe+K3PObhC8uyUPgqQZeRqzTya/UQ0LiM8rUZTIn3yvJq1LiWXCeKAXjk8tt2fj+sqnKRE/26dU/vOtF4MfYk0aHXMhltwY/2d9gwuk9kg5GXjJvA83/G8eBhAZPqo5SyJ6/VMguZkqHbJFkQdjALKfKQjo23x0K97B++NNiVU2AUouOUvFsWQ0tRWhOQIxNPFHYrMf/o+Ar4rFlX207SxNCIOqfAKe56ByqrZ+bg9inPK5rNcRob+UiMAo6yNvEK8dLRpUFZrjdd/+5qv1pB6ZOOeteQLwyENpw/k0z7H6rnolOx+wopHN7m2PzcRkULLd0fV0LnJ+IKaUY8yNvMYJQ7dAeq37YS/KVH/PFSO7yBHUDe5nhNJsx/GAIGsir11dvBIrsyn8sBIjhzwM5+m5BorEhUoRxjK6XVvRO6WxseXozXj+Lf6eXsA2tg2kblcNPiapTImmUQIsWCyzEv5YLA2Jofdwfq0gFeKOQS X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 07:14:44.5854 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a492bd5f-6445-4832-75e9-08dc10e2a806 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF0000343A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8789 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: vbjeoeSjKfJILAFOKVqH74bsx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704784489667100003 Content-Type: text/plain; charset="utf-8" Introduce DumpBuffer function to print the buffer content. This helps developer to debug Redfish issue. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- RedfishPkg/Include/Library/RedfishDebugLib.h | 20 ++++++++- .../Library/RedfishDebugLib/RedfishDebugLib.c | 41 ++++++++++++++++++- 2 files changed, 59 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/Include/Library/RedfishDebugLib.h b/RedfishPkg/Incl= ude/Library/RedfishDebugLib.h index 5f75bad12a..3430cf1d14 100644 --- a/RedfishPkg/Include/Library/RedfishDebugLib.h +++ b/RedfishPkg/Include/Library/RedfishDebugLib.h @@ -1,7 +1,7 @@ /** @file This file defines the Redfish debug library interface. =20 - Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All rights res= erved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -138,4 +138,22 @@ DumpIpv4Address ( IN EFI_IPv4_ADDRESS *Ipv4Address ); =20 +/** + Debug output raw data buffer. + + @param[in] ErrorLevel DEBUG macro error level + @param[in] Buffer Debug output data buffer. + @param[in] BufferSize The size of Buffer in byte. + + @retval EFI_SUCCESS Debug dump finished. + @retval EFI_INVALID_PARAMETER Buffer is NULL. + +**/ +EFI_STATUS +DumpBuffer ( + IN UINTN ErrorLevel, + IN UINT8 *Buffer, + IN UINTN BufferSize + ); + #endif diff --git a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c b/Redfish= Pkg/Library/RedfishDebugLib/RedfishDebugLib.c index efa9a5ca13..5fd40ad955 100644 --- a/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c +++ b/RedfishPkg/Library/RedfishDebugLib/RedfishDebugLib.c @@ -1,7 +1,7 @@ /** @file Redfish debug library to debug Redfish application. =20 - Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. + Copyright (c) 2023-2024, NVIDIA CORPORATION & AFFILIATES. All rights res= erved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -21,6 +21,7 @@ =20 #define REDFISH_JSON_STRING_LENGTH 200 #define REDFISH_JSON_OUTPUT_FORMAT (EDKII_JSON_COMPACT | EDKII_JSON_INDEN= T(2)) +#define REDFISH_SIZE_PER_ROW 16 =20 /** Debug print the value of StatementValue. @@ -366,3 +367,41 @@ DumpIpv4Address ( =20 return EFI_SUCCESS; } + +/** + Debug output raw data buffer. + + @param[in] ErrorLevel DEBUG macro error level + @param[in] Buffer Debug output data buffer. + @param[in] BufferSize The size of Buffer in byte. + + @retval EFI_SUCCESS Debug dump finished. + @retval EFI_INVALID_PARAMETER Buffer is NULL. + +**/ +EFI_STATUS +DumpBuffer ( + IN UINTN ErrorLevel, + IN UINT8 *Buffer, + IN UINTN BufferSize + ) +{ + UINTN Index; + + if (Buffer =3D=3D NULL) { + return EFI_INVALID_PARAMETER; + } + + DEBUG ((ErrorLevel, "Address: 0x%p size: %d\n", Buffer, BufferSize)); + for (Index =3D 0; Index < BufferSize; Index++) { + if (Index % REDFISH_SIZE_PER_ROW =3D=3D 0) { + DEBUG ((ErrorLevel, "\n%04X: ", Index)); + } + + DEBUG ((ErrorLevel, "%02X ", Buffer[Index])); + } + + DEBUG ((ErrorLevel, "\n")); + + return EFI_SUCCESS; +} --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113424): https://edk2.groups.io/g/devel/message/113424 Mute This Topic: https://groups.io/mt/103616099/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-