From nobody Wed May 15 18:42:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113350+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113350+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1704686208; cv=none; d=zohomail.com; s=zohoarc; b=ErPcVzmw6/0kVmZRtmGGAhhh49Ve2fSK5I/v16yddygQ3sdxBnuzdmeFLO0LUNhlddMSbMtsg0+FH5CVuejvbjH+Ziusa2UYjIrT+23A8ERlokQvMAe8vjb1c/zTvqYVM08FLw0yHjbPQWkjj6NoZyBwe3zM5Ffg2sTHzugqisY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704686208; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=FO3/q+vRk4ohH3ffSGZ770kToWqyc1zpyDRIt8DJ+Qo=; b=i5+tDluiX7kpgjsXVzjHNGz2Pr10PkMwRTXrVX8yQeetifxXB0XizthGMq9Pi1a9zM9PcwZcv6rNvd60JZdsFxAbPF1qUyVCFEjW7Uw19rhnWnQIJxP3qkrHBQDkbVQGxstmn+8xFSE61vziOc8MhvNDdwiJ9kROTBXyZEbtJnY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113350+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704686208671539.7000821323118; Sun, 7 Jan 2024 19:56:48 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=AUxTVlOsGZyvVn7hVOyfzjW5UV2+SEsdgY93W8zujaI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704686208; v=1; b=VM/1vdr4DOpWBi/XMLic2tOCQ7lkaPVCg74NvQ3u4eZJZSMCeylO5Gm7IheoOkWcy0veq65G WJq+EjZ6juj8ER9cCrG2/kXQXUUob+y/d+W0/DRt8jHcP18o7Gz+tJuSRhubZvSM3aydiZ86Vqj r1WJPxhzniGinNB7ZI0VnQrQ= X-Received: by 127.0.0.2 with SMTP id mutWYY1788612xd1XcYUuGtw; Sun, 07 Jan 2024 19:56:48 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.32503.1704686204521068180 for ; Sun, 07 Jan 2024 19:56:47 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="464189084" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="464189084" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 19:56:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="29653016" X-Received: from shwdeopenlab702.ccr.corp.intel.com ([10.239.55.43]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 19:56:46 -0800 From: "duntan" To: devel@edk2.groups.io Cc: Ray Ni , Laszlo Ersek , Rahul Kumar , Gerd Hoffmann , Min Xu Subject: [edk2-devel] [Patch V2 1/2] UefiCpuPkg: set EXTENDED_PROCESSOR_INFORMATION to 0 Date: Mon, 8 Jan 2024 11:55:51 +0800 Message-Id: <20240108035552.1102-2-dun.tan@intel.com> In-Reply-To: <20240108035552.1102-1-dun.tan@intel.com> References: <20240108035552.1102-1-dun.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: OhmscrjtnjNr3ROGRahJuQMbx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704686209308100006 Content-Type: text/plain; charset="utf-8" Set EXTENDED_PROCESSOR_INFORMATION to 0 in API MpInitLibGetProcessorInfo() of MpInitLibUp. This commit use ZeroMem() to set all fileds in output EFI_PROCESSOR_INFORMATION to 0 before StatusFlag field is reassigned. Previously EXTENDED_PROCESSOR_INFORMATION in the API MpInitLibGetProcessorInfo() of MpInitLibUp is ignored. In PEI/DXE MpInitLib, EXTENDED_PROCESSOR_INFORMATION will be retrived when BIT24 of input ProcessorNumber is set. This commit can avoid garbage in the output structure in MpInitLibGetProcessorInfo() of MpInitLibUp. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Min Xu Reviewed-by: Laszlo Ersek --- UefiCpuPkg/Include/Library/MpInitLib.h | 2 ++ UefiCpuPkg/Library/MpInitLib/MpLib.c | 2 ++ UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 14 +++++++------- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/UefiCpuPkg/Include/Library/MpInitLib.h b/UefiCpuPkg/Include/Li= brary/MpInitLib.h index 1853c46415..842c6f7ff9 100644 --- a/UefiCpuPkg/Include/Library/MpInitLib.h +++ b/UefiCpuPkg/Include/Library/MpInitLib.h @@ -63,6 +63,8 @@ MpInitLibGetNumberOfProcessors ( instant this call is made. This service may only be called from the BSP. =20 @param[in] ProcessorNumber The handle number of processor. + Lower 24 bits contains the actual proc= essor number. + BIT24 indicates if the EXTENDED_PROCES= SOR_INFORMATION will be retrived. @param[out] ProcessorInfoBuffer A pointer to the buffer where informat= ion for the requested processor is deposited. @param[out] HealthData Return processor health data. diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpIn= itLib/MpLib.c index a359906923..cdfb570e61 100644 --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c @@ -2333,6 +2333,8 @@ MpInitLibInitialize ( instant this call is made. This service may only be called from the BSP. =20 @param[in] ProcessorNumber The handle number of processor. + Lower 24 bits contains the actual proc= essor number. + BIT24 indicates if the EXTENDED_PROCES= SOR_INFORMATION will be retrived. @param[out] ProcessorInfoBuffer A pointer to the buffer where informat= ion for the requested processor is deposited. @param[out] HealthData Return processor health data. diff --git a/UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c b/UefiCpuPkg/Libr= ary/MpInitLibUp/MpInitLibUp.c index 86f9fbf903..ea9a45c9c6 100644 --- a/UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c +++ b/UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c @@ -77,6 +77,8 @@ MpInitLibGetNumberOfProcessors ( instant this call is made. This service may only be called from the BSP. =20 @param[in] ProcessorNumber The handle number of processor. + Lower 24 bits contains the actual proc= essor number. + BIT24 indicates if the EXTENDED_PROCES= SOR_INFORMATION will be retrived. @param[out] ProcessorInfoBuffer A pointer to the buffer where informat= ion for the requested processor is deposited. @param[out] HealthData Return processor health data. @@ -108,13 +110,11 @@ MpInitLibGetProcessorInfo ( return EFI_NOT_FOUND; } =20 - ProcessorInfoBuffer->ProcessorId =3D 0; - ProcessorInfoBuffer->StatusFlag =3D PROCESSOR_AS_BSP_BIT | - PROCESSOR_ENABLED_BIT | - PROCESSOR_HEALTH_STATUS_BIT; - ProcessorInfoBuffer->Location.Package =3D 0; - ProcessorInfoBuffer->Location.Core =3D 0; - ProcessorInfoBuffer->Location.Thread =3D 0; + ZeroMem (ProcessorInfoBuffer, sizeof (*ProcessorInfoBuffer)); + ProcessorInfoBuffer->StatusFlag =3D PROCESSOR_AS_BSP_BIT | + PROCESSOR_ENABLED_BIT | + PROCESSOR_HEALTH_STATUS_BIT; + if (HealthData !=3D NULL) { GuidHob =3D GetFirstGuidHob (&gEfiSecPlatformInformationPpiGuid); if (GuidHob !=3D NULL) { --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113350): https://edk2.groups.io/g/devel/message/113350 Mute This Topic: https://groups.io/mt/103591527/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 18:42:11 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113351+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113351+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1704686211; cv=none; d=zohomail.com; s=zohoarc; b=Nmzwt9Z7C2JsTMWiWp8pH9HGm3Ambr7Kef+Jbd88oWT+g0QJg+2FUZmULx4qN3RTLF3cWk+Lw6gxOaHsb0aLsCd/W2vJj8AlJQzuRpLvtdOO6MQJKYej2pYIalZAmqB9g4LgjGTpD2ftmAEMZKXxNLdPSld59pqNaEljxxRuIE4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704686211; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=Qk8tuXCQOrJusFTM6g35VasZTWoWjIqwcytp0tAx6tc=; b=LHlbnx+jLCOnCGNkaVL0G7grfa8C5RR2L4VybdKA10fPUGEuGAnSOF7XgbifvExVkqh4LZGUf9NbWNcDs72xwmVxGKKrP3qJnGlxvmbw4Gbzi0DrXDo5JgMPGlKaEW+rKtD2idyQyd/Q4yceginj16KsotK7cMEUzlaxNsdH9Qk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113351+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 170468621165924.941540969760467; Sun, 7 Jan 2024 19:56:51 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=PxKULcLjuBOOuGvKpmL1MoGOS1TUNywvfokkQA9ps60=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704686211; v=1; b=K263BhLOXAJYy62AxErlk3/ntErRo0MCPDPo81XMdnDO370CbiOm62uJreWgnix1QeHaz7Xg 3bZTJDhXsyBjIaEGlJX8TtM7ZmnfV/2wMZHPOAnKaFq6dLdoGJb9GyUNrBjRbDjcpF6X0o3JH3c oTYHow4aDAVg29vrZDalnjt8= X-Received: by 127.0.0.2 with SMTP id c38eYY1788612x9o0wywqir1; Sun, 07 Jan 2024 19:56:51 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web11.32503.1704686204521068180 for ; Sun, 07 Jan 2024 19:56:50 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10946"; a="464189092" X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="464189092" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 19:56:50 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.04,340,1695711600"; d="scan'208";a="29653022" X-Received: from shwdeopenlab702.ccr.corp.intel.com ([10.239.55.43]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Jan 2024 19:56:48 -0800 From: "duntan" To: devel@edk2.groups.io Cc: Ray Ni , Laszlo Ersek , Rahul Kumar , Gerd Hoffmann , Min Xu Subject: [edk2-devel] [Patch V2 2/2] UefiCpuPkg: Check lower 24 bits of ProcessorNumber Date: Mon, 8 Jan 2024 11:55:52 +0800 Message-Id: <20240108035552.1102-3-dun.tan@intel.com> In-Reply-To: <20240108035552.1102-1-dun.tan@intel.com> References: <20240108035552.1102-1-dun.tan@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,dun.tan@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: TB1aCbOH7bH4IkIfnTdVFMxnx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704686213399100003 Content-Type: text/plain; charset="utf-8" Check lower 24 bits of ProcessorNumber instead of the value of ProcessorNumber in the API MpInitLibGetProcessorInfo() of MpInitLibUp instance. Lower 24 bits of ProcessorNumber contains the actual processor number. The BIT24 of input ProcessorNumber might be set to indicate if the EXTENDED_PROCESSOR_INFORMATION will be retrived. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Min Xu Reviewed-by: Laszlo Ersek --- UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c b/UefiCpuPkg/Libr= ary/MpInitLibUp/MpInitLibUp.c index ea9a45c9c6..30bdd8cfdd 100644 --- a/UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c +++ b/UefiCpuPkg/Library/MpInitLibUp/MpInitLibUp.c @@ -106,7 +106,10 @@ MpInitLibGetProcessorInfo ( return EFI_INVALID_PARAMETER; } =20 - if (ProcessorNumber !=3D 0) { + // + // Lower 24 bits contains the actual processor number. + // + if ((ProcessorNumber & (BIT24 - 1)) !=3D 0) { return EFI_NOT_FOUND; } =20 --=20 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113351): https://edk2.groups.io/g/devel/message/113351 Mute This Topic: https://groups.io/mt/103591528/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-