From nobody Wed May 15 21:10:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113290+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113290+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1704469113; cv=none; d=zohomail.com; s=zohoarc; b=Q5CPENZ4zYvxX6HLlH2AmG1ofBiT4C3mjt1j/fnqFOEIg3QaQS5Tu9PXD0ayod6qYEAK5CfZqpvpl1EtWbCwULmDcIbrDxAWdDBKXOiWJJC77imnbbgYh2vxaAMcAk1IwK4HrhZlAOjukX6DU6/0EVcBYTlbAnH03t1AERJaFb4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704469113; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=pbds9aKwFBP9isnEzNeP6w3Od0Smre+A0iQGXD8uOmM=; b=O/12xlUAp9Z0Q4l5HlUbFm0cNqeQZZnGm6wgV94Ol0U28713BeeOGUN3E+DAGAbl1v5GSQluUR1ZHIyvp4kn6OTCgQY9ENfb/Cj7O+7IXsujaIV8Lqk+R3xifzKJmpzxlhkLj03ZLy357vZ5bYyM48KVl8bwbGxOLqOzZEQy2s4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113290+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704469113497259.61063032050674; Fri, 5 Jan 2024 07:38:33 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=sxShUhVh562fJGAGhku5BrvRluvhdpFO07IXX5/2LFM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704469113; v=1; b=ls0/NVOd0bRUsDyeZRYNE5jUjWDPRxHlTNdV5LeLerCP2uhzVNlE9vSyaVPrCtTnUOcSkr9Y sTfKZuE7/pBsDrbS2jcTAcSA/EXXIryS+Trhib6lcl90/+dXarVQJxNluqsln3s6jBAtFgm5/qj yPLDwmz1+98AGS5qA5m+j6x0= X-Received: by 127.0.0.2 with SMTP id AxjXYY1788612xHEemlFssYX; Fri, 05 Jan 2024 07:38:33 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.26226.1704469112493947480 for ; Fri, 05 Jan 2024 07:38:32 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 95B81FEC; Fri, 5 Jan 2024 07:39:18 -0800 (PST) X-Received: from usa.arm.com (a079755.arm.com [10.162.46.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 786EF3F7A6; Fri, 5 Jan 2024 07:38:30 -0800 (PST) From: "Prabin CA" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Prabin CA Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/7] Platform/Sgi: remove +nofp gcc option flag Date: Fri, 5 Jan 2024 21:08:08 +0530 Message-Id: <20240105153814.427009-2-prabin.ca@arm.com> In-Reply-To: <20240105153814.427009-1-prabin.ca@arm.com> References: <20240105153814.427009-1-prabin.ca@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prabin.ca@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5lZnT4F23yWuIU5vamwuLVobx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704469115508100007 Content-Type: text/plain; charset="utf-8" From: Omkar Anand Kulkarni The software executing at a higher privileged level on the reference design platforms have been updated to allow software executing at EL1 and EL0 to access the Advanced SIMD and floating-point registers (FPEN field of CPACR_EL1 system register is programmed to allow access). So, remove the use of +nofp gcc build option flag. Signed-off-by: Omkar Anand Kulkarni Signed-off-by: Prabin CA Reviewed-by: levi.yun --- Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPk= g/SgiPlatformMm.dsc.inc index ae0ff7247a6a..ab54b3b25f4c 100644 --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc @@ -145,5 +145,5 @@ [Components.AARCH64] # ##########################################################################= ######################### [BuildOptions.AARCH64] - GCC:*_*_*_CC_FLAGS =3D -mstrict-align -march=3Darmv8-a+nofp -D DISABLE_N= EW_DEPRECATED_INTERFACES + GCC:*_*_*_CC_FLAGS =3D -mstrict-align -march=3Darmv8-a -D DISABLE_NEW_DE= PRECATED_INTERFACES GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113290): https://edk2.groups.io/g/devel/message/113290 Mute This Topic: https://groups.io/mt/103544563/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 21:10:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113291+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113291+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1704469115; cv=none; d=zohomail.com; s=zohoarc; b=MnPvrk9TejJ/FwP+IFhDOYFmd59rB6uQWJIyZmiWVHivZ1FTcHLw3JnsjHOFAvcW40Slrn/65VatCmngBZugg93IOO3lusZIpkOkx2eutzh6/AkoDYn4Y03nhbObMLEEMyR3ejLjQRz3Mj7zeZamaJhZpkBaCVD1b0rc1fUQ7WA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704469115; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=ynGk1l8wBpJWxXJ/CqBaSfahE+FrUbIZDEHrYCYT4nI=; b=MHNokb12JOkzftDzNFl1nWRUH3BGscby+LzR5arSKfqvTbNVA1h9haNKKKz77KfWsYcdAv6mrlL+ogkt6dQ8kDO9oifVnbbBrhaIskDNPLRA5OzuJpXxLj9+wiGFoKt4bZJ9mltUL5BusB2gP2bXopcFWwMBJA3cDBS46CVxxrk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113291+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704469115839642.2922158101925; Fri, 5 Jan 2024 07:38:35 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=pDBcocDtkj8o1IT8YYrwkUr3g1iNUXeWLwycrFlCpG4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704469115; v=1; b=cudzJ43pX0BrK8D4S3OhcaFbrNNBYMyntqKMLWb8XLl58d64AfdCIsEol1eB11F26I1Yg/m/ Hmzx/Gjzvb4Tg61k8/T0rVuVNmstm+MjeNEUKoEvxLz6o/EGBJxBJ0osbkk4Cluk9ZrVCa/SHqG KYqmEjvARoaVqbZYVdd4XKJ8= X-Received: by 127.0.0.2 with SMTP id elADYY1788612xMlKXC1Tgmh; Fri, 05 Jan 2024 07:38:35 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.26228.1704469114792984826 for ; Fri, 05 Jan 2024 07:38:34 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CE2BAC15; Fri, 5 Jan 2024 07:39:20 -0800 (PST) X-Received: from usa.arm.com (a079755.arm.com [10.162.46.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B08743F7A6; Fri, 5 Jan 2024 07:38:32 -0800 (PST) From: "Prabin CA" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Prabin CA Subject: [edk2-devel] [edk2-platforms][PATCH v2 2/7] Platform/Sgi: add no-stack-protector flag for StMM builds Date: Fri, 5 Jan 2024 21:08:09 +0530 Message-Id: <20240105153814.427009-3-prabin.ca@arm.com> In-Reply-To: <20240105153814.427009-1-prabin.ca@arm.com> References: <20240105153814.427009-1-prabin.ca@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prabin.ca@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: UzuORUudH7X7EFoeBiMzLmxNx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704469117521100011 Content-Type: text/plain; charset="utf-8" Add the no-stack-protector compiler flag to allow StandaloneMM builds on both AArch64 and x86 host. Without this flag, the link stage fails with the following errors on multiple files when built with gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0: undefined reference to `__stack_chk_guard' undefined reference to `__stack_chk_fail' Signed-off-by: Vijayenthiran Subramaniam Signed-off-by: Prabin CA --- Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPk= g/SgiPlatformMm.dsc.inc index ab54b3b25f4c..2a8c678c0816 100644 --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc @@ -145,5 +145,5 @@ [Components.AARCH64] # ##########################################################################= ######################### [BuildOptions.AARCH64] - GCC:*_*_*_CC_FLAGS =3D -mstrict-align -march=3Darmv8-a -D DISABLE_NEW_DE= PRECATED_INTERFACES + GCC:*_*_*_CC_FLAGS =3D -mstrict-align -march=3Darmv8-a -fno-stack-protec= tor -D DISABLE_NEW_DEPRECATED_INTERFACES GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113291): https://edk2.groups.io/g/devel/message/113291 Mute This Topic: https://groups.io/mt/103544564/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 21:10:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113292+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113292+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1704469117; cv=none; d=zohomail.com; s=zohoarc; b=jgKoCeX3rX8KeVWE1GzjQG05D6OEjU2IgaLtUNUDO8E+1SHHfxZqMsOvG7fyh/rNiNfKSJcSfa85igLSYfIzRKidnZEz5NHKL+5aCpEv6Co2aNJyV9X32dmWnRgANOv9KLHPa1GfQUCO7MqroNKI+Fv9ZQTrwljkv5GFBQ9slIc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704469117; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=8NQa/ZRCzvn/8EzOB8jRNczm8kvTTodzvpq8MVf4WZo=; b=LeBR2BVR5WyQd0WRfbFUPSwlifApZYto1Hmvj7nJQgbjP6eBOUkYXm/Zvft9BSidwZe+iUk4bZMaayXNqXhhki5ovAhyKJ+p6ijcHqkm64dpgBICxc7G0rLEoMVtthuUvbt5i9eoLbTZlQlsittOBFSUz1HhPDlESwqYNAS5YGo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113292+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704469117847127.2485989007539; Fri, 5 Jan 2024 07:38:37 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=SzTC9s4sZhcBi3Xfg29EqwCUmTGotklngVbPbtQtAAM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704469117; v=1; b=QLnSY2B/9bo/2NVy0+5QFGRPLLAgMclnYrYdwZn76vzb6Rh2Gwlh7J5lxlt8rZIIAZ6zHoMj tlAYbEWA+/RgapK9EsMlUkjTLbzF4S7FpTPZFv2kPboW4jcUdvrqrnoVx9d/HhasxTtlxjyiO2w /6ikJi6zOMA1kVmro2mAltfA= X-Received: by 127.0.0.2 with SMTP id sKNcYY1788612x8JEtp0FiX8; Fri, 05 Jan 2024 07:38:37 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.26234.1704469116946411926 for ; Fri, 05 Jan 2024 07:38:37 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 097F9C15; Fri, 5 Jan 2024 07:39:23 -0800 (PST) X-Received: from usa.arm.com (a079755.arm.com [10.162.46.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E92E43F7A6; Fri, 5 Jan 2024 07:38:34 -0800 (PST) From: "Prabin CA" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Prabin CA Subject: [edk2-devel] [edk2-platforms][PATCH v2 3/7] Platform/Sgi: Add VariableFlashInfoLib to fix missing dependency Date: Fri, 5 Jan 2024 21:08:10 +0530 Message-Id: <20240105153814.427009-4-prabin.ca@arm.com> In-Reply-To: <20240105153814.427009-1-prabin.ca@arm.com> References: <20240105153814.427009-1-prabin.ca@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prabin.ca@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: D7OaP8XBJaNz3OtVdozlFkAzx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704469119547100015 Content-Type: text/plain; charset="utf-8" From: Vijayenthiran Subramaniam REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3479 A recent change in MdeModulePkg [1] introduced VariableFlashInfoLib as a dependency to support dynamic variable flash information. Add an instance for the library class VariableFlashInfoLib in SgiPlatformMm.dsc.inc to resolve this dependency. [1]: https://github.com/tianocore/edk2/commit/8db39c60cdf35e0a53ccdbccf7e15= 2ab41f54f4c Signed-off-by: Vijayenthiran Subramaniam Signed-off-by: Prabin CA Reviewed-by: levi.yun --- Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc b/Platform/ARM/SgiPk= g/SgiPlatformMm.dsc.inc index 2a8c678c0816..5cc33e9f4af8 100644 --- a/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc +++ b/Platform/ARM/SgiPkg/SgiPlatformMm.dsc.inc @@ -70,6 +70,7 @@ [LibraryClasses.common.MM_STANDALONE] SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchroniza= tionLib.inf TimerLib|MdePkg/Library/BaseTimerLibNullTemplate/BaseTimerLibNullTemplat= e.inf VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseV= ariableFlashInfoLib.inf SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf !endif =20 --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113292): https://edk2.groups.io/g/devel/message/113292 Mute This Topic: https://groups.io/mt/103544570/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 21:10:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113293+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113293+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1704469120; cv=none; d=zohomail.com; s=zohoarc; b=Osf3oDq4v6N26DTSkvUe5LGRa57+B0o3vSP4tNcbJDCSuSD1p7SO9+XbzOLEtpJgeB0gLx6yaC0a0bV5/mmutxTfuIzRqHulfSqRzUgNjYR1yAx966u1ji70aOPjki2wuReQxD1qRqYFiKBqW1W/UFSReZQsElpZZv29w28yyWI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704469120; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=c6nXjY3wle62EgXw4B6g0T35A0jUOpXo4+Ahh3ALEqA=; b=LOfBocwXcMQp37xD0T1EbD433q3sJrZPN7ePkTUZE6iMzILjR3fBeJ859lg7R+NzLlNnRQEVbN5MF7/6xMQBhVibk665vkn78DJ8TON3w58rApn61+SUH6pkraweSr23lskbe32itcTJE7kYc3aS1vpVhPTiOnallvyfqN0dUUc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113293+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704469120052340.4820611001122; Fri, 5 Jan 2024 07:38:40 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=siIbbJ+AZY9aMMhyVE4WhsbonUpC5QdeNVyxJc+VYyk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704469119; v=1; b=Y2cnX/p5V+K8XNu7PmZ0voAClTgFGx7zTed5Gf+Svv9FC+3cVs8I/66doHkyEG71dCiqfsG2 MwNWT6YLEVjwwmn90mL+ygvHmalGJ4SJR86pa1U4G1h5EJ/PSRrD6gM5ZLNW3NhpBW4brkscUT/ YMFtwsYnvFSSXCc/dcswMyoQ= X-Received: by 127.0.0.2 with SMTP id 41YBYY1788612xK9WTf4TpPU; Fri, 05 Jan 2024 07:38:39 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.26237.1704469119147507034 for ; Fri, 05 Jan 2024 07:38:39 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 42D9EC15; Fri, 5 Jan 2024 07:39:25 -0800 (PST) X-Received: from usa.arm.com (a079755.arm.com [10.162.46.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 249E63F7A6; Fri, 5 Jan 2024 07:38:36 -0800 (PST) From: "Prabin CA" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Prabin CA Subject: [edk2-devel] [edk2-platforms][PATCH v2 4/7] Platform/Sgi: Add a PCD to specify platform variant Date: Fri, 5 Jan 2024 21:08:11 +0530 Message-Id: <20240105153814.427009-5-prabin.ca@arm.com> In-Reply-To: <20240105153814.427009-1-prabin.ca@arm.com> References: <20240105153814.427009-1-prabin.ca@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prabin.ca@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LkCV8RIU1BKCizxCI1JZULcex1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704469121537100019 Content-Type: text/plain; charset="utf-8" A new PCD named PcdPlatformVariant is introduced to specify the variant number of a platform. This PCD can be used to select platform variant specific configurations. The default value of this PCD is 0 which selects the base variant. Signed-off-by: Prabin CA Reviewed-by: levi.yun --- Platform/ARM/SgiPkg/SgiPlatform.dec | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Platform/ARM/SgiPkg/SgiPlatform.dec b/Platform/ARM/SgiPkg/SgiP= latform.dec index 1613cc01981e..103dff8471a7 100644 --- a/Platform/ARM/SgiPkg/SgiPlatform.dec +++ b/Platform/ARM/SgiPkg/SgiPlatform.dec @@ -1,5 +1,5 @@ # -# Copyright (c) 2018 - 2023, Arm Limited. All rights reserved. +# Copyright (c) 2018 - 2024, Arm Limited. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -51,8 +51,9 @@ [PcdsFixedAtBuild] gArmSgiTokenSpaceGuid.PcdVirtioP9Size|0x00000000|UINT32|0x00000029 gArmSgiTokenSpaceGuid.PcdVirtioP9Interrupt|0x00000000|UINT32|0x0000002A =20 - # Chip count on the platform + # Chip count on the platform and platform variant gArmSgiTokenSpaceGuid.PcdChipCount|1|UINT32|0x0000000B + gArmSgiTokenSpaceGuid.PcdPlatformVariant|0|UINT32|0x0000002D =20 # GIC gArmSgiTokenSpaceGuid.PcdGicSize|0|UINT64|0x0000000A --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113293): https://edk2.groups.io/g/devel/message/113293 Mute This Topic: https://groups.io/mt/103544572/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 21:10:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113294+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113294+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1704469122; cv=none; d=zohomail.com; s=zohoarc; b=UnFj+jrQnY+ldxMBh2uy5zrTay5LXePe0YIctpektD+5pOejaC6ZpApgwtAKa/3ju3dHBWcJTKiFPlWe9cJwqKjQ00ASzGt3rw1l90FnkiWIIc9WyaaWkPBEWWkuzhwi4hWCaBoU6+YvVBOLI23SMf81PSe5GiUcl+xsRSJarZM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704469122; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=hU3y3fYI7q24CiqbpOo9vkPuCRmKkABNpUsEnyKrSLo=; b=Er/EH/Pw/IpwbATc/vOol8ZUVQOS7/UV2CNOivKXjBVqMlkC5wH0WvTHk9ZGCZTfHzUvGEwTdtdQhMs/LO6J7/hQWwtV9U474IUUVeCAAN4qRH9MX7vwV5t+yPfAquSrh8RyyQ12jUnf5Rc3fOdOoH2Ls5RaIyO3YCqVg8NiLWk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113294+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704469122745741.5068665764412; Fri, 5 Jan 2024 07:38:42 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=+LC+/XSwbDcwGxSxoM1VDt+PJcXYuRx9VR4EGawA67k=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704469122; v=1; b=itjhM64QaZ6dtT1iZ8VCoC+jWamxgFI+TKzCDrWG4aSo/7GAHgx3Z0QPvN1cESPCCSXk0A2m 8hHgxadoGXkpg4iXM5A0l/myuKLIFCVI1n8ER2DP9ItNw4dSHDWIy9Y/L0hSQyvXEeRkDNphILA thedhn067Ww0Z+lkCluDE344= X-Received: by 127.0.0.2 with SMTP id FSnhYY1788612xBDPu0UNH2q; Fri, 05 Jan 2024 07:38:42 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.26235.1704469121821954745 for ; Fri, 05 Jan 2024 07:38:41 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1708C15; Fri, 5 Jan 2024 07:39:27 -0800 (PST) X-Received: from usa.arm.com (a079755.arm.com [10.162.46.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5E6263F7A6; Fri, 5 Jan 2024 07:38:39 -0800 (PST) From: "Prabin CA" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Prabin CA Subject: [edk2-devel] [edk2-platforms][PATCH v2 5/7] Platform/Sgi: Add support for RD-N2-Cfg3 platform Date: Fri, 5 Jan 2024 21:08:12 +0530 Message-Id: <20240105153814.427009-6-prabin.ca@arm.com> In-Reply-To: <20240105153814.427009-1-prabin.ca@arm.com> References: <20240105153814.427009-1-prabin.ca@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prabin.ca@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: gDb6ERwRiqDvZTVlpLgGoFNSx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704469123625100023 Content-Type: text/plain; charset="utf-8" The Neoverse RD-N2-Cfg3 platform is a variant of RD-N2 platform with a different mesh size and GIC ITS count. As part of the initial platform support, add the corresponding platform and flash description files. Use PcdPlatformVariant for the RD-N2-Cfg3 platform to specify the platform variant. RD-N2-Cfg3 has 12 GIC ITS blocks when compared to the other RD-N2 variants that have 6 GIC ITS blocks. Signed-off-by: Vijayenthiran Subramaniam Signed-off-by: Prabin CA Reviewed-by: levi.yun --- Platform/ARM/SgiPkg/RdN2Cfg3/RdN2Cfg3.dsc = | 58 ++++++++++++++++++++ Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf = | 3 +- Platform/ARM/SgiPkg/AcpiTables/{RdN2AcpiTables.inf =3D> RdN2Cfg3AcpiTables= .inf} | 15 ++--- Platform/ARM/SgiPkg/AcpiTables/RdN2/Madt.aslc = | 14 ++++- Platform/ARM/SgiPkg/RdN2Cfg3/RdN2Cfg3.fdf.inc = | 10 ++++ 5 files changed, 88 insertions(+), 12 deletions(-) diff --git a/Platform/ARM/SgiPkg/RdN2Cfg3/RdN2Cfg3.dsc b/Platform/ARM/SgiPk= g/RdN2Cfg3/RdN2Cfg3.dsc new file mode 100644 index 000000000000..88293b236a32 --- /dev/null +++ b/Platform/ARM/SgiPkg/RdN2Cfg3/RdN2Cfg3.dsc @@ -0,0 +1,58 @@ +# +# Copyright (c) 2024, ARM Limited. All rights reserved. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# + +##########################################################################= ###### +# +# Defines Section - statements that will be processed to create a Makefile. +# +##########################################################################= ###### +[Defines] + PLATFORM_NAME =3D RdN2Cfg3 + PLATFORM_GUID =3D b890ba7d-a256-4820-9d3a-655acbb737c9 + PLATFORM_VERSION =3D 0.1 + DSC_SPECIFICATION =3D 0x0001001B + OUTPUT_DIRECTORY =3D Build/$(PLATFORM_NAME) + SUPPORTED_ARCHITECTURES =3D AARCH64 + BUILD_TARGETS =3D NOOPT|DEBUG|RELEASE + SKUID_IDENTIFIER =3D DEFAULT + FLASH_DEFINITION =3D Platform/ARM/SgiPkg/SgiPlatform.fdf + BOARD_DXE_FV_COMPONENTS =3D Platform/ARM/SgiPkg/RdN2Cfg3/RdN2Cfg3= .fdf.inc + BUILD_NUMBER =3D 1 + +# include common definitions from SgiPlatform.dsc +!include Platform/ARM/SgiPkg/SgiPlatform.dsc.inc +!include Platform/ARM/SgiPkg/SgiMemoryMap2.dsc.inc + +# include common/basic libraries from MdePkg. +!include MdePkg/MdeLibs.dsc.inc + +##########################################################################= ###### +# +# Pcd Section - list of all EDK II PCD Entries defined by this Platform +# +##########################################################################= ###### + +[PcdsFixedAtBuild.common] + # GIC configurations + gArmTokenSpaceGuid.PcdGicDistributorBase|0x30000000 + gArmTokenSpaceGuid.PcdGicRedistributorsBase|0x30300000 + gArmSgiTokenSpaceGuid.PcdGicSize|0x400000 + + # ARM Cores and Clusters + gArmPlatformTokenSpaceGuid.PcdCoreCount|1 + gArmPlatformTokenSpaceGuid.PcdClusterCount|16 + + # RdN2Cfg3 is the third variant from RdN2 Platform + gArmSgiTokenSpaceGuid.PcdPlatformVariant|3 + +##########################################################################= ###### +# +# Components Section - list of all EDK II Modules needed by this Platform +# +##########################################################################= ###### + +[Components.common] + Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg3AcpiTables.inf diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf b/Platform/A= RM/SgiPkg/AcpiTables/RdN2AcpiTables.inf index 8025ef58171b..afc38385c051 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf @@ -1,7 +1,7 @@ ## @file # ACPI table data and ASL sources required to boot the platform. # -# Copyright (c) 2020 - 2023, Arm Ltd. All rights reserved. +# Copyright (c) 2020 - 2024, Arm Ltd. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -67,6 +67,7 @@ [FixedPcd] gArmSgiTokenSpaceGuid.PcdMaxAddressBitsPerChip gArmSgiTokenSpaceGuid.PcdOscLpiEnable gArmSgiTokenSpaceGuid.PcdOscCppcEnable + gArmSgiTokenSpaceGuid.PcdPlatformVariant gArmSgiTokenSpaceGuid.PcdSp804DualTimerBaseAddress gArmSgiTokenSpaceGuid.PcdSp804DualTimerSize gArmSgiTokenSpaceGuid.PcdSp804DualTimerInterrupt diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf b/Platform/A= RM/SgiPkg/AcpiTables/RdN2Cfg3AcpiTables.inf similarity index 90% copy from Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf copy to Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg3AcpiTables.inf index 8025ef58171b..a703d5a994f7 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2AcpiTables.inf +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg3AcpiTables.inf @@ -1,7 +1,7 @@ ## @file # ACPI table data and ASL sources required to boot the platform. # -# Copyright (c) 2020 - 2023, Arm Ltd. All rights reserved. +# Copyright (c) 2024, Arm Ltd. All rights reserved. # # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -9,7 +9,7 @@ =20 [Defines] INF_VERSION =3D 0x0001001A - BASE_NAME =3D RdN2AcpiTables + BASE_NAME =3D RdN2Cfg3AcpiTables FILE_GUID =3D c712719a-0aaf-438c-9cdd-35ab4d60207d = # gArmSgiAcpiTablesGuid MODULE_TYPE =3D USER_DEFINED VERSION_STRING =3D 1.0 @@ -18,16 +18,13 @@ [Sources] Dbg2.aslc Fadt.aslc Gtdt.aslc - Iort.aslc - Mcfg.aslc RdN2/Dsdt.asl RdN2/Madt.aslc RdN2/Pptt.aslc Spcr.aslc - Ssdt.asl + SsdtRos.asl SsdtEvents.asl SsdtIoVirtSocExp.asl - SsdtRos.asl SsdtRosVirtioP9.asl =20 [Packages] @@ -56,17 +53,17 @@ [FixedPcd] gArmTokenSpaceGuid.PcdPciBusMin gArmTokenSpaceGuid.PcdPciBusMax =20 - gArmSgiTokenSpaceGuid.PcdChipCount gArmSgiTokenSpaceGuid.PcdGpioController0BaseAddress gArmSgiTokenSpaceGuid.PcdGpioController0Size gArmSgiTokenSpaceGuid.PcdGpioController0Interrupt gArmSgiTokenSpaceGuid.PcdGtFrame0Gsiv gArmSgiTokenSpaceGuid.PcdGtFrame1Gsiv + gArmSgiTokenSpaceGuid.PcdOscLpiEnable + gArmSgiTokenSpaceGuid.PcdOscCppcEnable gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlk0Base gArmSgiTokenSpaceGuid.PcdIoVirtSocExpBlkUartEnable gArmSgiTokenSpaceGuid.PcdMaxAddressBitsPerChip - gArmSgiTokenSpaceGuid.PcdOscLpiEnable - gArmSgiTokenSpaceGuid.PcdOscCppcEnable + gArmSgiTokenSpaceGuid.PcdPlatformVariant gArmSgiTokenSpaceGuid.PcdSp804DualTimerBaseAddress gArmSgiTokenSpaceGuid.PcdSp804DualTimerSize gArmSgiTokenSpaceGuid.PcdSp804DualTimerInterrupt diff --git a/Platform/ARM/SgiPkg/AcpiTables/RdN2/Madt.aslc b/Platform/ARM/S= giPkg/AcpiTables/RdN2/Madt.aslc index cdf8b3f2e953..5fba3fa7d020 100644 --- a/Platform/ARM/SgiPkg/AcpiTables/RdN2/Madt.aslc +++ b/Platform/ARM/SgiPkg/AcpiTables/RdN2/Madt.aslc @@ -6,7 +6,7 @@ CPU interface, redistributor, distributor and ITS blocks on the Rd-N2 pl= atform is included in this table. =20 - Copyright (c) 2020 - 2022, Arm Limited. All rights reserved. + Copyright (c) 2020 - 2024, Arm Limited. All rights reserved. =20 SPDX-License-Identifier: BSD-2-Clause-Patent =20 @@ -23,6 +23,8 @@ #define CORE_CNT (FixedPcdGet32 (PcdClusterCount) * \ FixedPcdGet32 (PcdCoreCount)) =20 +#define ITS_CNT ((FixedPcdGet32(PcdPlatformVariant) =3D=3D 3) ? 12 : 6) + // Multiple APIC Description Table #pragma pack (1) =20 @@ -31,7 +33,7 @@ typedef struct { EFI_ACPI_6_4_GIC_STRUCTURE GicInterfaces[CORE= _CNT]; EFI_ACPI_6_4_GIC_DISTRIBUTOR_STRUCTURE GicDistributor; EFI_ACPI_6_4_GICR_STRUCTURE GicRedistributor; - EFI_ACPI_6_4_GIC_ITS_STRUCTURE GicIts[6]; + EFI_ACPI_6_4_GIC_ITS_STRUCTURE GicIts[ITS_CNT]; } EFI_ACPI_6_4_MULTIPLE_APIC_DESCRIPTION_TABLE; =20 #pragma pack () @@ -134,6 +136,14 @@ STATIC EFI_ACPI_6_4_MULTIPLE_APIC_DESCRIPTION_TABLE Ma= dt =3D { EFI_ACPI_6_4_GIC_ITS_INIT(3, 0x30100000), EFI_ACPI_6_4_GIC_ITS_INIT(4, 0x30140000), EFI_ACPI_6_4_GIC_ITS_INIT(5, 0x30180000), +#if (FixedPcdGet32 (PcdPlatformVariant) =3D=3D 3) + EFI_ACPI_6_4_GIC_ITS_INIT(6, 0x301C0000), + EFI_ACPI_6_4_GIC_ITS_INIT(7, 0x30200000), + EFI_ACPI_6_4_GIC_ITS_INIT(8, 0x30240000), + EFI_ACPI_6_4_GIC_ITS_INIT(9, 0x30280000), + EFI_ACPI_6_4_GIC_ITS_INIT(10, 0x302C0000), + EFI_ACPI_6_4_GIC_ITS_INIT(11, 0x30180000), +#endif }, }; =20 diff --git a/Platform/ARM/SgiPkg/RdN2Cfg3/RdN2Cfg3.fdf.inc b/Platform/ARM/S= giPkg/RdN2Cfg3/RdN2Cfg3.fdf.inc new file mode 100644 index 000000000000..77288ab1ad93 --- /dev/null +++ b/Platform/ARM/SgiPkg/RdN2Cfg3/RdN2Cfg3.fdf.inc @@ -0,0 +1,10 @@ +# +# Copyright (c) 2024, ARM Limited. All rights reserved. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent +# + +# Per-platform additional content of the DXE phase firmware volume + + # ACPI support + INF RuleOverride=3DACPITABLE Platform/ARM/SgiPkg/AcpiTables/RdN2Cfg3Acpi= Tables.inf --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113294): https://edk2.groups.io/g/devel/message/113294 Mute This Topic: https://groups.io/mt/103544573/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 21:10:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113295+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113295+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1704469124; cv=none; d=zohomail.com; s=zohoarc; b=m2Uf5gB4YnW5rvS9yihpKpaQoTGGONR6Aldf7uGIq12l8w5Zpkcq+6OBXQhN4n+qqotJrOrR2ah7FtUI8y867DmeBjDljZy7CRUEzngGOWmMRG06NdGEN/hhLt9xsZi7kpbxwQEPx8CE5O07hw1O23KVZSKOcpOhrULeaP1kqSA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704469124; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=hpxh3dtscO/u6dNAFgsu7PyVy83f3y3aWiD8S9D7bwk=; b=I9SAwC1Xv8UcwvTK5d9Jd1Ho91/a6skz2xHg4hOBzCILRwLa3Y7bP/JRCJ4bzWrugnGEtgtMUPzLDnfeokrBpdo3Ucyt8RwDwuZxCoaYhJpH9Ed4QoLbPiXkVeCW0Hl7ZLSl9kLZrEHCC5otZ2CGFaBu2mkzdacsFr3vi0ip0wA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113295+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704469124839432.73458160242853; Fri, 5 Jan 2024 07:38:44 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=7OkRELPO9p8cGWJPNfq47OWVyxcenW09q8IDKGc+b5U=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704469124; v=1; b=Hx2AJzhwFFxwCG4oQAdMCgNkeb/VtWqh8n0xqz1rmVKjSYzHYXtx0m5r1wGZlzUcuN699qne Qw4Tp5c7AxY0MC/1Gkb1vkqd51Lwe8BAWlsQ3jgWfhNuwj/FTZNFUnYi/8FTOVdsfz59/TM4hK2 cldpPPYA5Y02ZJQBDcz0zYyw= X-Received: by 127.0.0.2 with SMTP id QikxYY1788612xqMdAegsf9s; Fri, 05 Jan 2024 07:38:44 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.26238.1704469124031870148 for ; Fri, 05 Jan 2024 07:38:44 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1CDBFC15; Fri, 5 Jan 2024 07:39:30 -0800 (PST) X-Received: from usa.arm.com (a079755.arm.com [10.162.46.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0845F3F7A6; Fri, 5 Jan 2024 07:38:41 -0800 (PST) From: "Prabin CA" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Prabin CA Subject: [edk2-devel] [edk2-platforms][PATCH v2 6/7] Platform/Sgi: Define RD-V2 platform id values Date: Fri, 5 Jan 2024 21:08:13 +0530 Message-Id: <20240105153814.427009-7-prabin.ca@arm.com> In-Reply-To: <20240105153814.427009-1-prabin.ca@arm.com> References: <20240105153814.427009-1-prabin.ca@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prabin.ca@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: WpFLIKxWqn5jcZdm06uclOBPx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704469125568100027 Content-Type: text/plain; charset="utf-8" From: Pranav Madhu Add RD-V2 platform identification values including the part number and configuration number. This information will be used in populating the SMBIOS tables. Signed-off-by: Pranav Madhu Signed-off-by: Prabin CA Reviewed-by: levi.yun --- Platform/ARM/SgiPkg/Include/SgiPlatform.h | 7 ++++++- Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 8 +++++++- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/Platform/ARM/SgiPkg/Include/SgiPlatform.h b/Platform/ARM/SgiPk= g/Include/SgiPlatform.h index e83853664c4c..6fa39d407bc9 100644 --- a/Platform/ARM/SgiPkg/Include/SgiPlatform.h +++ b/Platform/ARM/SgiPkg/Include/SgiPlatform.h @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2018 - 2022, Arm Limited. All rights reserved. +* Copyright (c) 2018 - 2024, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -47,6 +47,10 @@ #define RD_N2_PART_NUM 0x7B7 #define RD_N2_CONF_ID 0x1 =20 +// RD-V2 Platform Identification values +#define RD_V2_PART_NUM 0x7F2 +#define RD_V2_CONF_ID 0x1 + #define SGI_CONFIG_MASK 0x0F #define SGI_CONFIG_SHIFT 0x1C #define SGI_PART_NUM_MASK 0xFFF @@ -85,6 +89,7 @@ typedef enum { RdN2, RdN2Cfg1, RdN2Cfg2, + RdV2, } ARM_RD_PRODUCT_ID; =20 // Arm ProductId look-up table diff --git a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c b/Platfo= rm/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c index fa006320025b..14b06796ae9c 100644 --- a/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c +++ b/Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c @@ -1,6 +1,6 @@ /** @file * -* Copyright (c) 2018 - 2022, Arm Limited. All rights reserved. +* Copyright (c) 2018 - 2024, Arm Limited. All rights reserved. * * SPDX-License-Identifier: BSD-2-Clause-Patent * @@ -79,6 +79,12 @@ STATIC CONST SGI_PRODUCT_ID_LOOKUP SgiProductIdLookup[] = =3D { RD_N2_CONF_ID, 1 }, + { + RdV2, + RD_V2_PART_NUM, + RD_V2_CONF_ID, + 0 + }, }; =20 EFI_BOOT_MODE --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113295): https://edk2.groups.io/g/devel/message/113295 Mute This Topic: https://groups.io/mt/103544574/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Wed May 15 21:10:35 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113296+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113296+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=arm.com ARC-Seal: i=1; a=rsa-sha256; t=1704469127; cv=none; d=zohomail.com; s=zohoarc; b=ZsMaBTyiPv/xVpt1YUgeMxlLQ4pCQ2hjZuqiXz4QXmelnn63mvm3aLDkVNDQSDfnP1vF+BJgmhm77Z8g6nl3LO7AN67Y1pOc+OQa4Rev0nkx1joQBLYRe6orJ8isqSz/4VI3y3FndL/5iSgtoSC+nGkkF7qHFXgopylcRCuUO5M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1704469127; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=h7/Q5mg+tYqEz2yKCTR+meVn1WHWJ3/FZBibxCQPi7A=; b=BoSq7kX1XrQb+JOk0G0EBW3e6Gor8HPeTXivdOo8Tv438Czr39uCWaImhQIzmqyQ9IfnCYLa76S1Wumi4cHkcYkIHckmDGfHm8ZVeHHuOEde+IvUuuRNR27YiilM4JQI/Q3TUzgDWO8+JjyzA5f/ryyrk/WwykHIqdWgMo49hFQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113296+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704469127173577.0282863921472; Fri, 5 Jan 2024 07:38:47 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=Pl38SI4WZFwYFqDtygyvgWqB+vjdC+ialgB2V+IixNg=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1704469126; v=1; b=jwWurGDZGg9RehqFn8SDqQt5o/Pg0MgdgT1JgetQG+B9XHQVpzzdN1eGu8+Lx6lgSTQJ2DOy U1WdfCy0xRHiadLEc8S8H259ZeJ6WAUA1MaAezuhxHn9wm+XoZ1pZoHqFqmzLSzV5qCQ/32dxj2 54nCILymxtp7efOibtUsEf8c= X-Received: by 127.0.0.2 with SMTP id YUfeYY1788612xifdwUG8meh; Fri, 05 Jan 2024 07:38:46 -0800 X-Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web11.26239.1704469126225652376 for ; Fri, 05 Jan 2024 07:38:46 -0800 X-Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4C5F8C15; Fri, 5 Jan 2024 07:39:32 -0800 (PST) X-Received: from usa.arm.com (a079755.arm.com [10.162.46.129]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 37EC03F7A6; Fri, 5 Jan 2024 07:38:43 -0800 (PST) From: "Prabin CA" To: devel@edk2.groups.io Cc: Ard Biesheuvel , Leif Lindholm , Sami Mujawar , Prabin CA Subject: [edk2-devel] [edk2-platforms][PATCH v2 7/7] Platform/Sgi: Extend SMBIOS support for RD-V2 platform Date: Fri, 5 Jan 2024 21:08:14 +0530 Message-Id: <20240105153814.427009-8-prabin.ca@arm.com> In-Reply-To: <20240105153814.427009-1-prabin.ca@arm.com> References: <20240105153814.427009-1-prabin.ca@arm.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,prabin.ca@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: kiXyyijPWz4GeRkTYmTwMUxBx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704469127594100030 Content-Type: text/plain; charset="utf-8" From: Pranav Madhu The Neoverse RD-V2 FVP platform includes 16 CPUs and each CPU has 64KB of L1 instruction/data cache, 2MB of L2 cache and 32MB of system level cache. Extend the SMBIOS support for RD-V2 platform with this configuration and reuse rest of the RD-N2 SMBIOS configuration for the RD-V2 platform. Signed-off-by: Pranav Madhu Signed-off-by: Prabin CA Reviewed-by: levi.yun --- Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c = | 7 +++++-- Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformation.c = | 9 ++++++--- Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c = | 20 +++++++++++++++++++- 3 files changed, 30 insertions(+), 6 deletions(-) diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInfor= mation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInforma= tion.c index b7e2238fb39c..edf2a5f63c63 100644 --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type1SystemInformation.c @@ -5,7 +5,7 @@ Reference Design platforms. Type 1 table defines attributes of the overall system such as manufacturer, product name, UUID etc. =20 - Copyright (c) 2021 - 2022, Arm Limited. All rights reserved. + Copyright (c) 2021 - 2024, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Specification Reference: @@ -33,7 +33,8 @@ "RdV1Mc\0" \ "RdN2\0" \ "RdN2Cfg1\0" \ - "RdN2Cfg2\0" + "RdN2Cfg2\0" \ + "RdV2\0" =20 typedef enum { ManufacturerName =3D 1, @@ -71,6 +72,8 @@ STATIC GUID mSmbiosUid[] =3D { {0xa4941d3d, 0xfac3, 0x4ace, {0x9a, 0x7e, 0xce, 0x26, 0x76, 0x64, 0x5e, = 0xda}}, /* Rd-N2-Cfg2 */ {0xd2946d07, 0x8057, 0x4c26, {0xbf, 0x53, 0x78, 0xa6, 0x5b, 0xe1, 0xc1, = 0x60}}, + /* Rd-V2 */ + {0x3b1180a3, 0x0744, 0x4194, {0xae, 0x2e, 0xed, 0xa5, 0xbc, 0x2e, 0x43, = 0x45}}, }; =20 /* System information */ diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorIn= formation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorI= nformation.c index b59172cf1cb9..ee269f707714 100644 --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformati= on.c +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type4ProcessorInformati= on.c @@ -6,7 +6,7 @@ family, processor id, maximum operating frequency, and other information related to the processor. =20 - Copyright (c) 2021 - 2022, Arm Limited. All rights reserved. + Copyright (c) 2021 - 2024, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Specification Reference: @@ -27,7 +27,7 @@ #define SOCKET_TYPE_BASE 3 #define SOCKET_TYPE_NUM 1 #define PROCESSOR_VERSION_BASE (SOCKET_TYPE_BASE + SOCKET_TYPE_NUM) -#define PROCESSOR_VERSION_NUM 10 +#define PROCESSOR_VERSION_NUM 11 #define SERIAL_NUMBER_BASE (PROCESSOR_VERSION_BASE + PROCESSOR_VERSIO= N_NUM) #define TYPE4_STRINGS \ "0x000\0" /* Part Number */ \ @@ -43,6 +43,7 @@ "Neoverse-N2\0" \ "Neoverse-N2\0" \ "Neoverse-N2\0" \ + "Neoverse-V2\0" \ "000-0\0" /* Serial number */ \ "783-3\0" \ "786-1\0" \ @@ -52,7 +53,8 @@ "78A-2\0" \ "7B7-1\0" \ "7B6-1\0" \ - "7B7-1\0" + "7B7-1\0" \ + "7F2-1\0" =20 typedef enum { PartNumber =3D 1, @@ -178,6 +180,7 @@ InstallType4ProcessorInformation ( break; case RdN2: case RdN2Cfg1: + case RdV2: mArmRdSmbiosType4.Base.CoreCount =3D CoreCount; mArmRdSmbiosType4.Base.EnabledCoreCount =3D CoreCount; mArmRdSmbiosType4.Base.ThreadCount =3D CoreCount; diff --git a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInform= ation.c b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformati= on.c index b71ce721e2e8..4af72919a3f1 100644 --- a/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c +++ b/Platform/ARM/SgiPkg/Drivers/SmbiosPlatformDxe/Type7CacheInformation.c @@ -6,7 +6,7 @@ implemented, cache configuration, ways of associativity and other information related to cache memory installed. =20 - Copyright (c) 2021 - 2022, Arm Limited. All rights reserved. + Copyright (c) 2021 - 2024, Arm Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent =20 @par Specification Reference: @@ -334,6 +334,24 @@ InstallType7CacheInformation ( mArmRdSmbiosType7[4].Base.InstalledSize2 =3D 8192; // 8MB SLC mArmRdSmbiosType7[4].Base.Associativity =3D CacheAssociativity16Way; break; + case RdV2: + /* L1 instruction cache */ + mArmRdSmbiosType7[0].Base.MaximumCacheSize2 =3D 64; // 64KB + mArmRdSmbiosType7[0].Base.InstalledSize2 =3D 64; // 64KB + mArmRdSmbiosType7[0].Base.Associativity =3D CacheAssociativity4Way; + /* L1 data cache */ + mArmRdSmbiosType7[1].Base.MaximumCacheSize2 =3D 64; // 64KB + mArmRdSmbiosType7[1].Base.InstalledSize2 =3D 64; // 64KB + mArmRdSmbiosType7[1].Base.Associativity =3D CacheAssociativity4Way; + /* L2 cache */ + mArmRdSmbiosType7[2].Base.MaximumCacheSize2 =3D 2048; // 2MB + mArmRdSmbiosType7[2].Base.InstalledSize2 =3D 2048; // 2MB + mArmRdSmbiosType7[2].Base.Associativity =3D CacheAssociativity8Way; + /* System level cache */ + mArmRdSmbiosType7[4].Base.MaximumCacheSize2 =3D 32768; // 32MB SLC + mArmRdSmbiosType7[4].Base.InstalledSize2 =3D 32768; // 32MB SLC + mArmRdSmbiosType7[4].Base.Associativity =3D CacheAssociativity16Way; + break; } =20 /* Install valid cache information tables */ --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113296): https://edk2.groups.io/g/devel/message/113296 Mute This Topic: https://groups.io/mt/103544576/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-