From nobody Fri Dec 19 17:12:26 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+113105+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+113105+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1704314664638216.5246533968956; Wed, 3 Jan 2024 12:44:24 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=qp9Qz9Hc/oEVuGl5G7cKMYHiY4Pv+NlPfyc4cmbH1Wo=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1704314664; v=1; b=fAO7ejLvkZKZQ53e3f3JiKnQfdgyToVvISiG8hnm15g5IzgEcilkOOFwTGUncghr6l7zMZDh dQuwpN+ZRMIsa3MXWCyI8Y9ODlYRVjLDZH887RVEXFaADR6MY7mqLmXQKi0bE5rL2Sa7QmEyHrB YElIlQpokOpy3Pd+mABF68+s= X-Received: by 127.0.0.2 with SMTP id ZGFRYY1788612xzb9rgDOf4L; Wed, 03 Jan 2024 12:44:24 -0800 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (NAM10-DM6-obe.outbound.protection.outlook.com [40.107.93.131]) by mx.groups.io with SMTP id smtpd.web10.28992.1704314663228833425 for ; Wed, 03 Jan 2024 12:44:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lqUImN15M0i6Ofl/uXM08kIELdxWHXsvvfqIPfAUidjcea89l3tCfIL8udWEJIWlZY1euLSuyroTke6DlW0aSu7nUChUMefqIGsQiVSX1R/gZlxFfuEAdw7QWIcW6+dK1k9AU0G7yaAkb/XBtiEbP847GxTjaDZIXtaJWwQH5wEuGVa/G3ONfL38bwWabXyZwYS5D1zghknlBOoLf8LVo6q7NedMCuGwfaiFIeWCk43kzR/yPmW+pGvfLEifANC6rC3TZyqk6Z7CDFiqx1Of0glidh/+q46V7EwIAAJ0cmLlLCMPTza+GW1nf6QhHwh3CjB8j/zQG3LE3XIZjXVb1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ro0qlsPs73pPBMuFIUQBrFwpvOc+BSit078kFtnbZFo=; b=k44R5wVvhsPxc0qsD1ruwP68kxEXJux3CsmtOBHgP245t+wbcfoIWngxQs1XPt4ucuCoBz2i7fcidDgih1PnO4bKhjCfTxITeQwd20FKAcsbtkWstYiVdX3pmz+kbNORdf2Uzucm0YZHnvQsTM4iuJCLnYvYcnOJTTZL2w2DV9/gIi/LaghI3IkaqtWBNpb9KlDXSaCNTDVKR3JqkF2eu5Tk0w4wHGiY8M7kewlYmaC3Vgy1j+rg4tFPKnSFkG1zzGyLovF5bdwI5BNy21/+mrLwh0oIe2u9i1psM6zXb2AZkEUUJkCpAObqwY/g6sDTJzueo5pd/8yhy3OIBX5wpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none X-Received: from LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) by CH0PR01MB7139.prod.exchangelabs.com (2603:10b6:610:f6::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.25; Wed, 3 Jan 2024 20:44:17 +0000 X-Received: from LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1]) by LV3PR01MB8464.prod.exchangelabs.com ([fe80::7748:d4a3:bcd9:14c1%6]) with mapi id 15.20.7159.013; Wed, 3 Jan 2024 20:44:17 +0000 From: "Rebecca Cran via groups.io" To: Leif Lindholm , Ard Biesheuvel , Sami Mujawar CC: Rebecca Cran , devel@edk2.groups.io Subject: [edk2-devel] [PATCH 2/3] ArmPkg: Fix the calculation of the timer period in GenericWatchdogDxe Date: Wed, 3 Jan 2024 13:43:52 -0700 Message-ID: <20240103204353.361541-3-rebecca@os.amperecomputing.com> In-Reply-To: <20240103204353.361541-1-rebecca@os.amperecomputing.com> References: <20240103204353.361541-1-rebecca@os.amperecomputing.com> X-ClientProxiedBy: CH2PR18CA0049.namprd18.prod.outlook.com (2603:10b6:610:55::29) To LV3PR01MB8464.prod.exchangelabs.com (2603:10b6:408:1a3::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV3PR01MB8464:EE_|CH0PR01MB7139:EE_ X-MS-Office365-Filtering-Correlation-Id: ad05560c-ac23-4f13-a1cb-08dc0c9cc10d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: +oT8O4JJKDR3/v85QbeGhohSL/JaePuXGhy8n9OTv9gwUbfqfm/YIsRqyI/iyZt9tFM/B/8j0lX7SL06DmxBZ4melSt5XEl3FogZP96xka+eE33PF0EfjmgF9xkb+Qt0jvftOqrByDxojUOUl5nlONasAh00twjedt2ajlAgAxdgb7OpyyYK/AhoAE2vv5pGhPutjw1IT8BIrScMA7ws44wGFTFjK7rABcq6UTqk/aZ9529XayHcL5RUZi6k55TKo6PS4wm/e61hNBF5v4NjwwiocUtOVulKT3FgKP6UqGr/ab/HGWJaTLGQ26eDuSpG0e/jibZh+agZAzsWM+pBL04Ax1IYetGy89VeBYS8X58cTYnFa55brwZ5W20xApYiYReD1eGUxwK1YjkWs6y5gujZ7FHMgu+2AMrENawEHDt7N/CxYT6tqvpwTSPC0tEc3UZZRx9ZA06r5JUunq2gt/QkGjxk7IGeEM9Ns9TFlcWqHwRpswKAIhIc9KZ/B8WACsxdKQCegOB0t7ZZM3B69Jlm62asJXYyOczApaffYVB6Ef2xrPQ4S2vARQVPjJwX9AEnCcQoH1ALwxB7NUkmeD7SoGbuxelWZ5jfCx3dcM8/POkpsPIIwHDdK7vtLmSf X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?jogttwMUbxXnI/igr4D6e+8TjSACyAQTEl8X5AvznrVRM+RIcOOYg7ETK4e7?= =?us-ascii?Q?AqGCcgqGuzYQGpxKHIqv8tUrg9znLJrERx17BwMIcicUl1h6l379tuOoKK+/?= =?us-ascii?Q?4qszbFPUK4b5ZBBb51wpr/TfzDfZEtK9MVqko5DZn7N+EQoGszi7hb2IoEPK?= =?us-ascii?Q?N0YULHzNfOAK4ij4gOsv/U+Pa4qVPyIGtUH5eg/JPk8uTr7XQ/QTLk/HzrNt?= =?us-ascii?Q?+cDHv6bvLKJEwcTs8qocBu1PeCj71cE/X99J3xToLmd76hnmk3bhgAy8SxhP?= =?us-ascii?Q?Ze98Voy9rnGbV144p0/f6U+zuVANzkWFqlMO5/H+tWt2mYrR53nyPuAyLAHB?= =?us-ascii?Q?FzXV9MR4Wa77FF7KhlNhgBFnypzY4kWCne+Mh7qJKOpHN7fWGXHM81Hgpl/K?= =?us-ascii?Q?dZn0jKp3ANLERxuYcjG3ynv1VZ7T6X3KK4PLHCc7VtCfJ4Mzw+ImsSe7LR0h?= =?us-ascii?Q?dvgOi8A/Tn7uZJ4R8mIK16kroBomiKJgb7vnVb1jEkWFx6dTdjDTi+nWdd8b?= =?us-ascii?Q?/xmtZaM0Ln2bT/QPAAFMI7GeOGH1uG1XjLuZfPqB4gyVBOMK0Yfmu/GwFHMk?= =?us-ascii?Q?J2K7H96+KdZ9Y+3XMbOLE7UtuQvpPwj3ja9Ph33LgOVrNu6uIKMfItTuha6V?= =?us-ascii?Q?UNw0j2kDt4ZsJd0GsXoITAutDT14BuAMKnUZMK/J1iwvDUylhSNN+Zj3TRkH?= =?us-ascii?Q?fC0fskzwKemq/CJ5cq6GcQnt9oVsRncLoG33VnIz2Zbkz/y/USTdkPd0kaCz?= =?us-ascii?Q?+qw4LUDn4fQJQeiyqLqOpiUeCgbQwjIQ+o7mvA1q2SxYtL+S+vVR3eE+sZj6?= =?us-ascii?Q?aBtVk1XTUA3vZzf7E/XicSlTMhdUVM5qZrWNo2A3juuGFq3N7f72b0Q+4TEa?= =?us-ascii?Q?3yiBPSgakgLarJnl/VAXgbw4wX3yQl0VBExL8OcJK3NO79099uJgk4N1cAvN?= =?us-ascii?Q?Ob+Z5tDQoDPkdKUNs2uQV/kmb2f3u622cGQQ8suT9eAnWmb8uLvXaWU4a7Qh?= =?us-ascii?Q?XFoXJvslH2ETZWlym9wBZVuAtndCcJHRfi+xrW8tm1L5NQn5txJJm2Q6cvTS?= =?us-ascii?Q?MUjVUIOAnTpUt3hEGvhanpVqKKMuR3OvIMRWag4j7dNNA3wPqxskT1qBAyvr?= =?us-ascii?Q?4qb88vNQk5XFwvUlcknZq9Bc6ec6Am16Q2muxtmldC24im9pOCCE2CNy9pzF?= =?us-ascii?Q?MkxqoZcSBF+2nGtSWvhJLDwPoM5AcS3fzK/exKKrw0prJ2mcj4c9gijX0dqh?= =?us-ascii?Q?ehoyWsvz8rwhPK3t/TQf23lUayW/0PTJnTkxqT9RxSM011yCEOcOxG1KLd4O?= =?us-ascii?Q?sQ/4yocJ5rwZ+vTQhIUX2C0XlQU2C7L8/+Leifqkq2SAsQqpWQPU/Ko1nxKo?= =?us-ascii?Q?FqmqEss8eiqQR9lC90r7a67DiOZqCavJoXDOTWV5Z4WbCbsjUDbvj2I07gga?= =?us-ascii?Q?wxZWCSAU49Asw5geYVdsdb/aoxNLYRQlWy5WWCw7f2aeZPaJnu+Xd5br24Zy?= =?us-ascii?Q?ju44uyiltMB2Tash5JesuhKwwpArQs5QRHOpHSyMpQ76+8rKxSwsjcxe/iL/?= =?us-ascii?Q?iNnkASrqwMzeY/DCLdrFljC4o34/2C6vpwkUrdEi5DhbjKjQ9ngJDbdqdGzw?= =?us-ascii?Q?Jk/Dlz4nrTw5OxbM4tMrnv4=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad05560c-ac23-4f13-a1cb-08dc0c9cc10d X-MS-Exchange-CrossTenant-AuthSource: LV3PR01MB8464.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 20:44:17.4644 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TMljhhDpsgQA5k2XBo3q/Ip2Vz3NH0SsMcTA4Q7omDXkFLfxG94cHF2dX3uHDQ7pf77LDpD7+Bi3Ft1xSQEt3Zt4l/ZhY2rwQoIGWFmTj4YK4Wf9bpDdWm/GBiX6YZdv X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR01MB7139 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,rebecca@os.amperecomputing.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: u1WgIdMvqUEJeunjxNC06tjpx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1704314665608100006 Content-Type: text/plain; charset="utf-8" Fix the calculation of the timer period in GenericWatchdogDxe: we need to multiply before dividing to keep the values as integers. Signed-off-by: Rebecca Cran --- ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c b/ArmPk= g/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c index 05df101d5f4b..8f02f38c64e3 100644 --- a/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c +++ b/ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.c @@ -119,7 +119,7 @@ WatchdogInterruptHandler ( // the timer period plus 1. // if (mWatchdogNotify !=3D NULL) { - TimerPeriod =3D ((TIME_UNITS_PER_SECOND / mTimerFrequencyHz) * mNumTim= erTicks); + TimerPeriod =3D ((TIME_UNITS_PER_SECOND * mNumTimerTicks) / mTimerFreq= uencyHz); mWatchdogNotify (TimerPeriod + 1); } =20 @@ -260,7 +260,7 @@ WatchdogGetTimerPeriod ( return EFI_INVALID_PARAMETER; } =20 - *TimerPeriod =3D ((TIME_UNITS_PER_SECOND / mTimerFrequencyHz) * mNumTime= rTicks); + *TimerPeriod =3D ((TIME_UNITS_PER_SECOND * mNumTimerTicks) / mTimerFrequ= encyHz); =20 return EFI_SUCCESS; } --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113105): https://edk2.groups.io/g/devel/message/113105 Mute This Topic: https://groups.io/mt/103510102/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-