From nobody Fri May 17 03:00:58 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112941+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1703732692127681.739216323133; Wed, 27 Dec 2023 19:04:52 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=a2wKqGxKFTsvQ1+87bb5kvuDOtZhd+NvTW4YNmS052I=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1703732684; v=1; b=U+QWXPrr/UPx/9H4l5mOkahqMsU36OXyz3QpN/dmcLlCHrBtbZRQuBWA/ko1zfi8QRoShtW6 X/YTpblv43QVzPAgSunWtmP2lXhdLBj8l7cd8/I78eY3vbPh7lbKHhDFJuShVSx19CYlresIXo3 rGnLBxdu2UAHg3Qle/L1aUso= X-Received: by 127.0.0.2 with SMTP id YLVjYY1788612x8Hybqk1teZ; Wed, 27 Dec 2023 19:04:44 -0800 X-Received: from NAM02-BN1-obe.outbound.protection.outlook.com (NAM02-BN1-obe.outbound.protection.outlook.com [40.107.212.85]) by mx.groups.io with SMTP id smtpd.web11.116318.1703732683797282396 for ; Wed, 27 Dec 2023 19:04:44 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RYVHUcUfYdRSDXb1ndnbOcgqfnNtF9JAoy0vrqXySxqMPbbSXt5baMWyeNB1iQCjCKS+/jvq4dF2oRyjNg5yuN9KcCPbMGyU6tgHsZSYspUw8VCj5J/awz2+fMj6tg750VYMbxGRpC1r7IS7p3nRJreqYzQ7AEQ7PkXvQtm/U+Cfw4gMmKnZuHYg6G05EY3c23oVdgEESHY0ubZVkRy2EAi98YV0J0rG0d5rW1NSBpplwqqXFwH48lB9IVW7foGss5wpWnLfXSaFwZPlG+FuvxivRumj+NqMPgY3ZdeQru2bgQmD+RB33ZzaKHt9eDi+xbAKcGzfp1qKK1K+ec3TTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KOqUgZtvAiDVKFXBHHSP6Z1dtQIfyENhYWzKRDKnjh4=; b=j1pfP49MNcFanu7mDKi31wYwtjAl0z6ShHomz2EX+M8jFtsQy/WS5uAl23ka4MYll0TxYH7jyb9osz6EXlz6wlFtbN822zKetQq54enVSyNCc2/i1j0H0aMPNKo57zyqUq68BiiMCVo8ryhYa5i/NhFauR2cKf8mW5xBqd/oSUfZNEOhww1QrrJ7JwWyxWOVxdPbQZMq3CUKfP7S67LIgbIogiH0w64LAw3Rcx5dbfO6jFshNZGPGZKANVroiXIKjiSyMkJsAuulIpAhtKZEZZk3k8z6/efQ0PHvdZyffvioHZ0CmJ62wsbYrp0kFns0FrAbl8L2GUYdiJ1fnpfrqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) X-Received: from SJ0PR03CA0047.namprd03.prod.outlook.com (2603:10b6:a03:33e::22) by SA0PR12MB4431.namprd12.prod.outlook.com (2603:10b6:806:95::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.28; Thu, 28 Dec 2023 03:04:41 +0000 X-Received: from CO1PEPF000042A8.namprd03.prod.outlook.com (2603:10b6:a03:33e:cafe::ba) by SJ0PR03CA0047.outlook.office365.com (2603:10b6:a03:33e::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7135.20 via Frontend Transport; Thu, 28 Dec 2023 03:04:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112941+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C X-Received: from SATLEXMB04.amd.com (165.204.84.17) by CO1PEPF000042A8.mail.protection.outlook.com (10.167.243.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7135.14 via Frontend Transport; Thu, 28 Dec 2023 03:04:40 +0000 X-Received: from TPE-L1-ABNCHANG.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 27 Dec 2023 21:04:38 -0600 From: "Chang, Abner via groups.io" To: CC: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen Subject: [edk2-devel] [PATCH] BaseTools/Workspace: Build fail if structure PCD is referred Date: Thu, 28 Dec 2023 11:04:19 +0800 Message-ID: <20231228030419.1701-1-abner.chang@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000042A8:EE_|SA0PR12MB4431:EE_ X-MS-Office365-Filtering-Correlation-Id: 05103f70-7cca-425f-c612-08dc0751bbf7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: 4bcc9dnZSi+nBnBWAQdiJKxmjiJ6lnrj9PbiVFeEFsM04UyVPZsYW1IL/lyKnbOwWkZwSdcHxuQvU1qgxR3dM1SVbxerb215NeZ08B9aw6SFw/iDdrv2OMtBpKAyP5K+VO82jECd5DI2K6/Zi3bGBMTsLhEjYoTgI+iEzfqlEcxbvJgmO4KwwcCRmqAenBKPxfPcKC5OqMgewadAwYbdSQt4YOx2Af5TlbhZF14V2GZXDqevS1VBSL1L3g8bGa4cM25+IT2mbBE1bVuJWKb8KQuA21uAE0MaYuad04TtKEhhU+rodaTjqF5cDogWydIbIInSqOQpik3qyTPAULL/HwnDiC16dJWBXageanrQRikWQpAzKAb48reIC4jgPOtJ/gEKdQcZJxXe7RpFwfqZ8dxgXFnAGaJTNcJNQDXH+ZDWFvDpdu9gtD6DOsJmdkFub1bwbBrqwrogSX3Ja2/bCMz3IR2d9JZAioRFhn9r+8c/pAzaJ3K6RDgCXDQRWSq1BYgsqYBDlYspwVc6EgKQOFB1HUN1pJc3zHR1jSf8orSHY17lOn9WmjkLOylbcen7YG0EHYWTsPorG16oJ2oPCQT445q6dT2IvEzNQhBuIOUwqkXqrJX70XeSVHFyDGRI8trjS6EXgmBLTt2s/aXE+smssisC98bnRb3xZGec/AKrXPaqeTRMGBoivZCkvMbXGbaFVbykIf62wewDyRDnULfQukH8IeueRdxDwrNH1WRL7s3x01OcX+Zc6dYzPV9JrjsZsJQP1XEEWoBg1hPK1an2F+jQ79bPchYsrVbQ6Bc= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Dec 2023 03:04:40.5528 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05103f70-7cca-425f-c612-08dc0751bbf7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000042A8.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4431 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,abner.chang@amd.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 8DPStlXlwh6r085sYk9upT2Dx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1703732692580100001 Content-Type: text/plain; charset="utf-8" From: Abner Chang Build fail if structured PCD is referred because a messy makefile is generated, only happens under Windows system. Signed-off-by: Abner Chang Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen --- BaseTools/Source/Python/Workspace/DscBuildData.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/BaseTools/Source/Python/Workspace/DscBuildData.py b/BaseTools/= Source/Python/Workspace/DscBuildData.py index 817cdbe5f19..391b09658fc 100644 --- a/BaseTools/Source/Python/Workspace/DscBuildData.py +++ b/BaseTools/Source/Python/Workspace/DscBuildData.py @@ -2840,7 +2840,10 @@ class DscBuildData(PlatformBuildClassObject): # start generating makefile MakeApp =3D PcdMakefileHeader if sys.platform =3D=3D "win32": - MakeApp =3D MakeApp + r'APPFILE =3D %s\%s.exe\n' % (self.Outpu= tPath, PcdValueInitName) + r'APPNAME =3D %s\n' % (PcdValueInitName) + r'OBJ= ECTS =3D %s\%s.obj %s.obj\n' % (self.OutputPath, PcdValueInitName, os.path.= join(self.OutputPath, PcdValueCommonName)) + 'INC =3D ' + MakeApp =3D MakeApp + r'APPFILE =3D %s\%s.exe' % (self.OutputP= ath, PcdValueInitName) + '\n'\ + + r'APPNAME =3D %s' % (PcdValueInitName) + '\n'\ + + r'OBJECTS =3D %s\%s.obj %s.obj' % (self.OutputPath, PcdVal= ueInitName, os.path.join(self.OutputPath, PcdValueCommonName)) +'\n'\ + + 'INC =3D ' else: MakeApp =3D MakeApp + PcdGccMakefile MakeApp =3D MakeApp + 'APPFILE =3D %s/%s\n' % (self.OutputPath= , PcdValueInitName) + 'APPNAME =3D %s\n' % (PcdValueInitName) + 'OBJECTS = =3D %s/%s.o %s.o\n' % (self.OutputPath, PcdValueInitName, os.path.join(self= .OutputPath, PcdValueCommonName)) + \ @@ -2950,8 +2953,8 @@ class DscBuildData(PlatformBuildClassObject): MakeApp +=3D "$(OBJECTS) : %s\n" % include_file if sys.platform =3D=3D "win32": PcdValueCommonPath =3D os.path.normpath(mws.join(GlobalData.gG= lobalDefines["EDK_TOOLS_PATH"], "Source\C\Common\PcdValueCommon.c")) - MakeApp =3D MakeApp + r'%s\PcdValueCommon.c : %s\n' % (self.Ou= tputPath, PcdValueCommonPath) - MakeApp =3D MakeApp + '\tcopy /y %s $@\n' % (PcdValueCommonPat= h) + MakeApp =3D MakeApp + r'%s\PcdValueCommon.c : %s' % (self.Outp= utPath, PcdValueCommonPath) + '\n' + MakeApp =3D MakeApp + '\tcopy /y %s $@' % (PcdValueCommonPath)= + '\n' else: PcdValueCommonPath =3D os.path.normpath(mws.join(GlobalData.gG= lobalDefines["EDK_TOOLS_PATH"], "Source/C/Common/PcdValueCommon.c")) MakeApp =3D MakeApp + '%s/PcdValueCommon.c : %s\n' % (self.Out= putPath, PcdValueCommonPath) --=20 2.37.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112941): https://edk2.groups.io/g/devel/message/112941 Mute This Topic: https://groups.io/mt/103395845/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-