From nobody Mon Feb 9 16:03:03 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112867+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112867+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1703458782; cv=none; d=zohomail.com; s=zohoarc; b=bCX2RnFxnJzxoCh/bNjWj8iXQMF90HQUSLeWQjG072EFdgYTrDOHPKbXTCnBo7vWhky1FW+WFAqNUH+voa1Hl33vRTWX9sjma3JF711ePKKo6tx2pj+ZPw/R/3+KPbAdwJzLTUK07V57NneDZELyvCjX7nSHQrEkvlETpuMd7Yo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1703458782; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=dGoRjJcjggwXx96seqND24b39NS5xa08/RdC6AWdGE0=; b=V7hw2RgwNb5lucqYCavPcSkLayi34768Ou8YW5bqTKuWwsU86f4mFbCUQYoyNPv3Gzhrhuv9lbRcckcT5zplUXEoLuLUba8IZlRj8qOQhiyfSdlNeGnQojw+3b4PO8s1IxEfASm4vgor6D2ybaWfjjeEC1ru5MukYpq7dx/UWvg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112867+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1703458782052410.9037413291088; Sun, 24 Dec 2023 14:59:42 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=reNznQR1WSdtWel7+lKkL26UOgwc9ahq8CIP3r+hc/0=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1703458781; v=1; b=GmogO4bFZISVPUPAXXiq3Cpgnzi16CS935x74s01BLmUEeamzuLOugVQMrLw/4gpJzGbYeSa 4m7ng3H/VINr4zMRsCaf3Zy+Z0iuBg34mBOptzlIg3hu01n6K1bvP01QL5/VeEl8pes/3aSj00v T9OY5BUlMpZZlByvSPvCyNms= X-Received: by 127.0.0.2 with SMTP id ApaSYY1788612xmgM7C2sm8j; Sun, 24 Dec 2023 14:59:41 -0800 X-Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mx.groups.io with SMTP id smtpd.web10.35943.1703458779777522038 for ; Sun, 24 Dec 2023 14:59:40 -0800 X-Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-50e7be1c65dso110330e87.3 for ; Sun, 24 Dec 2023 14:59:39 -0800 (PST) X-Gm-Message-State: Olool2v13HcTf9r2eXT1YfWMx1787277AA= X-Google-Smtp-Source: AGHT+IHLGaV02d6aKPV07rbZW+o7jo+awiyZxB67BslwE4UCEHQYcb455F65/amwq6A2PgQeFm3mpw== X-Received: by 2002:a05:6512:3e0f:b0:50e:7846:7adc with SMTP id i15-20020a0565123e0f00b0050e78467adcmr276091lfv.73.1703458777650; Sun, 24 Dec 2023 14:59:37 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id be44-20020a056512252c00b0050e78f5178asm326596lfb.262.2023.12.24.14.59.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 24 Dec 2023 14:59:37 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v3 08/16] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService Date: Mon, 25 Dec 2023 01:59:19 +0300 Message-Id: <20231224225927.9119-9-mike.maslenkin@gmail.com> In-Reply-To: <20231224225927.9119-1-mike.maslenkin@gmail.com> References: <20231224225927.9119-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1703458782520100028 Content-Type: text/plain; charset="utf-8" Cc: Nickle Wang Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- EmulatorPkg/EmulatorPkg.dec | 8 ++++---- .../RedfishPlatformCredentialLib.c | 12 ++++++------ .../RedfishPlatformCredentialLib.inf | 8 ++++---- 3 files changed, 14 insertions(+), 14 deletions(-) diff --git a/EmulatorPkg/EmulatorPkg.dec b/EmulatorPkg/EmulatorPkg.dec index fe81652b0478..c2a92923e9b7 100644 --- a/EmulatorPkg/EmulatorPkg.dec +++ b/EmulatorPkg/EmulatorPkg.dec @@ -77,15 +77,15 @@ ## Platform level Redfish Service control PCD # These PCDs are used to stop the Redfish sevice when secure boot is dis= abled # or exit boot service. - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled|TRUE= |BOOLEAN|0x00001020 - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService|TRUE|BO= OLEAN|0x00001021 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled|TRU= E|BOOLEAN|0x00001020 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService|TRUE|B= OOLEAN|0x00001021 ## # edk2 Redfish implementation on Emulator package is designed to access # to Redfish simulator. # https://github.com/DMTF/Redfish-Profile-Simulator # The user ID and password are fixed as below. - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId|"admin"|VOID*|0x000010= 22 - gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword|"pwd123456"|VOID*|0x= 00001023 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId|"admin"|VOID*|0x00001= 022 + gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword|"pwd123456"|VOID*|0= x00001023 gEmulatorPkgTokenSpaceGuid.PcdPersistentMemorySize|0x4000000|UINT32|0x00= 001024 =20 [PcdsFixedAtBuild, PcdsPatchableInModule] diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatfo= rmCredentialLib.c b/EmulatorPkg/Library/RedfishPlatformCredentialLib/Redfis= hPlatformCredentialLib.c index 614eaebb0d0e..5c167fcdea56 100644 --- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c +++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.c @@ -57,8 +57,8 @@ GetRedfishCredential ( // // User ID and Password. // - UserIdSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServieUserI= d)); - PasswordSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiePassw= ord)); + UserIdSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServiceUser= Id)); + PasswordSize =3D AsciiStrSize ((CHAR8 *)PcdGetPtr (PcdRedfishServicePass= word)); if ((UserIdSize =3D=3D 0) || (PasswordSize =3D=3D 0)) { DEBUG ((DEBUG_ERROR, "Incorrect string of UserID or Password for REdfi= sh service.\n")); return EFI_INVALID_PARAMETER; @@ -69,7 +69,7 @@ GetRedfishCredential ( return EFI_OUT_OF_RESOURCES; } =20 - CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServieUserId), UserIdSiz= e); + CopyMem (*UserId, (CHAR8 *)PcdGetPtr (PcdRedfishServiceUserId), UserIdSi= ze); =20 *Password =3D AllocateZeroPool (PasswordSize); if (*Password =3D=3D NULL) { @@ -77,7 +77,7 @@ GetRedfishCredential ( return EFI_OUT_OF_RESOURCES; } =20 - CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServiePassword), Passw= ordSize); + CopyMem (*Password, (CHAR8 *)PcdGetPtr (PcdRedfishServicePassword), Pass= wordSize); return EFI_SUCCESS; } =20 @@ -177,7 +177,7 @@ LibStopRedfishService ( // Check platform PCD to determine the action for stopping // Redfish service due to secure boot is disabled. // - if (!PcdGetBool (PcdRedfishServieStopIfSecureBootDisabled)) { + if (!PcdGetBool (PcdRedfishServiceStopIfSecureBootDisabled)) { return EFI_UNSUPPORTED; } else { // @@ -198,7 +198,7 @@ LibStopRedfishService ( // Check platform PCD to determine the action for stopping // Redfish service due to exit boot service. // - if (PcdGetBool (PcdRedfishServieStopIfExitbootService)) { + if (PcdGetBool (PcdRedfishServiceStopIfExitbootService)) { return EFI_UNSUPPORTED; } else { mStopRedfishService =3D TRUE; diff --git a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatfo= rmCredentialLib.inf b/EmulatorPkg/Library/RedfishPlatformCredentialLib/Redf= ishPlatformCredentialLib.inf index 41c389c4a292..9d151f14ee17 100644 --- a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.inf +++ b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCrede= ntialLib.inf @@ -36,10 +36,10 @@ UefiLib =20 [Pcd] - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfSecureBootDisabled ## C= ONSUMES - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieStopIfExitbootService ## C= ONSUMES - gEmulatorPkgTokenSpaceGuid.PcdRedfishServieUserId ## C= ONSUMES - gEmulatorPkgTokenSpaceGuid.PcdRedfishServiePassword ## C= ONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfSecureBootDisabled ## = CONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceStopIfExitbootService ## = CONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServiceUserId ## = CONSUMES + gEmulatorPkgTokenSpaceGuid.PcdRedfishServicePassword ## = CONSUMES =20 [Guids] gEfiGlobalVariableGuid --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112867): https://edk2.groups.io/g/devel/message/112867 Mute This Topic: https://groups.io/mt/103354127/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-