From nobody Mon Feb 9 16:13:00 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112851+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112851+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1703284882; cv=none; d=zohomail.com; s=zohoarc; b=OvRH9AlmnhI9+GY9d+xX2PXWbW0VNAzZSDdPSptP+OwJ1IgPyWCytDrJoj5GPQCAwH9/JSrl0V4Lc9JY07OPMGhpJptdvBvm7rlGtc3TflDVclNTRZZkR+D3XY0S8eN3XMCH+OiNNXRPWhaUxKxXNShFvu3HQR6FGgAoMXF7rPw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1703284882; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=cxX799vVo5e/71fstK1YHB45OGgilL5KgnNchZ5gY/s=; b=LeWfh64BG0LS8XNLNBDBPSNGOzx+FlSYSP9kM8Bx7Tg6CK3W+ly+UJ0c4AdISEt8JEAFwOhzirlPRx64d5N+z1gIImYgTdi0DLUfBbD7wPnBueDH3QfZ5s7La4nYn+Zbb0HdKxAoatrBR5Zy6hpxf7s/XTEP5cOyrnm5ZeI6s24= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112851+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1703284882740677.8692772685266; Fri, 22 Dec 2023 14:41:22 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=ayIb/ea2LFMCrbmCCIJ4DnOqfkOzBZDfwb8uiAbS3lQ=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1703284882; v=1; b=ROH+A8wQf5TEGqQx3QlepAJAwW4pEXM+5nJBjPjY3Munb/HixKHFATkCEFy1d55AMFsOy7AX rqqOTO5KNKLY2JIt4rIsDwTS8InYbUV+gDZu2SeTz0UB5LN7Y1rL7CRsF2hWTXZPA7xan1qMjy3 AzLjCcqo3dfHmgpiAxu2gWXQ= X-Received: by 127.0.0.2 with SMTP id gTb7YY1788612xPotzBgpMxR; Fri, 22 Dec 2023 14:41:22 -0800 X-Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web10.34715.1703284881599368552 for ; Fri, 22 Dec 2023 14:41:21 -0800 X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-50e70583191so488325e87.3 for ; Fri, 22 Dec 2023 14:41:21 -0800 (PST) X-Gm-Message-State: nrkWFpWBjCdnL6ATjev2fIwnx1787277AA= X-Google-Smtp-Source: AGHT+IGC7IiI50BfjCRuTkFpeKRG5FoaFcOvrdV42JUqKdFJbNgDBh0+btHhIAijPNy8Jggta3SSFg== X-Received: by 2002:a19:6419:0:b0:50e:7410:e890 with SMTP id y25-20020a196419000000b0050e7410e890mr33037lfb.127.1703284879592; Fri, 22 Dec 2023 14:41:19 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id c2-20020a056512074200b0050e6abeb1e4sm246453lfs.170.2023.12.22.14.41.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 22 Dec 2023 14:41:19 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH v3 3/3] RedfishClientPkg: fix access to unitialized variable. Date: Sat, 23 Dec 2023 01:41:13 +0300 Message-Id: <20231222224113.99793-4-mike.maslenkin@gmail.com> In-Reply-To: <20231222224113.99793-1-mike.maslenkin@gmail.com> References: <20231222224113.99793-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1703284883108100010 Content-Type: text/plain; charset="utf-8" It is possible that at the time of accessing to AsciiLocation pointer the memory is not allocated. Also gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) emits a warning for this case: RedfishFeatureUtilityLib.c:1889:37: error: 'AsciiLocation' may be used unin= itialized in this function [-Werror=3Dmaybe-uninitialized] *Location =3D StrAsciiToUnicode (AsciiLocation); Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang Reviewed-by: Abner Chang --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatu= reUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishF= eatureUtilityLib.c index 0f0b050d7eba..01c054ae3b70 100644 --- a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c +++ b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c @@ -1856,7 +1856,8 @@ GetEtagAndLocation ( } =20 if (Location !=3D NULL) { - *Location =3D NULL; + *Location =3D NULL; + AsciiLocation =3D NULL; =20 if (*(Response->StatusCode) =3D=3D HTTP_STATUS_200_OK) { Header =3D HttpFindHeader (Response->HeaderCount, Response->Headers,= HTTP_HEADER_LOCATION); --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112851): https://edk2.groups.io/g/devel/message/112851 Mute This Topic: https://groups.io/mt/103326962/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-