From nobody Mon Feb 9 09:33:21 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112574+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112574+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702598661; cv=none; d=zohomail.com; s=zohoarc; b=Bl+aTL5SnVkF6XPQH3y8rbh8I4VsTMMdZYbdaPOwOrRFNqj8vzjrw5iPPedCpXalX+dEG8Muu5BlVacVyyiYQyfqCKtQPwO23vEm+64JkU/Hp7pdmZfyoyZkO6erj67W95rfovfcPsijmhPQCEhv5m190wF2a8ReM50X+NEACNE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702598661; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=P6M8zkVVjMpSYgEI6N3/BDs4Jg+DoDPlQKgZEnOHLUI=; b=E9NU6IEQX8Il8vMxDUdMZqmCnOU0mIJhjulCe7o6y4i2bqxR5bLvHYC6ppk38xhzPuqyo1FsJg39VXyjD5pEFlsPw9/ZHG6PWOhdMJCV8Fg+abMnjfUUr7nk/3VbM117XnSc/BRP/NjTZUWSFYxxWq5Kc+26k6394gO0pAnfe68= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112574+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702598661208572.9428362768299; Thu, 14 Dec 2023 16:04:21 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=+hgK6jDZaW9XxjFPF6I3WHFUd7E0P5bkvnGlKXMmuK8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702598660; v=1; b=ei9MaUwP1XoNMxF21qeuByP+5PDhK8E1W4ROUXGAiNKR06AD7qysN/ncRmcW53tF68H7NwnD F8HWYuifUuG3PIXzVyEcOk7O0Wl/jUmU/84yCN72RDgjpwMmwo+VHZYxhe7caqOdsL4tXtfC7FE mf7YyRhZwI+BIwq4hyaDWWEY= X-Received: by 127.0.0.2 with SMTP id vmtyYY1788612xna0m6Z8xAC; Thu, 14 Dec 2023 16:04:20 -0800 X-Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mx.groups.io with SMTP id smtpd.web10.45421.1702598660088474334 for ; Thu, 14 Dec 2023 16:04:20 -0800 X-Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-50e0ba402b4so72905e87.1 for ; Thu, 14 Dec 2023 16:04:19 -0800 (PST) X-Gm-Message-State: g3SBKQVV6lrJjm3jOYD7qTQ1x1787277AA= X-Google-Smtp-Source: AGHT+IFfXg6XxBrSMYsiS8nm7bLM3S5/9LhjbWjap8Tj9JA6IRPB8PIaM9gnd20mE25mzhXyvN9LxA== X-Received: by 2002:a05:6512:ad5:b0:50d:1eb3:7bfd with SMTP id n21-20020a0565120ad500b0050d1eb37bfdmr5877581lfu.13.1702598658246; Thu, 14 Dec 2023 16:04:18 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id n11-20020a0565120acb00b0050be6038170sm1991256lfu.48.2023.12.14.16.04.17 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 16:04:17 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add check for NULL pointer to avoid ASSERT Date: Fri, 15 Dec 2023 03:03:57 +0300 Message-Id: <20231215000400.5311-2-mike.maslenkin@gmail.com> In-Reply-To: <20231215000400.5311-1-mike.maslenkin@gmail.com> References: <20231215000400.5311-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702598662181100003 Content-Type: text/plain; charset="utf-8" Initially RedfishPlatformConfigGetConfigureLang could return success even if ConfigureLangList is empty. After fixing this condition, RedfishPlatformConfigGetConfigureLang returns an error, but this doesn't help to avoid ASSERT because the error path is the same as for non-empty list. Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatu= reUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishF= eatureUtilityLib.c index 4cb7621c25c4..0f0b050d7eba 100644 --- a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c +++ b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtili= tyLib.c @@ -3118,7 +3118,9 @@ LeaveFunction: FreePool (ConfigureLangBuffer); } =20 - FreePool (ConfigureLangList); + if (ConfigureLangList !=3D NULL) { + FreePool (ConfigureLangList); + } =20 *NumberOfValues =3D (UINT32)ListCount; return FirstEmptyPropKeyValueList; --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112574): https://edk2.groups.io/g/devel/message/112574 Mute This Topic: https://groups.io/mt/103181638/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-