From nobody Mon Feb 9 08:57:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112556+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112556+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702596310; cv=none; d=zohomail.com; s=zohoarc; b=fC5XOrSBKRLgXmxP8MSQaQDUnXsFvnE+bR0vdVDGqgnwEbOude4JFxsrG4gfRRHDa9EwewDaK9w7/F5HSDz52UAMRBVOX7ztKwXEDEvWUhKjlzWWySDe3rN6sJuk3vLUtd2iOSuW0TOezZjS8USRcjOas9nteoXB6MnsiFfLStY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702596310; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=+4lPZXrRqdriexWEpfuEZ9XhdUF6S+mfGbNpZuFvC4Q=; b=mSp0MkGpLe0kqu9gJtMCLFWMzCqJRJnFY3h2Ck+2lqqjSPKRbpqjptVW8TEAzZJ+p3KuaGzxuvskRxtsXKit+ViyhdTfLPA1xhJC3z05BcnbLIhakNdFZxifGoB3aSVw+jdLftQbM+/YfSa0vsHcWquwsStBguesNYBEDrZWV8A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112556+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702596310265564.9798666273635; Thu, 14 Dec 2023 15:25:10 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=3USCcuFlzgL7GtcOtQUwgvm6slKCYcAHH3OGBnEdYWs=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702596309; v=1; b=cMI6Stprsh4+hyS/XHqfHvrBBz2m/mwL/o5n3vv1+0sFtU70eZeUS+1V/9adfKURo1MiAH2p AfnTueWev/jaihKXA59r/9jzLHN08PKeXzNZR4fyqN0MEQvFzkXKgh8ZHZ94TvvOIc02iJx4qk0 DCitgjaJWiWRuM9JV3Vyrjq4= X-Received: by 127.0.0.2 with SMTP id fT01YY1788612xSLC1vWkBQU; Thu, 14 Dec 2023 15:25:09 -0800 X-Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mx.groups.io with SMTP id smtpd.web10.44680.1702596309112631012 for ; Thu, 14 Dec 2023 15:25:09 -0800 X-Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-50bf8843a6fso62183e87.0 for ; Thu, 14 Dec 2023 15:25:08 -0800 (PST) X-Gm-Message-State: 7FguVoqX5ITgfnsCA0gvAihEx1787277AA= X-Google-Smtp-Source: AGHT+IGZSx6rJQ0Vo5IcbLqFBmXxJkKTig4n9J7CKLYiDaQVda/EHG/gNSYw1Rpr1DcSLAuXxUojdw== X-Received: by 2002:a05:6512:1318:b0:50b:bcd6:8ea2 with SMTP id x24-20020a056512131800b0050bbcd68ea2mr7512525lfu.4.1702596307125; Thu, 14 Dec 2023 15:25:07 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id j24-20020ac24558000000b0050bfe5815e7sm1973119lfm.165.2023.12.14.15.25.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 15:25:06 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 07/14] RedfishPkg: add proper initialization of IPMI request Date: Fri, 15 Dec 2023 02:24:51 +0300 Message-Id: <20231214232458.4636-8-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-1-mike.maslenkin@gmail.com> References: <20231214232458.4636-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702596312227100034 Content-Type: text/plain; charset="utf-8" All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be initialized to avoid error condition on BMC side. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- .../PlatformHostInterfaceBmcUsbNicLib.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsb= NicLib/PlatformHostInterfaceBmcUsbNicLib.c index 7f295fe7f1c0..c73e76df5791 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c @@ -616,9 +616,10 @@ HostInterfaceIpmiCheckMacAddress ( } =20 // Initial the get MAC address request. - GetLanConfigReq.SetSelector =3D 0; - GetLanConfigReq.BlockSelector =3D 0; - GetLanConfigReq.ParameterSelector =3D IpmiLanMacAddress; + GetLanConfigReq.ChannelNumber.Uint8 =3D 0; + GetLanConfigReq.SetSelector =3D 0; + GetLanConfigReq.BlockSelector =3D 0; + GetLanConfigReq.ParameterSelector =3D IpmiLanMacAddress; =20 ExitStatus =3D EFI_NOT_FOUND; for (ChannelNum =3D IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_1; @@ -640,6 +641,7 @@ HostInterfaceIpmiCheckMacAddress ( } else { DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " No cached IPMI LAN info\n")= ); DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Send NetFn =3D App, Command= =3D 0x42 to channel %d\n", ChannelNum)); + GetChanelInfoRequest.ChannelNumber.Uint8 =3D 0; GetChanelInfoRequest.ChannelNumber.Bits.ChannelNo =3D (UINT8)Channel= Num; Status =3D IpmiGetChannel= Info ( &GetChanelInfo= Request, --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112556): https://edk2.groups.io/g/devel/message/112556 Mute This Topic: https://groups.io/mt/103181042/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-