From nobody Mon Feb 9 08:57:25 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112553+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112553+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702596307; cv=none; d=zohomail.com; s=zohoarc; b=L929eju2bAl9bdl281eUOySMJZ1Da64SmIzvU9Vzeph2YoXeSj5IB70TPSTGLZpY65XhncT1lTSy722L1S2yxY9HpQEFeP17Vp3ZnCYFCsppjTKselXwADKt16cEznsw5NEq4EpH+MSb4HDT8QTM4+WpNeY/VcM2S5lQlEP1xt0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702596307; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=RTgd10E+xZEMFj9HCIfPSWCZ62I/EpiYaxo/GMXUpRk=; b=HxPswhhw9V8KjRyJPLIc8Gk9IOaVGrGE2zT56iUnsNG7zN7c5pQmWCFZPUPVBu5FKXSB48RfY8i21UaNW7p4n9ZOQjOR/zudvKCfdGu5ytSVV4EPT/tBQFfK/bGkIxz9NpxWIG8yeTpdnk4R1Vlbah4jpKUCL6kLNdey775jj+Q= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112553+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702596307975534.7221069131771; Thu, 14 Dec 2023 15:25:07 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=1wfei/GlAtKKh6r/UirT3kDp6KjOXr7AzbFawFB9gFk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702596307; v=1; b=oZVa39fEAX0d4GMcg+P1yY+3xq8XNKgKUdE4wtXXYCVGH9E36muiRxNSf8TT2ELJYpfwxk+N XnOt03wWdvis6Gmr28boNHf/YbFoza83QuyKsuB59/E6J/uxLjeIK4LZO5pcdITfWMAu2QwfGhO rnaEk6lql7jiBTQZNMmF1bEs= X-Received: by 127.0.0.2 with SMTP id i7kOYY1788612xWrQQIgQZPj; Thu, 14 Dec 2023 15:25:07 -0800 X-Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mx.groups.io with SMTP id smtpd.web11.44952.1702596306787282785 for ; Thu, 14 Dec 2023 15:25:07 -0800 X-Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-50e0ba402b4so41578e87.1 for ; Thu, 14 Dec 2023 15:25:06 -0800 (PST) X-Gm-Message-State: AeHCSJmnh4quggtRPBnJYrsBx1787277AA= X-Google-Smtp-Source: AGHT+IEkTK5uYPNY53dTPeA0rxMziTdh6uTErXMAFEtE9zWXlsYghok9JodPaJagrR/ngQBKZueFmg== X-Received: by 2002:ac2:4c51:0:b0:50e:1870:1ef4 with SMTP id o17-20020ac24c51000000b0050e18701ef4mr1313650lfk.48.1702596304788; Thu, 14 Dec 2023 15:25:04 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id j24-20020ac24558000000b0050bfe5815e7sm1973119lfm.165.2023.12.14.15.25.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 15:25:04 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH v2 04/14] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations Date: Fri, 15 Dec 2023 02:24:48 +0300 Message-Id: <20231214232458.4636-5-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-1-mike.maslenkin@gmail.com> References: <20231214232458.4636-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702596308210100009 Content-Type: text/plain; charset="utf-8" It's unclear why the new string is allocated as copy of the original string if its pointer is stored in an array and the original string is released immediately after the copy is created. All data allocated in the same pool. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index cbc65ba59408..f970e317b3f6 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -2057,9 +2057,7 @@ RedfishPlatformConfigProtocolGetConfigureLang ( TmpString =3D HiiGetRedfishString (StatementRef->Statement->Parent= Form->ParentFormset->HiiHandle, FullSchema, StatementRef->Statement->Descri= ption); ASSERT (TmpString !=3D NULL); if (TmpString !=3D NULL) { - TmpConfigureLangList[Index] =3D AllocateCopyPool (StrSize (TmpSt= ring), TmpString); - ASSERT (TmpConfigureLangList[Index] !=3D NULL); - FreePool (TmpString); + TmpConfigureLangList[Index] =3D TmpString; ++Index; } } --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112553): https://edk2.groups.io/g/devel/message/112553 Mute This Topic: https://groups.io/mt/103181039/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-