From nobody Mon Feb 9 23:38:37 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112560+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112560+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702596313; cv=none; d=zohomail.com; s=zohoarc; b=IHXXDbfoaYsm0PctW6B9/vUP/jMhPEWW9fZxwGkHPSP0FhybHoTHAhTp+YmPMtssnrEYub3nXxHJx6Ue3yv2pn9jaOc41yRKRrEuiEP51nk8ALM//N0s6BUFffWEZqyVq1iMpT8QFYSmQq7ncmI2aIJQmKkhhE9Mlvlp73BOvJs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702596313; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=iMBSQQe7jzbECqNWMJ2YNXQPgaEqt8YUTU+zz73YDpo=; b=bvvzVizmMCEjDJRslItMJzH1csPuQ1blfRoLLIsE2N2+P5D+425C5PDaT9sq0VvWqKrpDZFSiAotA9w3YzJUpLaaHjecXFPPjX2m6UEewKrrsOPRcpfRFQkHqJirhUGyeA+Oa7518YunXSZiIkX/wBNwiX/ZDzghWJkXE7dcvBo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112560+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702596313395412.3983515976115; Thu, 14 Dec 2023 15:25:13 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=Y6TmXiNblfw81Bl/BioE8qAjxMdWDj4de8hrbR2xzo0=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702596313; v=1; b=djXWkP00JvyCxoFz95clIjK2GX8h18sEZgaf20ybHkg2+sYRy0or1znJSEFxumtctqy9ihuX /+lLx21Worcc0B1PC7TlENdhBZBm4hrehTXK6SHVWdpYbKVhrTB77FjkQDlPPeoduU/iSyk8Sar XsEBmShynFaRRw0u40sS0Pec= X-Received: by 127.0.0.2 with SMTP id FpPTYY1788612xxpAzTcHLCS; Thu, 14 Dec 2023 15:25:13 -0800 X-Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by mx.groups.io with SMTP id smtpd.web11.44959.1702596312232900959 for ; Thu, 14 Dec 2023 15:25:12 -0800 X-Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-50bfd8d5c77so37302e87.1 for ; Thu, 14 Dec 2023 15:25:11 -0800 (PST) X-Gm-Message-State: i8Ov5rRa8vXpJ7HET6SZ8LN3x1787277AA= X-Google-Smtp-Source: AGHT+IFEDV3hgcacFuF2rNunFu77GRFucxrR5JCX5Sjwbjzn4DDYuG7uPKko4KrKPPdOSLWvTHNYjA== X-Received: by 2002:a05:6512:23a7:b0:50d:1a10:d27f with SMTP id c39-20020a05651223a700b0050d1a10d27fmr3188562lfv.201.1702596310156; Thu, 14 Dec 2023 15:25:10 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id j24-20020ac24558000000b0050bfe5815e7sm1973119lfm.165.2023.12.14.15.25.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 14 Dec 2023 15:25:09 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin , Pedro Falcato Subject: [edk2-devel] [PATCH v2 11/14] RedfishDiscoverDxe: refine InitInformationData(), remove unnecessary casts Date: Fri, 15 Dec 2023 02:24:55 +0300 Message-Id: <20231214232458.4636-12-mike.maslenkin@gmail.com> In-Reply-To: <20231214232458.4636-1-mike.maslenkin@gmail.com> References: <20231214232458.4636-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702596314268100043 Content-Type: text/plain; charset="utf-8" Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Pedro Falcato Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 36 +++++++++---------- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 724aa35431a8..e3fc2d809dbc 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -730,12 +730,12 @@ VOID InitInformationData ( IN EFI_REDFISH_DISCOVERED_INFORMATION *Information, IN UINTN *RedfishVersion OPTIONAL, - IN CHAR8 *RedfishLocation OPTIONAL, - IN CHAR8 *Uuid OPTIONAL, - IN CHAR8 *Os OPTIONAL, - IN CHAR8 *OsVer OPTIONAL, - IN CHAR8 *Product OPTIONAL, - IN CHAR8 *ProductVer OPTIONAL + IN CONST CHAR8 *RedfishLocation OPTIONAL, + IN CONST CHAR8 *Uuid OPTIONAL, + IN CONST CHAR8 *Os OPTIONAL, + IN CONST CHAR8 *OsVer OPTIONAL, + IN CONST CHAR8 *Product OPTIONAL, + IN CONST CHAR8 *ProductVer OPTIONAL ) { if (RedfishVersion !=3D NULL) { @@ -744,33 +744,33 @@ InitInformationData ( } =20 if (RedfishLocation !=3D NULL) { - Information->Location =3D (CHAR16 *)AllocatePool (AsciiStrSize ((const= CHAR8 *)RedfishLocation) * sizeof (CHAR16)); - AsciiStrToUnicodeStrS ((const CHAR8 *)RedfishLocation, Information->Lo= cation, AsciiStrSize ((const CHAR8 *)RedfishLocation) * sizeof (CHAR16)); + Information->Location =3D AllocatePool (AsciiStrSize (RedfishLocation)= * sizeof (CHAR16)); + AsciiStrToUnicodeStrS (RedfishLocation, Information->Location, AsciiSt= rSize (RedfishLocation) * sizeof (CHAR16)); DEBUG ((DEBUG_MANAGEABILITY, "Redfish service location: %s.\n", Inform= ation->Location)); } =20 if (Uuid !=3D NULL) { - Information->Uuid =3D (CHAR16 *)AllocatePool (AsciiStrSize ((const CHA= R8 *)Uuid) * sizeof (CHAR16)); - AsciiStrToUnicodeStrS ((const CHAR8 *)Uuid, Information->Uuid, AsciiSt= rSize ((const CHAR8 *)Uuid) * sizeof (CHAR16)); + Information->Uuid =3D AllocatePool (AsciiStrSize (Uuid) * sizeof (CHAR= 16)); + AsciiStrToUnicodeStrS (Uuid, Information->Uuid, AsciiStrSize (Uuid) * = sizeof (CHAR16)); DEBUG ((DEBUG_MANAGEABILITY, "Service UUID: %s.\n", Information->Uuid)= ); } =20 if (Os !=3D NULL) { - Information->Os =3D (CHAR16 *)AllocatePool (AsciiStrSize ((const CHAR8= *)Os) * sizeof (CHAR16)); - AsciiStrToUnicodeStrS ((const CHAR8 *)Os, Information->Os, AsciiStrSiz= e ((const CHAR8 *)Os) * sizeof (CHAR16)); + Information->Os =3D AllocatePool (AsciiStrSize (Os) * sizeof (CHAR16)); + AsciiStrToUnicodeStrS (Os, Information->Os, AsciiStrSize (Os) * sizeof= (CHAR16)); DEBUG ((DEBUG_MANAGEABILITY, "Redfish service OS: %s, Version:%s.\n", = Information->Os, Information->OsVersion)); } =20 if (OsVer !=3D NULL) { - Information->OsVersion =3D (CHAR16 *)AllocatePool (AsciiStrSize ((cons= t CHAR8 *)OsVer) * sizeof (CHAR16)); - AsciiStrToUnicodeStrS ((const CHAR8 *)OsVer, Information->OsVersion, A= sciiStrSize ((const CHAR8 *)OsVer) * sizeof (CHAR16)); + Information->OsVersion =3D AllocatePool (AsciiStrSize (OsVer) * sizeof= (CHAR16)); + AsciiStrToUnicodeStrS (OsVer, Information->OsVersion, AsciiStrSize (Os= Ver) * sizeof (CHAR16)); } =20 if ((Product !=3D NULL) && (ProductVer !=3D NULL)) { - Information->Product =3D (CHAR16 *)AllocatePool (AsciiStrSize ((const = CHAR8 *)Product) * sizeof (CHAR16)); - AsciiStrToUnicodeStrS ((const CHAR8 *)Product, Information->Product, A= sciiStrSize ((const CHAR8 *)Product) * sizeof (CHAR16)); - Information->ProductVer =3D (CHAR16 *)AllocatePool (AsciiStrSize ((con= st CHAR8 *)ProductVer) * sizeof (CHAR16)); - AsciiStrToUnicodeStrS ((const CHAR8 *)ProductVer, Information->Product= Ver, AsciiStrSize ((const CHAR8 *)ProductVer) * sizeof (CHAR16)); + Information->Product =3D AllocatePool (AsciiStrSize (Product) * sizeof= (CHAR16)); + AsciiStrToUnicodeStrS (Product, Information->Product, AsciiStrSize (Pr= oduct) * sizeof (CHAR16)); + Information->ProductVer =3D AllocatePool (AsciiStrSize (ProductVer) * = sizeof (CHAR16)); + AsciiStrToUnicodeStrS (ProductVer, Information->ProductVer, AsciiStrSi= ze (ProductVer) * sizeof (CHAR16)); DEBUG ((DEBUG_MANAGEABILITY, "Redfish service product: %s, Version:%s.= \n", Information->Product, Information->ProductVer)); } } --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112560): https://edk2.groups.io/g/devel/message/112560 Mute This Topic: https://groups.io/mt/103181047/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-