From nobody Mon Feb 9 22:03:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112443+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112443+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392874; cv=none; d=zohomail.com; s=zohoarc; b=KGwb6Xr3uzgJV3w24X494Wn5AgaoLPg/pidWLkErn7OZPjVxSbIbU8RTNJVW9UQwszYCT/vMr87FxCW0ghMQl2BwJJln+twn7KQrcF5iRzee72BoH4MJVWA8QTNeTqkuaJ7REWehh7NLZdzOHKpcHQ9sJ1BjsdNRwqFJwgZ1F+8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392874; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=2YcyDbWj0Q8RY0XkFkv/x53JMDa+0cvqMeFegEH1EUc=; b=W6ay5iFMiFGQI6pmcFYg/25mdPzaZfHHHbKElN/AV5rxGPpKXTZ8Hafu9m4uOkODNdQ2qO91Ht38KFBe1Sxbd9Djp+CD5h4dXVykgzJXwmrRpYlGrZMEp2ohfTTb04jsMusQqudaY7Lg/w+ZSB9bjSvjn1+NnyH0wihLC3qDOZw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112443+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702392874147837.9451161960344; Tue, 12 Dec 2023 06:54:34 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=8xITqyL1oqOKSU08HHaKSWmtnLiHk5HLUAW8/ExRHRM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392873; v=1; b=TNEFxs422+DHFb5xXwV+MKkqB0S4X+LfZj3YWKKTPJ8EPFsyUOTxff6ySvJklhm6B76Z4sfM GoqLx4wDj770Oc73LJxPdofS7Zm8EBjzQ9pECzCi9DJ9s4bB98zz3Lx5ssqZDjUtcYsjfjyjrpZ tT3KAV55TZGivS/DMQlLFmhY= X-Received: by 127.0.0.2 with SMTP id HJIKYY1788612xV9Ko21ue67; Tue, 12 Dec 2023 06:54:33 -0800 X-Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by mx.groups.io with SMTP id smtpd.web10.3584.1702392873062825927 for ; Tue, 12 Dec 2023 06:54:33 -0800 X-Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-50be10acaf9so5691815e87.1 for ; Tue, 12 Dec 2023 06:54:32 -0800 (PST) X-Gm-Message-State: iOsgoTPdInTPVRl7AwfnI2y3x1787277AA= X-Google-Smtp-Source: AGHT+IG/9vJElDTe5DMGqqwQmUUl4RDSbKWpL3qeWgn4dJV9htzdZxaiC3fBTSj2dEIBZhjzVFraUg== X-Received: by 2002:a19:5e1d:0:b0:50b:f03c:1eb2 with SMTP id s29-20020a195e1d000000b0050bf03c1eb2mr2898719lfb.20.1702392870972; Tue, 12 Dec 2023 06:54:30 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.30 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:30 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 7/9] RedfishPkg: add proper initialization of IPMI request Date: Tue, 12 Dec 2023 17:54:10 +0300 Message-Id: <20231212145412.50434-8-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392876016100031 Content-Type: text/plain; charset="utf-8" All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be initialized to avoid error condition on BMC side. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformH= ostInterfaceBmcUsbNicLib.c b/RedfishPkg/Library/PlatformHostInterfaceBmcUsb= NicLib/PlatformHostInterfaceBmcUsbNicLib.c index 7f295fe7f1c0..c73e76df5791 100644 --- a/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c +++ b/RedfishPkg/Library/PlatformHostInterfaceBmcUsbNicLib/PlatformHostInte= rfaceBmcUsbNicLib.c @@ -616,9 +616,10 @@ HostInterfaceIpmiCheckMacAddress ( } =20 // Initial the get MAC address request. - GetLanConfigReq.SetSelector =3D 0; - GetLanConfigReq.BlockSelector =3D 0; - GetLanConfigReq.ParameterSelector =3D IpmiLanMacAddress; + GetLanConfigReq.ChannelNumber.Uint8 =3D 0; + GetLanConfigReq.SetSelector =3D 0; + GetLanConfigReq.BlockSelector =3D 0; + GetLanConfigReq.ParameterSelector =3D IpmiLanMacAddress; =20 ExitStatus =3D EFI_NOT_FOUND; for (ChannelNum =3D IPMI_CHANNEL_NUMBER_IMPLEMENTATION_SPECIFIC_1; @@ -640,6 +641,7 @@ HostInterfaceIpmiCheckMacAddress ( } else { DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " No cached IPMI LAN info\n")= ); DEBUG ((DEBUG_REDFISH_HOST_INTERFACE, " Send NetFn =3D App, Command= =3D 0x42 to channel %d\n", ChannelNum)); + GetChanelInfoRequest.ChannelNumber.Uint8 =3D 0; GetChanelInfoRequest.ChannelNumber.Bits.ChannelNo =3D (UINT8)Channel= Num; Status =3D IpmiGetChannel= Info ( &GetChanelInfo= Request, --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112443): https://edk2.groups.io/g/devel/message/112443 Mute This Topic: https://groups.io/mt/103130785/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-