From nobody Mon Feb 9 22:03:55 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+112440+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112440+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1702392871; cv=none; d=zohomail.com; s=zohoarc; b=F02nqHViS2yX/Kj3CFiHgXUEl9lEeLkkBXkoZjcYxgH19OGw6Q6xoC4fVcCu8GamMzbNwa6dX3mOGrQkR4VpPFsYAxpoiQNhqx6tUS9dxQgbx60/nhJNyhaJ8sJ2/kcG7CRyqE28FrUtZ0/7U/PCzy/XCjXwCYVWs5CjBnpBZ1g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1702392871; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=RSk4+v1qYsh8xGmNgxnXxMTpfhf8iSu6XJcDTXYvaOQ=; b=LStK7w4RT94ktedLXKjtxIOtxrDSYBepVFxbQ5HgXVCaM8YCc1L6IQ+P6pn7ZZiHkxxErpDC2pufrSQe7RIV4qD7sylvR55gcOFiog2xZpO+fzqcK8JlDGBIjKNcVKYAdcYTFA+/QmDQ7d31KhUzorPJdF59QjOJ3PjEhu6BWy0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+112440+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1702392871573590.9185732738979; Tue, 12 Dec 2023 06:54:31 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=8twMeQo8IVIf446o4PixLOERfohCgNu+0tQLEMmKDfE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1702392871; v=1; b=dlTDjRKG0TkFPMILotubWxEUJFGvFp8jUnGZLHOgwpolWN72htp0v2ZXVVe40SdQRFdKA3Xv yk2HmGXt1hgo3vIowq3tVGXLy74trdCm0f+8zIYYxsbeYIkhQDa2tFxQ/9jnHGbYGLiDccnnGEf Jq+AqfeImPos2n/FmLfwHaXY= X-Received: by 127.0.0.2 with SMTP id w662YY1788612xIagyBavyDn; Tue, 12 Dec 2023 06:54:31 -0800 X-Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by mx.groups.io with SMTP id smtpd.web10.3582.1702392870436785729 for ; Tue, 12 Dec 2023 06:54:30 -0800 X-Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-50bffb64178so6810385e87.2 for ; Tue, 12 Dec 2023 06:54:30 -0800 (PST) X-Gm-Message-State: wH2nJAOLlWCjg48dwPtk9pd9x1787277AA= X-Google-Smtp-Source: AGHT+IHQU44NGOThNxrQ419wh6rHRVm9Zz5YVFNc9VdKAlyYtC9JdjzwhEY1e5WFhMl2eEkxxDy1Sw== X-Received: by 2002:ac2:4e14:0:b0:50c:d6b:885e with SMTP id e20-20020ac24e14000000b0050c0d6b885emr3945837lfr.22.1702392868473; Tue, 12 Dec 2023 06:54:28 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id m21-20020a0565120a9500b0050d1d8674d2sm952008lfu.292.2023.12.12.06.54.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 12 Dec 2023 06:54:28 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com, Mike Maslenkin Subject: [edk2-devel] [PATCH 4/9] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations Date: Tue, 12 Dec 2023 17:54:07 +0300 Message-Id: <20231212145412.50434-5-mike.maslenkin@gmail.com> In-Reply-To: <20231212145412.50434-1-mike.maslenkin@gmail.com> References: <20231212145412.50434-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1702392871998100009 Content-Type: text/plain; charset="utf-8" It's unclear why the new string is allocated as copy of the original string if its pointer is stored in an array and the original string is released immediately after the copy is created. All data allocated in the same pool. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c= b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index cbc65ba59408..f970e317b3f6 100644 --- a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c +++ b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c @@ -2057,9 +2057,7 @@ RedfishPlatformConfigProtocolGetConfigureLang ( TmpString =3D HiiGetRedfishString (StatementRef->Statement->Parent= Form->ParentFormset->HiiHandle, FullSchema, StatementRef->Statement->Descri= ption); ASSERT (TmpString !=3D NULL); if (TmpString !=3D NULL) { - TmpConfigureLangList[Index] =3D AllocateCopyPool (StrSize (TmpSt= ring), TmpString); - ASSERT (TmpConfigureLangList[Index] !=3D NULL); - FreePool (TmpString); + TmpConfigureLangList[Index] =3D TmpString; ++Index; } } --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112440): https://edk2.groups.io/g/devel/message/112440 Mute This Topic: https://groups.io/mt/103130782/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-