From nobody Sat Feb 7 07:25:50 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+111628+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111628+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1700697678; cv=none; d=zohomail.com; s=zohoarc; b=h6+VVRIkhXhWZ5DqeSmGK+nA+dogPhitqk+++rf48oweVAkSjk8Jtvyzd7pA+gcITrl7wk1Eywf45CmAxDhUJAAXNmVkNb2g3JTsty81ktuSF+YwV0KSk4PZBfLqWV4f/zqgSi7JtyEQ65fTFMLy6SNlrjBfylfHLj9sxjXr1Aw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1700697678; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=EI3hNXv6ITZIwm4S9Dc/WIZgUl6XKfM5vGPpsTb/6nA=; b=Nwe2jHyuPKLL3jcOlLs4Ep7eZRXrSjlIFII8m5F5XKPozHjL736M5CT5TkNsZ2A1eBH0qxktwXYv4QQbU+dTQ7NpBPBJhm4p4HoaU8wJBA4axnuo7KGPfNfeA1P3u9J16bHJcdcqIWcpq/yw3rUhZcuv4+06N36xwR9W4afzIUw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111628+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1700697678369220.94054097952062; Wed, 22 Nov 2023 16:01:18 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=A/tUvbihZ85NSscIV+4ILFLMR+Gv8Ou932Ilgkn+2fA=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1700697678; v=1; b=tc/szDQeHmDJKDU4JdXVuP757ONmSvbP/FCZoebPUnGufSSbNEOFkBMRtoide4EEgbdlcC/q 0UTLttu8UaVDgptB2dwvr7ujrtAv44E85S9AmIYAqINPWGzO3b2SMjH6zjXh289WyFtZGdf0mcS lO2rBtOGu6If14etPUWStg84= X-Received: by 127.0.0.2 with SMTP id uY7nYY1788612xVpWTqr16al; Wed, 22 Nov 2023 16:01:18 -0800 X-Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by mx.groups.io with SMTP id smtpd.web11.79519.1700697677224430310 for ; Wed, 22 Nov 2023 16:01:17 -0800 X-Received: by mail-lf1-f50.google.com with SMTP id 2adb3069b0e04-507cd62472dso1500426e87.0 for ; Wed, 22 Nov 2023 16:01:16 -0800 (PST) X-Gm-Message-State: N0DlB9lxNKivqBEvMpIY9yy7x1787277AA= X-Google-Smtp-Source: AGHT+IFRLO6wUsQAfgEU4ooP3WRmivIDaU18dnORb5WePL5aEq5wS7M/sPOnghhcVC/2XY9pBidnFA== X-Received: by 2002:ac2:4906:0:b0:507:bd5f:a40a with SMTP id n6-20020ac24906000000b00507bd5fa40amr302358lfi.23.1700697675247; Wed, 22 Nov 2023 16:01:15 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id q19-20020a194313000000b0050a78dac3fasm10621lfa.12.2023.11.22.16.01.14 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 22 Nov 2023 16:01:14 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com Subject: [edk2-devel] [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib Date: Thu, 23 Nov 2023 03:01:01 +0300 Message-Id: <20231123000103.31216-2-mike.maslenkin@gmail.com> In-Reply-To: <20231123000103.31216-1-mike.maslenkin@gmail.com> References: <20231123000103.31216-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1700697680184100009 Content-Type: text/plain; charset="utf-8" Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c b/RedfishPkg/= Library/HiiUtilityLib/HiiUtilityLib.c index 168b4459844f..fd322c2086d8 100644 --- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c +++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c @@ -388,11 +388,13 @@ SetQuestionValue ( Question->Value.BufferLen =3D Question->StorageWidth; Question->Value.Buffer =3D AllocateZeroPool (Question->StorageWid= th); if (Question->Value.Buffer =3D=3D NULL) { + FreePool (TemString); return EFI_OUT_OF_RESOURCES; } =20 CopyMem (Question->Value.Buffer, TemString, StrSize (TemString)); Src =3D Question->Value.Buffer; + FreePool (TemString); } else { CopyMem (&Question->Value.Value, &QuestionValue->Value, sizeof (EFI_= IFR_TYPE_VALUE)); Src =3D (UINT8 *)&Question->Value.Value; --=20 2.32.0 (Apple Git-132) -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111628): https://edk2.groups.io/g/devel/message/111628 Mute This Topic: https://groups.io/mt/102759077/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-