From nobody Mon Feb 9 07:05:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+111624+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111624+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1700697016; cv=none; d=zohomail.com; s=zohoarc; b=Dhz4P+zb9ReqXQhTpLnt2Q8GjMvR7G3JEMR0TbZ8sYO/9pB7SRSLVA6bdtzlzwfwO7G4b2hd0Z5TW35StWdhxOD4m9+3Z2Pj/ATOz6Wuj5rehPWcCCu9FPOxSI2Ofe/S1aFyDZZahWBAoGTTGJCnw+QqMyhpAtX10X3x1FrzzKg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1700697016; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=XEhDyreZlv3qQk0I3MUzQMZLoHa9fg/2xZ03bx41wWE=; b=V7gh9XcXWos3Ic6S+KivcB+MSF4BrT8ZdJyPAXa4YIT/IuCIi6q0n3TioREoOa4ob5EQpz3xpUcL2McFxBjS8KqxQbP52MxX4t4aU1LYkyj388jHDFqYQ5ZFPL9R5cyEb4ztqPSiqXX96K+Q4ESak0bMsKAGzU2J+1TvfRR6N4s= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111624+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1700697016479523.4212316731453; Wed, 22 Nov 2023 15:50:16 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=XEhDyreZlv3qQk0I3MUzQMZLoHa9fg/2xZ03bx41wWE=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1700697016; v=1; b=PBtIiHrdfg2U9Wk+uMV/0X1g5zFfnPlemwhxOVbzxaygzrRB+0WCgZ+nvyxEeoyDWpUhnyEv KjvRYdhkeMGdHXQRtrH9dASzJMo68K8Srgug6vJ3bkJvlyYKjNpTuDqemQ1vRDyZvPMs261BxSS fZftosn8la9kTnFOqTgbK2S8= X-Received: by 127.0.0.2 with SMTP id BfUyYY1788612xzJHdoXh6hX; Wed, 22 Nov 2023 15:50:16 -0800 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web11.79331.1700697015339948771 for ; Wed, 22 Nov 2023 15:50:15 -0800 X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2c50cf61f6dso3940041fa.2 for ; Wed, 22 Nov 2023 15:50:15 -0800 (PST) X-Gm-Message-State: NcNbawzW3UZwG4HqETb1vaWZx1787277AA= X-Google-Smtp-Source: AGHT+IFh5uboXkZzDNTmkSYtlGhgWADtvQOHbAZLOe2uznDk9dhyA9to3uLH3395jl837NfSY1OXKg== X-Received: by 2002:a2e:9f47:0:b0:2c5:130c:d41e with SMTP id v7-20020a2e9f47000000b002c5130cd41emr2893076ljk.29.1700697013347; Wed, 22 Nov 2023 15:50:13 -0800 (PST) X-Received: from localhost.localdomain ([79.164.221.98]) by smtp.gmail.com with ESMTPSA id 16-20020a2e1450000000b002c8872c9d53sm13095lju.8.2023.11.22.15.50.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 22 Nov 2023 15:50:13 -0800 (PST) From: "Mike Maslenkin" To: devel@edk2.groups.io Cc: abner.chang@amd.com, nicklew@nvidia.com, igork@ami.com Subject: [edk2-devel] [PATCH 1/3] RedfishPkg: fix memory leak in HiiUtilityLib Date: Thu, 23 Nov 2023 02:50:06 +0300 Message-Id: <20231122235008.31001-2-mike.maslenkin@gmail.com> In-Reply-To: <20231122235008.31001-1-mike.maslenkin@gmail.com> References: <20231122235008.31001-1-mike.maslenkin@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mike.maslenkin@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1700697017872100006 Content-Type: text/plain; charset="utf-8" Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c b/RedfishPkg/= Library/HiiUtilityLib/HiiUtilityLib.c index 168b4459844f..fd322c2086d8 100644 --- a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c +++ b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c @@ -388,11 +388,13 @@ SetQuestionValue ( Question->Value.BufferLen =3D Question->StorageWidth; Question->Value.Buffer =3D AllocateZeroPool (Question->StorageWid= th); if (Question->Value.Buffer =3D=3D NULL) { + FreePool (TemString); return EFI_OUT_OF_RESOURCES; } =20 CopyMem (Question->Value.Buffer, TemString, StrSize (TemString)); Src =3D Question->Value.Buffer; + FreePool (TemString); } else { CopyMem (&Question->Value.Value, &QuestionValue->Value, sizeof (EFI_= IFR_TYPE_VALUE)); Src =3D (UINT8 *)&Question->Value.Value; --=20 2.32.0 (Apple Git-132)