From nobody Tue Feb 10 09:40:56 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+111065+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111065+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=quicinc.com ARC-Seal: i=1; a=rsa-sha256; t=1699644678; cv=none; d=zohomail.com; s=zohoarc; b=I++hlzDMB+o4UVPiHPW0Jd8RzOW/6nCAFJwOvGBb85Dl2guMABZ6h/K/3sBb7C9wi3Czdso5jSeTKuX9cFj0lkXHxY+aSxjhxmnbsuiKFsfsQ+UoCmrbuT4WsLIT4v7LOBtVeNe4NnYDngQVCmSpv0y6zD/2qEOyk/vcRfIu+8M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699644678; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=MH+7VsTUl8bOQ1krPVRqUyuirdAu62Gui73J2kFTDTY=; b=Ld1GTdWVUxm0xJkXQqSm2QlwrUFaH/40DKf2Bn0t6NkmEMcTOrxWmQSkbJN26UGtsd/3FeUnYDjCWrzu6SbM/EkCvEPzga9H2j9G3WpcypIclw9lqnnKg0q3pdqrjqD9iEHtcIa+k/XZNF6Tn91yH7g2SVS81Iuv4C71rjL4fWk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111065+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1699644678094903.2779271355469; Fri, 10 Nov 2023 11:31:18 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=X9/zsKXGppbasQ17vn/7tnWuVzBQsA3R2TKmfyPYUS4=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1699644677; v=1; b=RvgpKf6q9cbLlBFG3a9Si9s2AfNqyIf4ZzayeyWhn4Ki5nxYzn4cQN/GXmSZGC6BcFi04Wl3 6KdG9INuEY+0PTumqIyREpkAUDxJUdZ4l/dH80EoPAIh09wl9T7Jc3o9tcCJ1B0RBnB5e8U4YMc 7JbfgO5JNGWpiU8E1ocCYkN4= X-Received: by 127.0.0.2 with SMTP id xvrUYY1788612x7E6r3KZJvP; Fri, 10 Nov 2023 11:31:17 -0800 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.37039.1699644677268060426 for ; Fri, 10 Nov 2023 11:31:17 -0800 X-Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AAHSbDN032404; Fri, 10 Nov 2023 19:31:09 GMT X-Received: from nasanppmta05.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3u9dx1hw1b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Nov 2023 19:31:08 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 3AAJV8Id008360 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 10 Nov 2023 19:31:08 GMT X-Received: from qc-i7.qualcomm.com (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.39; Fri, 10 Nov 2023 11:31:06 -0800 From: "Leif Lindholm" To: CC: Michael D Kinney , Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen Subject: [edk2-devel] [PATCH v3 2/5] BaseTools/Scripts/GetMaintainer: Simplify logic Date: Fri, 10 Nov 2023 19:30:50 +0000 Message-ID: <20231110193053.673595-3-quic_llindhol@quicinc.com> In-Reply-To: <20231110193053.673595-1-quic_llindhol@quicinc.com> References: <20231110193053.673595-1-quic_llindhol@quicinc.com> MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: ci_ZVnpjp3uT5aNK6-2pxUDhVppmI4Pf X-Proofpoint-GUID: ci_ZVnpjp3uT5aNK6-2pxUDhVppmI4Pf Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: IXwkwudrGqgkYcW4zV7355z7x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1699644679461100007 Content-Type: text/plain; charset="utf-8" From: Michael D Kinney REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4593 get_section_maintainers() either returns a list with valid entries or an empty list. It never returns None. Simplify logic that accumulates maintainers and lists by unconditionally appending lists returned from get_section_maintainers(). Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- BaseTools/Scripts/GetMaintainer.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMain= tainer.py index 2a3147c059b5..cdcdff750635 100644 --- a/BaseTools/Scripts/GetMaintainer.py +++ b/BaseTools/Scripts/GetMaintainer.py @@ -105,10 +105,8 @@ def get_maintainers(path, sections, level=3D0): lists =3D [] for section in sections: tmp_maint, tmp_lists =3D get_section_maintainers(path, section) - if tmp_maint: - maintainers +=3D tmp_maint - if tmp_lists: - lists +=3D tmp_lists + maintainers +=3D tmp_maint + lists +=3D tmp_lists =20 if not maintainers: # If no match found, look for match for (nonexistent) file --=20 2.39.2 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111065): https://edk2.groups.io/g/devel/message/111065 Mute This Topic: https://groups.io/mt/102513768/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-