From nobody Mon Feb 9 00:01:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+111044+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111044+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1699635852; cv=none; d=zohomail.com; s=zohoarc; b=ZY7793VJ3TZGQOAH2uoD6VInLPQqZSFq0lw4PTNNp9QMaxy/TOoeouFKUHXQtUaG4zwzq0j75B6xR7tRfM085Fj98H7JPKs6l4z7tOREkodcYvhYTISF2Cwm+bg037fWj5t5vtmecpEMK1Rc//QAYKAKIGkiJ/JtIV04Wn3ieCI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699635852; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=KUZXww52DQVME64Qkwwit5JB97pZ6HU6s7tw77TkgZw=; b=JEPMmLelG7yefEdyPY83za2gis/p4yCC7Hsdre5hUWKRe3eWnTsEU8dc0DmgHodCtnVWRd1M43XvrUIyfv4KSzluAueblgVFVv+gEZs9klvlescSvuHyt9VuEUK3IsyWKTMTPcee37GevINNW/6ybkoSJH6kAjQVxnYzmSiliNc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+111044+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 169963585244137.62760309845544; Fri, 10 Nov 2023 09:04:12 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=8qYBRFNIBfiLhv5JrEeQmjJGAZflLLdktodVX/M4Q9s=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1699635851; v=1; b=YlTF7phij0tVfP6znEL8VuOQwouJ9bswPagOFMvr2rWdDksBrgCOq6uiYRQhm+Rj6c4RIGV1 VGMDCFPCR3IEjcuPsUv9B7VTOuiz/MhMBimGMvAZdBSB1/Em0ObeotEYKc6gi/ZRFyfiNStScM5 WmPEt506VOcsv2G4C4Om6Fac= X-Received: by 127.0.0.2 with SMTP id 1WnaYY1788612xp6YRcGlk8s; Fri, 10 Nov 2023 09:04:11 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by mx.groups.io with SMTP id smtpd.web11.33120.1699635848781681059 for ; Fri, 10 Nov 2023 09:04:09 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10890"; a="8858169" X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="8858169" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 09:04:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,291,1694761200"; d="scan'208";a="11525428" X-Received: from mdkinney-mobl.amr.corp.intel.com ([10.212.164.220]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2023 09:04:09 -0800 From: "Michael D Kinney" To: devel@edk2.groups.io Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen , Leif Lindholm Subject: [edk2-devel] [edk2-stable202311][Patch v2 3/4] BaseTools/Scripts/GetMaintainer: Simplify logic Date: Fri, 10 Nov 2023 09:04:02 -0800 Message-Id: <20231110170403.1068-4-michael.d.kinney@intel.com> In-Reply-To: <20231110170403.1068-1-michael.d.kinney@intel.com> References: <20231110170403.1068-1-michael.d.kinney@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,michael.d.kinney@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hKFNtPp8qBPznKR4hi516Vt1x1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1699635854099100012 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4593 get_section_maintainers() either returns a list with valid entries or an empty list. It never returns None. Simplify logic that accumulates maintainers, reviewers, and lists by unconditionally appending lists returned from get_section_maintainers(). Cc: Rebecca Cran Cc: Liming Gao Cc: Bob Feng Cc: Yuwei Chen Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- BaseTools/Scripts/GetMaintainer.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMain= tainer.py index 081460451e9b..a887962dd1bd 100644 --- a/BaseTools/Scripts/GetMaintainer.py +++ b/BaseTools/Scripts/GetMaintainer.py @@ -113,12 +113,9 @@ def get_maintainers(path, sections, level=3D0): lists =3D [] for section in sections: tmp_maint, tmp_review, tmp_lists =3D get_section_maintainers(path,= section) - if tmp_maint: - maintainers +=3D tmp_maint - if tmp_review: - reviewers +=3D tmp_review - if tmp_lists: - lists +=3D tmp_lists + maintainers +=3D tmp_maint + reviewers +=3D tmp_review + lists +=3D tmp_lists =20 if not maintainers: # If no match found, look for match for (nonexistent) file --=20 2.40.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111044): https://edk2.groups.io/g/devel/message/111044 Mute This Topic: https://groups.io/mt/102510791/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-