From nobody Tue May 14 10:03:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+110975+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110975+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699531597; cv=none; d=zohomail.com; s=zohoarc; b=Bix7eo/cgUVflT6sYstjgr9wWLbyIuXwU38z2AShLd44WdQ7dopXDdIfStUH6Ii72aqPrNu+EydwHCUgxkd8O2UQfFyITNbyNGzEw9AgMAbcHXBxhYk/pMQPHvBdDHkT8TEFXyjUBIcycEV/Vq5a7xmZ4wbwiv2zm+hoIZn22sM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699531597; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=8ytMqWq5VYFBOURjt3fYOuhd66crD8Cv7c7K9w//YmM=; b=ZLNhQ3jfLNm6MJ9qhT+681b3+Lj7UDyVYscsd5il5mbqVcS9bEvP3Q37EBDMTJUiYFSMuX/+qbcLakXWVSw0nAYGHiXOxJp0cyzVeHWLQmMrifjl1K0fakVLvX2Up9nFygEbNr52xC+notjNLtvJf9OPw8g1mxdnUbWGDzLxC9U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110975+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 169953159762854.44525760283602; Thu, 9 Nov 2023 04:06:37 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=8ytMqWq5VYFBOURjt3fYOuhd66crD8Cv7c7K9w//YmM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1699531597; v=1; b=jSxHSCngERU1SC0d9POG1O5k7yRCMFUtxPmZaKkC4hU8Jr7jr2MIEx8M57JlrIlJz03MH3s9 YiXz+PkHnuBohVzeR9QZUQ2RwddxKJD3sXggYJLyibpX3Lk9StROr3darrHPl5w1w3lNxXyfcX2 HCGHv7G7PLOZPaY8OXD2MvwU= X-Received: by 127.0.0.2 with SMTP id OTSDYY1788612xwDFS5Iu22i; Thu, 09 Nov 2023 04:06:37 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.119745.1699531596171264121 for ; Thu, 09 Nov 2023 04:06:36 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-249-98vle77rM8aC8cMpqSGu5w-1; Thu, 09 Nov 2023 07:06:32 -0500 X-MC-Unique: 98vle77rM8aC8cMpqSGu5w-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 05BB72801429; Thu, 9 Nov 2023 12:06:32 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 08A651121306; Thu, 9 Nov 2023 12:06:30 +0000 (UTC) From: "Laszlo Ersek" To: devel@edk2.groups.io Cc: Liming Gao , Michael D Kinney , Zhiguang Liu Subject: [edk2-devel] [PATCH 1/3] MdePkg: remove Date: Thu, 9 Nov 2023 13:06:26 +0100 Message-Id: <20231109120628.55913-2-lersek@redhat.com> In-Reply-To: <20231109120628.55913-1-lersek@redhat.com> References: <6f4604d0-c12e-f818-2de1-44e9b1f4dbc7@redhat.com> <20231109120628.55913-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: B1zbSTrvDoSBjuOCyfWF5Fcxx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1699531599584100014 Content-Type: text/plain; charset="utf-8"; x-default="true" Nothing in edk2 (or edk2-platforms, at this point) references "LegacyBiosMpTable.h", or the names it introduces (EFI_LEGACY_MP_TABLE_* and FEATUREBYTE2_5). Remove the header. Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1754 Signed-off-by: Laszlo Ersek --- MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h | 288 ----------------= ---- 1 file changed, 288 deletions(-) diff --git a/MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h b/MdePkg/I= nclude/IndustryStandard/LegacyBiosMpTable.h deleted file mode 100644 index fa57f1ca10ce..000000000000 --- a/MdePkg/Include/IndustryStandard/LegacyBiosMpTable.h +++ /dev/null @@ -1,288 +0,0 @@ -/** @file - Defives data structures per MultiProcessor Specification Ver 1.4. - - The MultiProcessor Specification defines an enhancement to the standard - to which PC manufacturers design DOS-compatible systems. - -Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved.
-SPDX-License-Identifier: BSD-2-Clause-Patent - -**/ - -#ifndef _LEGACY_BIOS_MPTABLE_H_ -#define _LEGACY_BIOS_MPTABLE_H_ - -#define EFI_LEGACY_MP_TABLE_REV_1_4 0x04 - -// -// Define MP table structures. All are packed. -// -#pragma pack(1) - -#define EFI_LEGACY_MP_TABLE_FLOATING_POINTER_SIGNATURE SIGNATURE_32 ('_',= 'M', 'P', '_') -typedef struct { - UINT32 Reserved1 : 6; - UINT32 MutipleClk : 1; - UINT32 Imcr : 1; - UINT32 Reserved2 : 24; -} FEATUREBYTE2_5; - -typedef struct { - UINT32 Signature; - UINT32 PhysicalAddress; - UINT8 Length; - UINT8 SpecRev; - UINT8 Checksum; - UINT8 FeatureByte1; - FEATUREBYTE2_5 FeatureByte2_5; -} EFI_LEGACY_MP_TABLE_FLOATING_POINTER; - -#define EFI_LEGACY_MP_TABLE_HEADER_SIGNATURE SIGNATURE_32 ('P', 'C', 'M',= 'P') -typedef struct { - UINT32 Signature; - UINT16 BaseTableLength; - UINT8 SpecRev; - UINT8 Checksum; - CHAR8 OemId[8]; - CHAR8 OemProductId[12]; - UINT32 OemTablePointer; - UINT16 OemTableSize; - UINT16 EntryCount; - UINT32 LocalApicAddress; - UINT16 ExtendedTableLength; - UINT8 ExtendedChecksum; - UINT8 Reserved; -} EFI_LEGACY_MP_TABLE_HEADER; - -typedef struct { - UINT8 EntryType; -} EFI_LEGACY_MP_TABLE_ENTRY_TYPE; - -// -// Entry Type 0: Processor. -// -#define EFI_LEGACY_MP_TABLE_ENTRY_TYPE_PROCESSOR 0x00 -typedef struct { - UINT8 Enabled : 1; - UINT8 Bsp : 1; - UINT8 Reserved : 6; -} EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_FLAGS; - -typedef struct { - UINT32 Stepping : 4; - UINT32 Model : 4; - UINT32 Family : 4; - UINT32 Reserved : 20; -} EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_SIGNATURE; - -typedef struct { - UINT32 Fpu : 1; - UINT32 Reserved1 : 6; - UINT32 Mce : 1; - UINT32 Cx8 : 1; - UINT32 Apic : 1; - UINT32 Reserved2 : 22; -} EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_FEATURES; - -typedef struct { - UINT8 EntryType; - UINT8 Id; - UINT8 Ver; - EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_FLAGS Flags; - EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_SIGNATURE Signature; - EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR_FEATURES Features; - UINT32 Reserved1; - UINT32 Reserved2; -} EFI_LEGACY_MP_TABLE_ENTRY_PROCESSOR; - -// -// Entry Type 1: Bus. -// -#define EFI_LEGACY_MP_TABLE_ENTRY_TYPE_BUS 0x01 -typedef struct { - UINT8 EntryType; - UINT8 Id; - CHAR8 TypeString[6]; -} EFI_LEGACY_MP_TABLE_ENTRY_BUS; - -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_CBUS "CBUS " // Corollary= CBus -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_CBUSII "CBUSII" // Corollary= CBUS II -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_EISA "EISA " // Extended = ISA -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_FUTURE "FUTURE" // IEEE Futu= reBus -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_INTERN "INTERN" // Internal = bus -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_ISA "ISA " // Industry = Standard Architecture -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_MBI "MBI " // Multibus I -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_MBII "MBII " // Multibus = II -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_MCA "MCA " // Micro Cha= nnel Architecture -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_MPI "MPI " // MPI -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_MPSA "MPSA " // MPSA -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_NUBUS "NUBUS " // Apple Mac= intosh NuBus -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_PCI "PCI " // Periphera= l Component Interconnect -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_PCMCIA "PCMCIA" // PC Memory= Card International Assoc. -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_TC "TC " // DEC Turbo= Channel -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_VL "VL " // VESA Loca= l Bus -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_VME "VME " // VMEbus -#define EFI_LEGACY_MP_TABLE_ENTRY_BUS_STRING_XPRESS "XPRESS" // Express S= ystem Bus -// -// Entry Type 2: I/O APIC. -// -#define EFI_LEGACY_MP_TABLE_ENTRY_TYPE_IOAPIC 0x02 -typedef struct { - UINT8 Enabled : 1; - UINT8 Reserved : 7; -} EFI_LEGACY_MP_TABLE_ENTRY_IOAPIC_FLAGS; - -typedef struct { - UINT8 EntryType; - UINT8 Id; - UINT8 Ver; - EFI_LEGACY_MP_TABLE_ENTRY_IOAPIC_FLAGS Flags; - UINT32 Address; -} EFI_LEGACY_MP_TABLE_ENTRY_IOAPIC; - -// -// Entry Type 3: I/O Interrupt Assignment. -// -#define EFI_LEGACY_MP_TABLE_ENTRY_TYPE_IO_INT 0x03 -typedef struct { - UINT16 Polarity : 2; - UINT16 Trigger : 2; - UINT16 Reserved : 12; -} EFI_LEGACY_MP_TABLE_ENTRY_INT_FLAGS; - -typedef struct { - UINT8 IntNo : 2; - UINT8 Dev : 5; - UINT8 Reserved : 1; -} EFI_LEGACY_MP_TABLE_ENTRY_INT_FIELDS; - -typedef union { - EFI_LEGACY_MP_TABLE_ENTRY_INT_FIELDS fields; - UINT8 byte; -} EFI_LEGACY_MP_TABLE_ENTRY_INT_SOURCE_BUS_IRQ; - -typedef struct { - UINT8 EntryType; - UINT8 IntType; - EFI_LEGACY_MP_TABLE_ENTRY_INT_FLAGS Flags; - UINT8 SourceBusId; - EFI_LEGACY_MP_TABLE_ENTRY_INT_SOURCE_BUS_IRQ SourceBusIrq; - UINT8 DestApicId; - UINT8 DestApicIntIn; -} EFI_LEGACY_MP_TABLE_ENTRY_IO_INT; - -typedef enum { - EfiLegacyMpTableEntryIoIntTypeInt =3D 0, - EfiLegacyMpTableEntryIoIntTypeNmi =3D 1, - EfiLegacyMpTableEntryIoIntTypeSmi =3D 2, - EfiLegacyMpTableEntryIoIntTypeExtInt =3D 3, -} EFI_LEGACY_MP_TABLE_ENTRY_IO_INT_TYPE; - -typedef enum { - EfiLegacyMpTableEntryIoIntFlagsPolaritySpec =3D 0x0, - EfiLegacyMpTableEntryIoIntFlagsPolarityActiveHigh =3D 0x1, - EfiLegacyMpTableEntryIoIntFlagsPolarityReserved =3D 0x2, - EfiLegacyMpTableEntryIoIntFlagsPolarityActiveLow =3D 0x3, -} EFI_LEGACY_MP_TABLE_ENTRY_IO_INT_FLAGS_POLARITY; - -typedef enum { - EfiLegacyMpTableEntryIoIntFlagsTriggerSpec =3D 0x0, - EfiLegacyMpTableEntryIoIntFlagsTriggerEdge =3D 0x1, - EfiLegacyMpTableEntryIoIntFlagsTriggerReserved =3D 0x2, - EfiLegacyMpTableEntryIoIntFlagsTriggerLevel =3D 0x3, -} EFI_LEGACY_MP_TABLE_ENTRY_IO_INT_FLAGS_TRIGGER; - -// -// Entry Type 4: Local Interrupt Assignment. -// -#define EFI_LEGACY_MP_TABLE_ENTRY_TYPE_LOCAL_INT 0x04 -typedef struct { - UINT8 EntryType; - UINT8 IntType; - EFI_LEGACY_MP_TABLE_ENTRY_INT_FLAGS Flags; - UINT8 SourceBusId; - EFI_LEGACY_MP_TABLE_ENTRY_INT_SOURCE_BUS_IRQ SourceBusIrq; - UINT8 DestApicId; - UINT8 DestApicIntIn; -} EFI_LEGACY_MP_TABLE_ENTRY_LOCAL_INT; - -typedef enum { - EfiLegacyMpTableEntryLocalIntTypeInt =3D 0, - EfiLegacyMpTableEntryLocalIntTypeNmi =3D 1, - EfiLegacyMpTableEntryLocalIntTypeSmi =3D 2, - EfiLegacyMpTableEntryLocalIntTypeExtInt =3D 3, -} EFI_LEGACY_MP_TABLE_ENTRY_LOCAL_INT_TYPE; - -typedef enum { - EfiLegacyMpTableEntryLocalIntFlagsPolaritySpec =3D 0x0, - EfiLegacyMpTableEntryLocalIntFlagsPolarityActiveHigh =3D 0x1, - EfiLegacyMpTableEntryLocalIntFlagsPolarityReserved =3D 0x2, - EfiLegacyMpTableEntryLocalIntFlagsPolarityActiveLow =3D 0x3, -} EFI_LEGACY_MP_TABLE_ENTRY_LOCAL_INT_FLAGS_POLARITY; - -typedef enum { - EfiLegacyMpTableEntryLocalIntFlagsTriggerSpec =3D 0x0, - EfiLegacyMpTableEntryLocalIntFlagsTriggerEdge =3D 0x1, - EfiLegacyMpTableEntryLocalIntFlagsTriggerReserved =3D 0x2, - EfiLegacyMpTableEntryLocalIntFlagsTriggerLevel =3D 0x3, -} EFI_LEGACY_MP_TABLE_ENTRY_LOCAL_INT_FLAGS_TRIGGER; - -// -// Entry Type 128: System Address Space Mapping. -// -#define EFI_LEGACY_MP_TABLE_ENTRY_EXT_TYPE_SYS_ADDR_SPACE_MAPPING 0x80 -typedef struct { - UINT8 EntryType; - UINT8 Length; - UINT8 BusId; - UINT8 AddressType; - UINT64 AddressBase; - UINT64 AddressLength; -} EFI_LEGACY_MP_TABLE_ENTRY_EXT_SYS_ADDR_SPACE_MAPPING; - -typedef enum { - EfiLegacyMpTableEntryExtSysAddrSpaceMappingIo =3D 0, - EfiLegacyMpTableEntryExtSysAddrSpaceMappingMemory =3D 1, - EfiLegacyMpTableEntryExtSysAddrSpaceMappingPrefetch =3D 2, -} EFI_LEGACY_MP_TABLE_ENTRY_EXT_SYS_ADDR_SPACE_MAPPING_TYPE; - -// -// Entry Type 129: Bus Hierarchy. -// -#define EFI_LEGACY_MP_TABLE_ENTRY_EXT_TYPE_BUS_HIERARCHY 0x81 -typedef struct { - UINT8 SubtractiveDecode : 1; - UINT8 Reserved : 7; -} EFI_LEGACY_MP_TABLE_ENTRY_EXT_BUS_HIERARCHY_BUSINFO; - -typedef struct { - UINT8 EntryType; - UINT8 Length; - UINT8 BusId; - EFI_LEGACY_MP_TABLE_ENTRY_EXT_BUS_HIERARCHY_BUSINFO BusInfo; - UINT8 ParentBus; - UINT8 Reserved1; - UINT8 Reserved2; - UINT8 Reserved3; -} EFI_LEGACY_MP_TABLE_ENTRY_EXT_BUS_HIERARCHY; - -// -// Entry Type 130: Compatibility Bus Address Space Modifier. -// -#define EFI_LEGACY_MP_TABLE_ENTRY_EXT_TYPE_COMPAT_BUS_ADDR_SPACE_MODIFIER = 0x82 -typedef struct { - UINT8 RangeMode : 1; - UINT8 Reserved : 7; -} EFI_LEGACY_MP_TABLE_ENTRY_EXT_COMPAT_BUS_ADDR_SPACE_MODIFIER_ADDR_MODE; - -typedef struct { - UINT8 = EntryType; - UINT8 = Length; - UINT8 = BusId; - EFI_LEGACY_MP_TABLE_ENTRY_EXT_COMPAT_BUS_ADDR_SPACE_MODIFIER_ADDR_MODE = AddrMode; - UINT32 = PredefinedRangeList; -} EFI_LEGACY_MP_TABLE_ENTRY_EXT_COMPAT_BUS_ADDR_SPACE_MODIFIER; - -#pragma pack() - -#endif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110975): https://edk2.groups.io/g/devel/message/110975 Mute This Topic: https://groups.io/mt/102483866/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 14 10:03:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+110974+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110974+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699531597; cv=none; d=zohomail.com; s=zohoarc; b=MswATYsIIs+ITNLf5M/aX70SBDIOOBfl+XqnPXFyWYknTNt71k3Q4iOsiMW2lD3EVA8bM+X7rlIyRyncAgNkv1v3IH03CbUOkK+xaxEjyoHtKTYo6229CcAVC+At7umaaDzORcSALIcfAUnNLP5yv1W+cgUXQo+wi4EuBtgo/l4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699531597; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=WkqyPrGBrUZm6urkvzgnw1Lz8rkjTVcdlpZquH1bZck=; b=Trgj76BVhvARINmJHv+WHEh9UgtTyE+v5y2pi3I+BVbpxRUOYQ+ACJifcTs0I+/QSfTsNaobqrX9lhZ88IQCAZD86Us/SYVvN/bBsRRUWbnJS15x0WgLHER8tdgghjAQ+kUf1IzizhAh5tNt+9OoSYLnVeBdtrm7csM5QrxXw+E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110974+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1699531597219838.9701779743206; Thu, 9 Nov 2023 04:06:37 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=WkqyPrGBrUZm6urkvzgnw1Lz8rkjTVcdlpZquH1bZck=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1699531596; v=1; b=k80ECA8+f7DocfkXIB0Mv7HkSWAYzL8DXtaOHId8+83mev0whCpaaahpJsnKANJ8SLhPKtYG DnigPwXYPpPkY3ZGFDyM0SvqexRnCIYrw0hPSy+bmxwY8QL6t3VX8sMrp+9lmvroKZ0NGJW+Dl/ j4Mf6GxeBczYHJ4K4GY7KBP0= X-Received: by 127.0.0.2 with SMTP id J5gOYY1788612xD6eakEg8FV; Thu, 09 Nov 2023 04:06:36 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.119743.1699531595895009964 for ; Thu, 09 Nov 2023 04:06:36 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-648-NFNP_ZfYMSG-A42Mj4lyoQ-1; Thu, 09 Nov 2023 07:06:33 -0500 X-MC-Unique: NFNP_ZfYMSG-A42Mj4lyoQ-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D39F4185A783; Thu, 9 Nov 2023 12:06:32 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 46CDE1121306; Thu, 9 Nov 2023 12:06:32 +0000 (UTC) From: "Laszlo Ersek" To: devel@edk2.groups.io Cc: Zhichao Gao Subject: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellDebug1CommandsLib: remove gEfiMpsTableGuid ref from DMEM Date: Thu, 9 Nov 2023 13:06:27 +0100 Message-Id: <20231109120628.55913-3-lersek@redhat.com> In-Reply-To: <20231109120628.55913-1-lersek@redhat.com> References: <6f4604d0-c12e-f818-2de1-44e9b1f4dbc7@redhat.com> <20231109120628.55913-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4HVcwWlhw9AcBUDlosd62SlIx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1699531597549100004 Content-Type: text/plain; charset="utf-8"; x-default="true" We're removing . First, remove the gEfiMpsTableGuid system config table reference from the UEFI Shell's DMEM debug command. Cc: Zhichao Gao Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1754 Signed-off-by: Laszlo Ersek --- ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.uni= | 1 - ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLib.inf= | 1 - ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c = | 9 --------- 3 files changed, 11 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Com= mandsLib.uni b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1C= ommandsLib.uni index 4041f0cd483e..155efc1a82f1 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi= b.uni +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi= b.uni @@ -112,7 +112,6 @@ "SAL System Table = %016LX\r\n" "ACPI Table = %016LX\r\n" "ACPI 2.0 Table = %016LX\r\n" - "MPS Table = %016LX\r\n" "SMBIOS Table = %016LX\r\n" "DTB Table = %016LX\r\n" "Memory Attribute Table = %016LX\r\n" diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Com= mandsLib.inf b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1C= ommandsLib.inf index 3741dac5d94c..2074cb7d96da 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi= b.inf +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1CommandsLi= b.inf @@ -127,7 +127,6 @@ [Guids] gEfiGlobalVariableGuid ## SOMETIMES_CONSUMES ## GUID gEfiSmbiosTableGuid ## SOMETIMES_CONSUMES ## SystemTable gEfiSmbios3TableGuid ## SOMETIMES_CONSUMES ## SystemTable - gEfiMpsTableGuid ## SOMETIMES_CONSUMES ## SystemTable gEfiAcpi10TableGuid ## SOMETIMES_CONSUMES ## SystemTable gEfiAcpi20TableGuid ## SOMETIMES_CONSUMES ## SystemTable gShellDebug1HiiGuid ## SOMETIMES_CONSUMES ## HII diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c b/ShellPkg/= Library/UefiShellDebug1CommandsLib/Dmem.c index a609971f345e..39a59c195512 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Dmem.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include #include @@ -113,7 +112,6 @@ ShellCommandRunDmem ( UINT64 Acpi20TableAddress; UINT64 SalTableAddress; UINT64 SmbiosTableAddress; - UINT64 MpsTableAddress; UINT64 DtbTableAddress; UINT64 MemoryAttributesTableAddress; UINT64 RtPropertiesTableAddress; @@ -190,7 +188,6 @@ ShellCommandRunDmem ( AcpiTableAddress =3D 0; SalTableAddress =3D 0; SmbiosTableAddress =3D 0; - MpsTableAddress =3D 0; DtbTableAddress =3D 0; MemoryAttributesTableAddress =3D 0; RtPropertiesTableAddress =3D 0; @@ -224,11 +221,6 @@ ShellCommandRunDmem ( continue; } =20 - if (CompareGuid (&gST->ConfigurationTable[TableWalker].VendorG= uid, &gEfiMpsTableGuid)) { - MpsTableAddress =3D (UINT64)(UINTN)gST->ConfigurationTable[T= ableWalker].VendorTable; - continue; - } - if (CompareGuid (&gST->ConfigurationTable[TableWalker].VendorG= uid, &gEfiMemoryAttributesTableGuid)) { MemoryAttributesTableAddress =3D (UINT64)(UINTN)gST->Configu= rationTable[TableWalker].VendorTable; continue; @@ -292,7 +284,6 @@ ShellCommandRunDmem ( SalTableAddress, AcpiTableAddress, Acpi20TableAddress, - MpsTableAddress, SmbiosTableAddress, DtbTableAddress, MemoryAttributesTableAddress, -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110974): https://edk2.groups.io/g/devel/message/110974 Mute This Topic: https://groups.io/mt/102483865/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- From nobody Tue May 14 10:03:26 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+110976+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110976+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1699531598; cv=none; d=zohomail.com; s=zohoarc; b=Ixrhd5DIH7jb+/PRQSexJqH7eicHGQ2nKvH4nGppEiUFayoXsQag8bFgANGERBV/i+MOJmGLsFq/m3+192Sn9M2G5cmtrl2rhmmOaBWvH377SwTSZhUPMOHsqQoUVDeIzVL7Y0FeLW26kyZX2NGsAcP3cVYw+1ayNla0zSkw17I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1699531598; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=j9LCoSnsJTUgDYXD/aM5Rk4irEkocGEal3Ig6eF5xd0=; b=A+lbrQPQGQsF0TzBxbxbGmmloPWX/zrM3RnLFRVIuSvtv9L6zFJhJxNYMwtqcOh7Nlp3RJ4P/7ZWFn+L1xZPHuOzh6OZTLM9tSBjYBN9RctYm79hv/44RxePq8OzVqlvGLbbFL0H1EByF4EBphM+gBAOczfyfSD0nv2hEy++GBo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110976+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1699531598002200.29670183666326; Thu, 9 Nov 2023 04:06:38 -0800 (PST) Return-Path: DKIM-Signature: a=rsa-sha256; bh=j9LCoSnsJTUgDYXD/aM5Rk4irEkocGEal3Ig6eF5xd0=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1699531597; v=1; b=o2hRQlcNt+TeJVaHMr8VKkIuEIbeBkuvPH5SOGLsQC340LB8sKmvKoYeDnhrfs8EmBGcgMvf 3efSOdnXVrLY5zFhVcwEw2Vyq5++mTt7KbSnI+dfb+INe1Je3lEZbwskmokOg5hzOxCV4iJCc7q 46HDONNKw5MO09xPabp2vVc0= X-Received: by 127.0.0.2 with SMTP id panWYY1788612xvcc9p5XmaE; Thu, 09 Nov 2023 04:06:37 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.119746.1699531596526432914 for ; Thu, 09 Nov 2023 04:06:36 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-135-5jdOc91tPmyTDJJCzfE_cA-1; Thu, 09 Nov 2023 07:06:34 -0500 X-MC-Unique: 5jdOc91tPmyTDJJCzfE_cA-1 X-Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id F15063806739; Thu, 9 Nov 2023 12:06:33 +0000 (UTC) X-Received: from lacos-laptop-9.usersys.redhat.com (unknown [10.39.192.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1FE721121306; Thu, 9 Nov 2023 12:06:32 +0000 (UTC) From: "Laszlo Ersek" To: devel@edk2.groups.io Cc: Liming Gao , Michael D Kinney , Zhiguang Liu Subject: [edk2-devel] [PATCH 3/3] MdePkg: remove Date: Thu, 9 Nov 2023 13:06:28 +0100 Message-Id: <20231109120628.55913-4-lersek@redhat.com> In-Reply-To: <20231109120628.55913-1-lersek@redhat.com> References: <6f4604d0-c12e-f818-2de1-44e9b1f4dbc7@redhat.com> <20231109120628.55913-1-lersek@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fOHSfK5mCx3mCyEyNYv3U8eAx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1699531599540100013 Content-Type: text/plain; charset="utf-8"; x-default="true" The MPS table is legacy from the traditional BIOS era. According to the file-top comment in the header, it was only included in UEFI (and so in edk2) for Itanium's sake (and Itanium is also gone from edk2). Remove the header, and the MPS table GUID definition. There are no references left in edk2 or edk2-platforms. Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1754 Signed-off-by: Laszlo Ersek --- MdePkg/MdePkg.dec | 3 -- MdePkg/Include/Guid/Mps.h | 29 -------------------- 2 files changed, 32 deletions(-) diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec index ac54338089e8..bac96ffd9896 100644 --- a/MdePkg/MdePkg.dec +++ b/MdePkg/MdePkg.dec @@ -388,9 +388,6 @@ [Guids] ## Include/Guid/SmBios.h gEfiSmbiosTableGuid =3D { 0xEB9D2D31, 0x2D88, 0x11D3, { 0x9A,= 0x16, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }} =20 - ## Include/Guid/Mps.h - gEfiMpsTableGuid =3D { 0xEB9D2D2F, 0x2D88, 0x11D3, { 0x9A,= 0x16, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D }} - ## Include/Protocol/AuthenticationInfo.h gEfiAuthenticationChapLocalGuid =3D { 0xC280C73E, 0x15CA, 0x11DA, { 0xB0= , 0xCA, 0x00, 0x10, 0x83, 0xFF, 0xCA, 0x4D }} =20 diff --git a/MdePkg/Include/Guid/Mps.h b/MdePkg/Include/Guid/Mps.h deleted file mode 100644 index 0edcdbf2b9e8..000000000000 --- a/MdePkg/Include/Guid/Mps.h +++ /dev/null @@ -1,29 +0,0 @@ -/** @file - GUIDs used for MPS entries in the UEFI 2.0 system table - ACPI is the primary means of exporting MPS information to the OS. MPS on= ly was - included to support Itanium-based platform power on. So don't use it if = you don't have too. - - Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.
- SPDX-License-Identifier: BSD-2-Clause-Patent - - @par Revision Reference: - GUIDs defined in UEFI 2.0 spec. - -**/ - -#ifndef __MPS_GUID_H__ -#define __MPS_GUID_H__ - -#define EFI_MPS_TABLE_GUID \ - { \ - 0xeb9d2d2f, 0x2d88, 0x11d3, {0x9a, 0x16, 0x0, 0x90, 0x27, 0x3f, 0xc1, = 0x4d } \ - } - -// -// GUID name defined in spec. -// -#define MPS_TABLE_GUID EFI_MPS_TABLE_GUID - -extern EFI_GUID gEfiMpsTableGuid; - -#endif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110976): https://edk2.groups.io/g/devel/message/110976 Mute This Topic: https://groups.io/mt/102483867/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/3901457/1787277/102458076= /xyzzy [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-