From nobody Wed May 15 22:00:51 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+110106+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110106+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1698329849; cv=none; d=zohomail.com; s=zohoarc; b=H+p6/2cpSu8KqIba/gID3GtuGv+p1V2yF3RjE72pWT60z5UJT4f1hcRBsTo34kc2ER29r4w2TpqtNumk3NwAE+10IzERTZRWwg6XKjcD95JU0s/XuSJGYx0DKeSivl9Ja3JoUPWsJ0VXhYCXj//E/Xvd2zpi409lHHR6aAuH3Cc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698329849; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=JxScztIPFErjyBqBo1TzxgZNEnmf5cY/nsS2ZguFm/c=; b=mO9ghs6wGxysb1FYx2Z/MWgyhqjUY8agpOvT6rPrSPDJ7TWCAGTvBSBas5sBnDlnfvrtn97HbHWozBktOJf7VsNOvc3LjFOOQGqFpBhB9858ZzbpgLHTOWzQFNGsmzNumt5gCIOvU/OFQE0i//YPJg31eEWdCXIHPPt4XRcdqzA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+110106+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1698329849308899.6452921066867; Thu, 26 Oct 2023 07:17:29 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=HqkDJpKcahp/y8LwML5p/AMe0J1jLAAvW/UR6/Iv+Hw=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698329848; v=1; b=kKRlMEHtnYABTHg0B+4McbnZReHmRA7JAm25T8wf9qIL7EJjfcX7jFmVN2UuRPsnkTeEyvKX ozOw0cm6AE/oy8ful/3L9IGz+woJXNG6942zalauPw/mklkCF1QW6HpSztRiaHCCZs3ZaJBygGl GG7cWvsu9F6m5rTCbr6FjOsc= X-Received: by 127.0.0.2 with SMTP id MOFKYY1788612xtnvt0022Kg; Thu, 26 Oct 2023 07:17:28 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.201460.1698329846500057640 for ; Thu, 26 Oct 2023 07:17:28 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="372607291" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="372607291" X-Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 07:17:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10875"; a="794225084" X-IronPort-AV: E=Sophos;i="6.03,253,1694761200"; d="scan'208";a="794225084" X-Received: from njayapra-mobl.gar.corp.intel.com ([10.213.103.39]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Oct 2023 07:17:26 -0700 From: "Jayaprakash, N" To: devel@edk2.groups.io Cc: Jayaprakash N , Rebecca Cran , Michael D Kinney , Kloper Dimitry Subject: [edk2-devel] [edk2-libc Patch 1/1] ek2-libc: realpath function signature doesn't match the standard Date: Thu, 26 Oct 2023 19:47:16 +0530 Message-Id: <20231026141716.823-2-n.jayaprakash@intel.com> In-Reply-To: <20231026141716.823-1-n.jayaprakash@intel.com> References: <20231026141716.823-1-n.jayaprakash@intel.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,n.jayaprakash@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: EaH6CJvERzqGYSU3CWXyrMwYx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698329850919100005 Content-Type: text/plain; charset="utf-8" REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4574 This commit is for processing the below PR on edk2-libc repo https://github.com/tianocore/edk2-libc/pull/10 The realpath function signature in stdlib of edk2-libc doesn't match signature as per the standard definition of this function given below https://pubs.opengroup.org/onlinepubs/009695399/functions/realpath.html This patch extracted from the above pull request fixes this issue. Cc: Rebecca Cran Cc: Michael D Kinney Cc: Jayaprakash N Signed-off-by: Kloper Dimitry Reviewed-by: Jayaprakash Nevara Reviewed-by: Laszlo Ersek --- StdLib/Include/stdlib.h | 4 ++-- StdLib/LibC/StdLib/realpath.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/StdLib/Include/stdlib.h b/StdLib/Include/stdlib.h index 0b9dfd3..022ddbd 100644 --- a/StdLib/Include/stdlib.h +++ b/StdLib/Include/stdlib.h @@ -74,7 +74,7 @@ const wchar_t * __restrict src, size_t limit); =20 ################ Miscelaneous functions for *nix compatibility - char *realpath (char *file_name, char *resolved_name); + char *realpath (const char *file_name, char *resolved_name); const char *getprogname (void); void setprogname (const char *progname); =20 @@ -875,7 +875,7 @@ size_t wcstombs(char * __restrict Dest, const wchar_t = * __restrict Src, size_t @retval NULL An error occured. @retval resolved_name. **/ -char * realpath(char *file_name, char *resolved_name); +char * realpath(const char *file_name, char *resolved_name); =20 /** The getprogname() function returns the name of the program. If the na= me has not been set yet, it will return NULL. diff --git a/StdLib/LibC/StdLib/realpath.c b/StdLib/LibC/StdLib/realpath.c index 3d4118d..29abe9a 100644 --- a/StdLib/LibC/StdLib/realpath.c +++ b/StdLib/LibC/StdLib/realpath.c @@ -34,7 +34,7 @@ **/ char * realpath( - char *file_name, + const char *file_name, char *resolved_name ) { --=20 2.40.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110106): https://edk2.groups.io/g/devel/message/110106 Mute This Topic: https://groups.io/mt/102200532/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-