From nobody Mon Feb 9 07:05:38 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109916+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109916+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1698066327; cv=none; d=zohomail.com; s=zohoarc; b=leVN0rFggwDG4zOXBUm4cA8fUaO2Lt6LomNCA2MajLuJY9K0O+eQrbk47k48s+hLnKe09cG/K6HI5eSloJQOODBeObX/kL9YcgJxLJHDkfS6pJjetZmz6xiWJPYw+mtdciD3PRdG/YwJafcdJkuXOU+elZCzcQvjWh6+AglEXGM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698066327; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=SoxQyMjLtKiz2Kkdc/KCFJ/KrBneG8CDCojxdwFOk6Q=; b=CIdjeADqoUf+ikOH/M6OfiuEV4epRzEO3vc1MS4w/GyL3c857dh56Fa01oYnjEF4ybA0dCSTA+Lz6Uhr/Iq1H1ipbZOm2bVk7nADMsW7hKyAIUmQpZdGeimmE6/84ZR6BpnYdD6uz82cBLAN2BtcxS7Urrmk0Y/vcFQgf+LBIvw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109916+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1698066327031438.0859771150218; Mon, 23 Oct 2023 06:05:27 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=3NJdXTAw2fh8SsvHpQgn6hzfB4kUTfccYIzD466GhKM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698066325; v=1; b=wM2nj4YoNzKjGWBOuCTztuO0LVNB2AEAyXKxDAEe68he8tFOpEENzOS7d6Jh3pwioovuEDwV AQR0Qz+7n1jUn19+en0GzY/0HuOJx4zPO1FH4MnSfG/H/8Uoalsd3f5LYEtkAJy4fq6sgz1pPCs L0NuMbxv321WriL82UmU9EAc= X-Received: by 127.0.0.2 with SMTP id k21zYY1788612xFUpHN9oI7q; Mon, 23 Oct 2023 06:05:25 -0700 X-Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by mx.groups.io with SMTP id smtpd.web11.120287.1698066323806373312 for ; Mon, 23 Oct 2023 06:05:24 -0700 X-Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2c51388ccebso48332221fa.3 for ; Mon, 23 Oct 2023 06:05:23 -0700 (PDT) X-Gm-Message-State: BTqlDYReSbytuysDPdoW12Vnx1787277AA= X-Google-Smtp-Source: AGHT+IEZH1E+Oq/uw83/t1vS49ccI8EpB9pLwC74ZurpW2eK2LSBLXZ7ZHbbnIh27PWoEhhstyuOKQ== X-Received: by 2002:a2e:b042:0:b0:2c0:1c32:b4df with SMTP id d2-20020a2eb042000000b002c01c32b4dfmr5769756ljl.15.1698066321706; Mon, 23 Oct 2023 06:05:21 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id r11-20020a2e994b000000b002b9e0d19644sm1550081ljj.106.2023.10.23.06.05.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 06:05:21 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms v3 08/16] ManageabilityPkg: Don't check MCTP header fields if transfer has failed Date: Mon, 23 Oct 2023 16:05:03 +0300 Message-Id: <20231023130511.4521-9-aladyshev22@gmail.com> In-Reply-To: <20231023130511.4521-1-aladyshev22@gmail.com> References: <20231023130511.4521-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698066328817100043 Content-Type: text/plain; charset="utf-8" If MCTP KCS communication has failed we need to abort MCTP transfer function before checking any MCTP header data. Signed-off-by: Konstantin Aladyshev --- .../MctpProtocol/Common/MctpProtocolCommon.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/Mc= tpProtocolCommon.c index 3128aadd15..4aae4fcba9 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c @@ -461,6 +461,13 @@ CommonMctpSubmitMessage ( &TransferToken ); =20 + *AdditionalTransferError =3D TransferToken.TransportAdditionalStatus; + Status =3D TransferToken.TransferStatus; + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "%a: Failed to send MCTP command over %s: %r\n", = __func__, mTransportName, Status)); + return Status; + } + MctpTransportResponseHeader =3D (MCTP_TRANSPORT_HEADER *)ResponseBuffer; if (MctpTransportResponseHeader->Bits.HeaderVersion !=3D MCTP_KCS_HEADER= _VERSION) { DEBUG (( @@ -543,18 +550,9 @@ CommonMctpSubmitMessage ( return EFI_DEVICE_ERROR; } =20 - // - // Return transfer status. - // - *AdditionalTransferError =3D TransferToken.TransportAdditionalStatus; *ResponseDataSize =3D TransferToken.ReceivePackage.ReceiveSizeInB= yte - sizeof (MCTP_TRANSPORT_HEADER) - sizeof (MCTP_MESSAGE_HEADER); CopyMem (ResponseData, ResponseBuffer + sizeof (MCTP_TRANSPORT_HEADER) += sizeof (MCTP_MESSAGE_HEADER), *ResponseDataSize); FreePool (ResponseBuffer); - Status =3D TransferToken.TransferStatus; - if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to send MCTP command over %s: %r\n", = __func__, mTransportName, Status)); - return Status; - } =20 return Status; } --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109916): https://edk2.groups.io/g/devel/message/109916 Mute This Topic: https://groups.io/mt/102134656/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-