From nobody Mon Feb 9 10:58:17 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109915+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109915+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1698066324; cv=none; d=zohomail.com; s=zohoarc; b=YJv3xUFgbNlcezxFS3xcm+pOu8/+zPNKAIu0oJrZzP0YoERVQvPESi3zhXqcvYdr5hzQx4optbuPYJ3X5PEJF5JbHvLG0Ny+UAEKfUHh2AKyTxGjNFYxypA14NKBwrsQo4ZqKZnJBrPInJYwLJcSXpUL8GDukdkoPSI/z6M2F8A= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698066324; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=qSBuDGH4SgLORBiZzdCmjS3xMRTyIGaeBrpVop55z18=; b=WHz996AUkwtGBawFVHjQtWqxTFcf/k3SuiyjiJTU96co+1W1783xtba6KVbrYEsgfUsMdpKBWMZOqBnbdkI1mKcORyIPjB8ZSV6X70LlTfJuhOg0czAEBKpP3AyzlJRLUJs6P0YwfImCKoay5q7a2rva381Sh5Sg3NHsjtnxmSs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109915+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1698066324845912.0452614899104; Mon, 23 Oct 2023 06:05:24 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=xJb/MpHrcg4p5QBmR0ERuqc43+YmfEumuqt72mGyrks=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698066324; v=1; b=rvBEDC4alcNxQuYd+wFVfFvoNpknMirVFwb8ZzSW3XpP2xcawmYzX0E92q/8AGXHoUOgh+dp WfauurVI6FV2AMB2Ph11OcnMFq4XZ22xhEqgqpguUC1fsdGNwmSVSMu38vspT6CaJc4vRDLMxbA U6pF9fvDnK/GCgq7z6bHhg84= X-Received: by 127.0.0.2 with SMTP id kC53YY1788612xC195LRfeBW; Mon, 23 Oct 2023 06:05:24 -0700 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web10.119846.1698066323289932092 for ; Mon, 23 Oct 2023 06:05:23 -0700 X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2c5056059e0so49518691fa.3 for ; Mon, 23 Oct 2023 06:05:23 -0700 (PDT) X-Gm-Message-State: 3IBsehvEAzeRFlxNlTvEyrEmx1787277AA= X-Google-Smtp-Source: AGHT+IGSfsWY5jIljmVs7MsrSlvIDkcYNQOlcLCM8uak25AItsGfDUm3DtXUMeW3rq0TBD1uRirKtw== X-Received: by 2002:a05:651c:1409:b0:2c5:1d11:5688 with SMTP id u9-20020a05651c140900b002c51d115688mr6044569lje.14.1698066321049; Mon, 23 Oct 2023 06:05:21 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id r11-20020a2e994b000000b002b9e0d19644sm1550081ljj.106.2023.10.23.06.05.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 06:05:20 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms v3 07/16] ManageabilityPkg: Correct value for the MCTP TAG_OWNER response bit Date: Mon, 23 Oct 2023 16:05:02 +0300 Message-Id: <20231023130511.4521-8-aladyshev22@gmail.com> In-Reply-To: <20231023130511.4521-1-aladyshev22@gmail.com> References: <20231023130511.4521-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698066326877100031 Content-Type: text/plain; charset="utf-8" Currently the MCTP TAG_OWNER bit is checked against 1 both in MTCP request and response. According to the MTCP Base specification in case of the MCTP response the TAG_OWNER bit should be equal to 0. Correct MCTP_MESSAGE_TAG_OWNER_RESPONSE flag value to fix the issue. Signed-off-by: Konstantin Aladyshev --- .../Include/Library/ManageabilityTransportMctpLib.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Features/ManageabilityPkg/Include/Library/ManageabilityTranspo= rtMctpLib.h b/Features/ManageabilityPkg/Include/Library/ManageabilityTransp= ortMctpLib.h index 462e7436e6..a8dc8a8519 100644 --- a/Features/ManageabilityPkg/Include/Library/ManageabilityTransportMctpL= ib.h +++ b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportMctpL= ib.h @@ -51,8 +51,8 @@ typedef struct { // is not defined by the specification. #define MCTP_MESSAGE_TAG 0x1 =20 -#define MCTP_MESSAGE_TAG_OWNER_REQUEST 0x01 -#define MCTP_MESSAGE_TAG_OWNER_RESPONSE 0x01 +#define MCTP_MESSAGE_TAG_OWNER_REQUEST 1 +#define MCTP_MESSAGE_TAG_OWNER_RESPONSE 0 =20 #define MCTP_PACKET_SEQUENCE_MASK 0x3 =20 --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109915): https://edk2.groups.io/g/devel/message/109915 Mute This Topic: https://groups.io/mt/102134655/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-