From nobody Mon Feb 9 19:53:52 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109924+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109924+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1698066331; cv=none; d=zohomail.com; s=zohoarc; b=TAYLKVp+qaOdDHNB2joPDFoR3zvnjS3Qg5i+wP0dnLUxTaGJpHVhRZJICIQMuVrW5I814co+in1wJk/alU7P+oxeOx6gMZSnW00wII08TPiu2N2dMWfoxD/Li2BE4+KlAfexggeAXzwMwTKKTbCIn7hj4LHk2KtubE+1L9qsUs4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698066331; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=AJYiw0/QrYVj6ZDPdZVN3EwgNlN1pXQaCMHYy1Y9rV8=; b=itF5BeoZkkLCIBpEDrqvYUszFEHVYQXc6usAThHuCnTUzKpyAh4/tKu3NeiVukkCWr9tVlUXIY+Rl6qgAn5ft0ZHaVbTfngP5ggYcCk99WGTAIo9VrcW9TLZeXqGGR/XLfAYBdRrtguNNmTIY8aSa4oHjVn9qw78gT8H47IHK88= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109924+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1698066331875754.3893458349054; Mon, 23 Oct 2023 06:05:31 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=HLI4EI9KEBjT0gU9NJUo0QYdLkMiPRABLHN01aWvzYY=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698066331; v=1; b=OanNtVkMoaz49OCf85PRywgae1jfFPcwS/SHACPIvt7jU8u/joX6BhmhGv99+wu8XgNBTXaG sCdnuD2axp2VYKqTz2iszVKxMSPp1RdK55EoBSEulVHJNPdNeGHvrvzRNZnRs5u33twbkc0WRNT PUH4gnqVxYASSwOBWYspq/BQ= X-Received: by 127.0.0.2 with SMTP id jpnEYY1788612xhIlpbK4qVU; Mon, 23 Oct 2023 06:05:31 -0700 X-Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mx.groups.io with SMTP id smtpd.web11.120299.1698066330723625316 for ; Mon, 23 Oct 2023 06:05:31 -0700 X-Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-507a62d4788so5143252e87.0 for ; Mon, 23 Oct 2023 06:05:30 -0700 (PDT) X-Gm-Message-State: saNQTUq928ERykKT1NyICbINx1787277AA= X-Google-Smtp-Source: AGHT+IGZr8tBncdj4usfAL6iF7PkBv59tg+Pcncj4jwX4jOVv1gn5tHP8LSVtPXXvsiSmVSFWnwdjw== X-Received: by 2002:a2e:b953:0:b0:2bd:1fee:aacf with SMTP id 19-20020a2eb953000000b002bd1feeaacfmr5755684ljs.24.1698066328611; Mon, 23 Oct 2023 06:05:28 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id r11-20020a2e994b000000b002b9e0d19644sm1550081ljj.106.2023.10.23.06.05.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 06:05:28 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms v3 16/16] ManageabilityPkg: Check PLDM completion code Date: Mon, 23 Oct 2023 16:05:11 +0300 Message-Id: <20231023130511.4521-17-aladyshev22@gmail.com> In-Reply-To: <20231023130511.4521-1-aladyshev22@gmail.com> References: <20231023130511.4521-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698066332929100061 Content-Type: text/plain; charset="utf-8" Every PLDM response contains 1 byte Completion code which is needed to be checked against SUCCESS value which means that the PLDM command was accepted and completed normally. If it is not equal to that value it is necessary to return error status so the caller would know that Response buffer is invalid. Signed-off-by: Konstantin Aladyshev --- .../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/Pl= dmProtocolCommon.c index 04f250e57c..2f2f76603e 100644 --- a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c @@ -293,7 +293,8 @@ CommonPldmSubmitCommand ( (ResponseHeader->PldmHeader.RequestBit !=3D PLDM_MESSAGE_HEADER_IS_R= ESPONSE) || (ResponseHeader->PldmHeader.InstanceId !=3D mPldmRequestInstanceId) = || (ResponseHeader->PldmHeader.PldmType !=3D PldmType) || - (ResponseHeader->PldmHeader.PldmTypeCommandCode !=3D PldmCommand)) + (ResponseHeader->PldmHeader.PldmTypeCommandCode !=3D PldmCommand) || + (ResponseHeader->PldmCompletionCode !=3D PLDM_COMPLETION_CODE_SUCCES= S)) { DEBUG ((DEBUG_ERROR, "PLDM integrity check of response data is failed.= \n")); DEBUG ((DEBUG_ERROR, " Datagram =3D %d (Expected value: %d)\n",= ResponseHeader->PldmHeader.DatagramBit, (!PLDM_MESSAGE_HEADER_IS_DATAGRAM)= )); --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109924): https://edk2.groups.io/g/devel/message/109924 Mute This Topic: https://groups.io/mt/102134666/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-