From nobody Mon Feb 9 19:53:32 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109918+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109918+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1698066327; cv=none; d=zohomail.com; s=zohoarc; b=aBb6Jje6WKlA43YHjlU4Egs8J+u5I98y71WxHelBvM0MTD2dZnBZJygW8gdjxK65FWvkqZv1l2ozR1LKNErJS9sXoTDKysqg37/CecTbGyJPaijcLiqO12z0yuBc45jJuFHeFJA1worstlHf364pBGBUNJNviRLbn83dmzn4kF0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1698066327; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=DEfuRL33HwVoNytnbcBZ8OzL+QHUL+J2PVYPFPOdrmM=; b=ORHflAIWUoiWCvB48F58+XbJd+8es2Pr50LojPEO0/Njy5Yz3MmYo8vtMtTo+tH88ZHVVepmZaw3QK03I9LgwlhwDCNAJ/j7emBEcQWik0N/gXo7wS8mI0GnMyb3o8lyMZ58mEZIwhp/L2WtrXwLFNI5EawPLsJJ9bkk9LfECgs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109918+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1698066327549425.2216107433287; Mon, 23 Oct 2023 06:05:27 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=40mJXTPR82mTH8+6m/MqaI/29UMBSCTB7tDROT7nzqk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1698066327; v=1; b=Z4EqJtzyelVMp/vhPK2aVQTN8tq/cwJMSHCWSERlxiL3QnBnD7jxd6zrPqcf2UTcU6cWJRSQ Hk+GA/O8//8vgl3iBRz3jm3h9hBc+zbyc97UPJuWZRyEBmvuxatrmOHIESm378VQUKhDWvGjvxP fJ67OD6Ab1UFhcnmYwHSiyjk= X-Received: by 127.0.0.2 with SMTP id c1E6YY1788612xuhOXOSFwKb; Mon, 23 Oct 2023 06:05:27 -0700 X-Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by mx.groups.io with SMTP id smtpd.web10.119848.1698066325594501203 for ; Mon, 23 Oct 2023 06:05:25 -0700 X-Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-507ac66a969so4388711e87.3 for ; Mon, 23 Oct 2023 06:05:25 -0700 (PDT) X-Gm-Message-State: AEsTFyT9qX0vpc5ik5Nj1DAwx1787277AA= X-Google-Smtp-Source: AGHT+IHrZDN4tzl37I+5cNtOa12a9Prdx2/rRp6PgUR6ecjD+O2Ru8O2+FPoKBlt9SC8FkhqhjH0qg== X-Received: by 2002:a2e:3a03:0:b0:2c5:84c:62d3 with SMTP id h3-20020a2e3a03000000b002c5084c62d3mr6010175lja.5.1698066323402; Mon, 23 Oct 2023 06:05:23 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id r11-20020a2e994b000000b002b9e0d19644sm1550081ljj.106.2023.10.23.06.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 06:05:22 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms v3 10/16] ManageabilityPkg: Return error on multiple-packet MCTP responses Date: Mon, 23 Oct 2023 16:05:05 +0300 Message-Id: <20231023130511.4521-11-aladyshev22@gmail.com> In-Reply-To: <20231023130511.4521-1-aladyshev22@gmail.com> References: <20231023130511.4521-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1698066328811100041 Content-Type: text/plain; charset="utf-8" Since the current driver doesn't yet support handling of multiple-packet MCTP responses, return EFI_UNSUPPORTED error in such cases. Signed-off-by: Konstantin Aladyshev --- .../MctpProtocol/Common/MctpProtocolCommon.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/Mc= tpProtocolCommon.c index 4aae4fcba9..3709ab16eb 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c @@ -524,6 +524,17 @@ CommonMctpSubmitMessage ( FreePool (ResponseBuffer); return EFI_DEVICE_ERROR; } + if ((MctpTransportResponseHeader->Bits.StartOfMessage !=3D 1) || + (MctpTransportResponseHeader->Bits.EndOfMessage !=3D 1) || + (MctpTransportResponseHeader->Bits.PacketSequence !=3D 0)) { + DEBUG (( + DEBUG_ERROR, + "%a: Error! Multiple-packet MCTP responses are not supported by the = current driver\n", + __func__ + )); + FreePool (ResponseBuffer); + return EFI_UNSUPPORTED; + } =20 MctpMessageResponseHeader =3D (MCTP_MESSAGE_HEADER *)(MctpTransportRespo= nseHeader + 1); if (MctpMessageResponseHeader->Bits.MessageType !=3D MctpType) { --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109918): https://edk2.groups.io/g/devel/message/109918 Mute This Topic: https://groups.io/mt/102134658/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-