From nobody Tue Feb 10 00:00:58 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109858+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109858+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1697806399; cv=none; d=zohomail.com; s=zohoarc; b=X2MWf8c2AOe9Te9MFU/BSwtz3Ak+TpO0/mPVwGX/8A+IrolpAFKyefoQZIY9qoftWyWhMgbrYn1CZd/vxoSxlbl0E0RLk2QvY4MjfYwAl3WjyXRE5G7NEEhMAKrkREibcgLhKCquQAKViLI5Db4rOonlZV4w4P7qxpr9hA9M8Kg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697806399; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=HasTvpt5Q5Q4L+lm22lsTQv+DhreLefgMXuhU0s95fc=; b=Y7e9aBPhm6VAAyIY8Z/W7ujzXd8uEL3oLW7SH6i5mZggSjv7Cg2tEcwif2vKpEbgRaNDE9AtBswVV4CON37J+Wbx0BXiw8vT/LA9CRk1hO2ncyKYttcz+oAH59L+SRtggf9p13z6lydIImq1XeMs1nTDbdp8xldKSJw3TuFQSgY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109858+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697806399503451.2084419044553; Fri, 20 Oct 2023 05:53:19 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=p+Q+uA3/tVQhIMSBCW6NUO9W5rBeeQ4cQvyqTpZN2T4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697806399; v=1; b=w3cIj1H396/KCz+zBIm7Nr/tOOM8Mcp+o6aDuXBeqPr5xb90LNKZoyr8tg9hn4JaGGu8zESF lg8W+6hDfXqh8446WcPn7xuv/6x1W+n/4kxMsrxSdWFdsiiFcUpmEFH65tiNiHA/oFcoruNpT68 CrdX1WfNxZm9PA/w02rG2osM= X-Received: by 127.0.0.2 with SMTP id B95VYY1788612xvnGX79rHLc; Fri, 20 Oct 2023 05:53:19 -0700 X-Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) by mx.groups.io with SMTP id smtpd.web11.53590.1697806398338745651 for ; Fri, 20 Oct 2023 05:53:18 -0700 X-Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2c5056059e0so11684341fa.3 for ; Fri, 20 Oct 2023 05:53:18 -0700 (PDT) X-Gm-Message-State: X1Mx028zSiz3X3vl08q2dA2Cx1787277AA= X-Google-Smtp-Source: AGHT+IFgcylOpZjX+Ts68PSG/x+VDVLUhrOGwBrKjpXNi3tx27/EKUn7o13sP61BxNIt4dqEBVnXBw== X-Received: by 2002:a2e:b04b:0:b0:2c5:1b01:b67f with SMTP id d11-20020a2eb04b000000b002c51b01b67fmr1307951ljl.52.1697806396114; Fri, 20 Oct 2023 05:53:16 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id x22-20020a05651c105600b002b9e5fe86dasm350853ljm.81.2023.10.20.05.53.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 05:53:15 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, isaac.w.oram@intel.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms v2 08/15] ManageabilityPkg: Don't check MCTP header fields if transfer has failed Date: Fri, 20 Oct 2023 15:52:55 +0300 Message-Id: <20231020125302.1459-9-aladyshev22@gmail.com> In-Reply-To: <20231020125302.1459-1-aladyshev22@gmail.com> References: <20231020125302.1459-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697806400550100020 Content-Type: text/plain; charset="utf-8" If MCTP KCS communication has failed we need to abort MCTP transfer function before checking any MCTP header data. Signed-off-by: Konstantin Aladyshev --- .../MctpProtocol/Common/MctpProtocolCommon.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/Mc= tpProtocolCommon.c index 3128aadd15..4aae4fcba9 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c @@ -461,6 +461,13 @@ CommonMctpSubmitMessage ( &TransferToken ); =20 + *AdditionalTransferError =3D TransferToken.TransportAdditionalStatus; + Status =3D TransferToken.TransferStatus; + if (EFI_ERROR (Status)) { + DEBUG ((DEBUG_ERROR, "%a: Failed to send MCTP command over %s: %r\n", = __func__, mTransportName, Status)); + return Status; + } + MctpTransportResponseHeader =3D (MCTP_TRANSPORT_HEADER *)ResponseBuffer; if (MctpTransportResponseHeader->Bits.HeaderVersion !=3D MCTP_KCS_HEADER= _VERSION) { DEBUG (( @@ -543,18 +550,9 @@ CommonMctpSubmitMessage ( return EFI_DEVICE_ERROR; } =20 - // - // Return transfer status. - // - *AdditionalTransferError =3D TransferToken.TransportAdditionalStatus; *ResponseDataSize =3D TransferToken.ReceivePackage.ReceiveSizeInB= yte - sizeof (MCTP_TRANSPORT_HEADER) - sizeof (MCTP_MESSAGE_HEADER); CopyMem (ResponseData, ResponseBuffer + sizeof (MCTP_TRANSPORT_HEADER) += sizeof (MCTP_MESSAGE_HEADER), *ResponseDataSize); FreePool (ResponseBuffer); - Status =3D TransferToken.TransferStatus; - if (EFI_ERROR (Status)) { - DEBUG ((DEBUG_ERROR, "%a: Failed to send MCTP command over %s: %r\n", = __func__, mTransportName, Status)); - return Status; - } =20 return Status; } --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109858): https://edk2.groups.io/g/devel/message/109858 Mute This Topic: https://groups.io/mt/102080236/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-