From nobody Fri Dec 19 20:54:15 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109851+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109851+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1697806391; cv=none; d=zohomail.com; s=zohoarc; b=Pldx9kV2/E9wBaM75DC6nBCV8NrF9vsKE0E5zm8Aw///aueG/U/celRUvj/e/5FuYloo2n869WlIJXdQm2ZYuiRUReCydsIpU7gvmNjhyV47gBPnzKnXtNbt23nUsELgp54UYljIT3PeIrOpRwLdZHQsVUAbF+bvHSxa3xLumW0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697806391; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=SD2NmojrwMlKH6kaGHWe+E6LrEpds6HMRGIgXt+r90E=; b=M1O3m/9ezl/P9c5+K/PagG6WLmT6d2ayvsYeksVkAhYUcDILjqtvnG3LskxVFwuGLpl8m2Ohcs0PLJYMPm1JAIQ8cqrML9IigJX/0TansHM5uunXugZvPKOISty70WlSHv08WVb+dypu81l70KnhunSWzkbfIrNYE54lG/jMnlw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109851+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697806391425246.10619015348266; Fri, 20 Oct 2023 05:53:11 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=L+LE9m2PuP4lTZp4Em3i2K3KemBR09dapbURsv48wOM=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697806391; v=1; b=dJlB3cJ1EASH1n1ZuNQLEBjNdgdSlRajMV2lIF5BNuBpH7Hni8gmEHZoYDvAwBG4acZI/Y8r s4Y0WXO/Z5v+yZx/xQZgE+EE4/iPo181VydX3W4v2OvszXud+JB3L3//SoFPpVOuGzLaGl8J3+G NSjepAEPKb1DnNVkJpl0oh48= X-Received: by 127.0.0.2 with SMTP id 5W4bYY1788612xUcD42GPbqX; Fri, 20 Oct 2023 05:53:11 -0700 X-Received: from mail-lj1-f176.google.com (mail-lj1-f176.google.com [209.85.208.176]) by mx.groups.io with SMTP id smtpd.web10.53373.1697806390324307821 for ; Fri, 20 Oct 2023 05:53:10 -0700 X-Received: by mail-lj1-f176.google.com with SMTP id 38308e7fff4ca-2c509f2c46cso11436751fa.1 for ; Fri, 20 Oct 2023 05:53:10 -0700 (PDT) X-Gm-Message-State: BsM8gB2r847P7llR2jCj2vZpx1787277AA= X-Google-Smtp-Source: AGHT+IFBKpuFCiEQ/kv6xTVzvYC9EkBSkghuWSSg1MbsY/AZhRggPjfk4hRydTt7yaHj7miKVXgUgg== X-Received: by 2002:a05:651c:555:b0:2c0:32a1:71dd with SMTP id q21-20020a05651c055500b002c032a171ddmr1496710ljp.28.1697806387984; Fri, 20 Oct 2023 05:53:07 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id x22-20020a05651c105600b002b9e5fe86dasm350853ljm.81.2023.10.20.05.53.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 05:53:07 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, isaac.w.oram@intel.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms v2 01/15] ManageabilityPkg: Add definition for the MCTP KCS TRAILER structure Date: Fri, 20 Oct 2023 15:52:48 +0300 Message-Id: <20231020125302.1459-2-aladyshev22@gmail.com> In-Reply-To: <20231020125302.1459-1-aladyshev22@gmail.com> References: <20231020125302.1459-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697806392517100002 Content-Type: text/plain; charset="utf-8" Currently there is only a definition for the MCTP KCS HEADER structure. Add definition for the MCTP KCS TRAILER structure as well. Signed-off-by: Konstantin Aladyshev Signed-off-by: Abner Chang --- .../Library/ManageabilityTransportMctpLib.h | 5 +++++ .../MctpProtocol/Common/MctpProtocolCommon.c | 14 +++++++------- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/Features/ManageabilityPkg/Include/Library/ManageabilityTranspo= rtMctpLib.h b/Features/ManageabilityPkg/Include/Library/ManageabilityTransp= ortMctpLib.h index 43bd142f4c..462e7436e6 100644 --- a/Features/ManageabilityPkg/Include/Library/ManageabilityTransportMctpL= ib.h +++ b/Features/ManageabilityPkg/Include/Library/ManageabilityTransportMctpL= ib.h @@ -39,6 +39,11 @@ typedef struct { UINT8 DefiningBody; ///< Message type. UINT8 ByteCount; ///< Byte count of payload. } MANAGEABILITY_MCTP_KCS_HEADER; + +typedef struct { + UINT8 Pec; ///< MCTP over KCS Packet Error Code. +} MANAGEABILITY_MCTP_KCS_TRAILER; + #define MCTP_KCS_NETFN_LUN 0xb0 #define DEFINING_BODY_DMTF_PRE_OS_WORKING_GROUP 0x01 =20 diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/Mc= tpProtocolCommon.c index 1ad48efdc7..7576007f77 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c @@ -132,7 +132,7 @@ SetupMctpRequestTransportPacket ( MANAGEABILITY_MCTP_KCS_HEADER *MctpKcsHeader; MCTP_TRANSPORT_HEADER *MctpTransportHeader; MCTP_MESSAGE_HEADER *MctpMessageHeader; - UINT8 *Pec; + MANAGEABILITY_MCTP_KCS_TRAILER *MctpKcsTrailer; UINT8 *ThisPackage; =20 if ((PacketHeader =3D=3D NULL) || (PacketHeaderSize =3D=3D NULL) || @@ -151,8 +151,8 @@ SetupMctpRequestTransportPacket ( return EFI_OUT_OF_RESOURCES; } =20 - Pec =3D (UINT8 *)AllocateZeroPool (sizeof (UINT8)); - if (Pec =3D=3D NULL) { + MctpKcsTrailer =3D (MANAGEABILITY_MCTP_KCS_TRAILER *)AllocateZeroPool = (sizeof (MANAGEABILITY_MCTP_KCS_TRAILER)); + if (MctpKcsTrailer =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "%a: Not enough resource for PEC.\n", __func__)= ); FreePool (MctpKcsHeader); return EFI_OUT_OF_RESOURCES; @@ -167,7 +167,7 @@ SetupMctpRequestTransportPacket ( if (ThisPackage =3D=3D NULL) { DEBUG ((DEBUG_ERROR, "%a: Not enough resource for package.\n", __fun= c__)); FreePool (MctpKcsHeader); - FreePool (Pec); + FreePool (MctpKcsTrailer); return EFI_OUT_OF_RESOURCES; } =20 @@ -193,14 +193,14 @@ SetupMctpRequestTransportPacket ( =20 // // Generate PEC follow SMBUS 2.0 specification. - *Pec =3D HelperManageabilityGenerateCrc8 (MCTP_KCS_PACKET_ERROR_CODE_P= OLY, 0, ThisPackage, MctpKcsHeader->ByteCount); + MctpKcsTrailer->Pec =3D HelperManageabilityGenerateCrc8 (MCTP_KCS_PACK= ET_ERROR_CODE_POLY, 0, ThisPackage, MctpKcsHeader->ByteCount); =20 *PacketBody =3D (UINT8 *)ThisPackage; *PacketBodySize =3D MctpKcsHeader->ByteCount; - *PacketTrailer =3D (MANAGEABILITY_TRANSPORT_TRAILER)Pec; + *PacketTrailer =3D (MANAGEABILITY_TRANSPORT_TRAILER)MctpKcsTrailer; *PacketHeader =3D (MANAGEABILITY_TRANSPORT_HEADER)MctpKcsHeader; *PacketHeaderSize =3D sizeof (MANAGEABILITY_MCTP_KCS_HEADER); - *PacketTrailerSize =3D 1; + *PacketTrailerSize =3D sizeof (MANAGEABILITY_MCTP_KCS_TRAILER); return EFI_SUCCESS; } else { DEBUG ((DEBUG_ERROR, "%a: No implementation of building up packet.", _= _func__)); --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109851): https://edk2.groups.io/g/devel/message/109851 Mute This Topic: https://groups.io/mt/102080228/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-