From nobody Mon Feb 9 11:31:44 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109864+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109864+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1697806417; cv=none; d=zohomail.com; s=zohoarc; b=AbksEYyl0Z36X1lTVF/7r47Q+KNVg2nxz/qenBjfvi0WWhnziOtDXCV37AM1aIXdE08jGVsAC46cUcNEtSkcpHeXMWCsiCq2gYIWu1HurmXrV9gxFM1YXBFRbbngwDTLR4Z7HUXb1nNBbCcXhwVIC0ON/WwnsN8rjQYhOWkY/Ms= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697806417; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=o0SyuUKC4/AM22J2pYZFsWqc+GtGXybpWT4grpZadQQ=; b=Wq1sLd54d82aognUA9Iza993MJYR8CxNW2/0MKHp8g+iZnR7tw7gW2ssMcYhi1N+NO0UbXP0uJ8fatqzZr1ZS7OdKF0OV/1Pb+7aejScAmYcd6xnK9jfJAvqLCpGMe1ppZ6z7fJvtcfWxpRPausZ2VRK7xJMTloi9Lq0yR4lcPY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109864+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 169780641775996.28758670019681; Fri, 20 Oct 2023 05:53:37 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=80c7Eiwt2Mz23JBWTbGsouPu8L1tenayOt9BMfKEWNk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697806408; v=1; b=peLdzCkYHIKraSMwsIpFtCOQBX74XT3t46cwdbqyo3ZE1OfgMBYWBvmKHE0tWa7l5dflDV6D JWD8T4OevdVQtwQF4kGhCEfu7G93u5UT3QmQctGYxTYhmoWDRmubSSPVPzWaLyo0afzmRbbEsju H4TDrtj+GLOR6beUYNnTmduU= X-Received: by 127.0.0.2 with SMTP id tpyGYY1788612x4hkJ2n3Hql; Fri, 20 Oct 2023 05:53:28 -0700 X-Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by mx.groups.io with SMTP id smtpd.web10.53395.1697806405611441783 for ; Fri, 20 Oct 2023 05:53:25 -0700 X-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2bb9a063f26so11141201fa.2 for ; Fri, 20 Oct 2023 05:53:25 -0700 (PDT) X-Gm-Message-State: 6dhuz6SboKxh540fQJOxSPiSx1787277AA= X-Google-Smtp-Source: AGHT+IH3U03e7v6A1SaDkFNkDUfIaM4WgyftbSeoQAMJ9CTREo4Pv8a0PgUOLeoUdyTEoDCL90Du9A== X-Received: by 2002:a2e:9658:0:b0:2c5:16c0:6239 with SMTP id z24-20020a2e9658000000b002c516c06239mr1254128ljh.51.1697806403453; Fri, 20 Oct 2023 05:53:23 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id x22-20020a05651c105600b002b9e5fe86dasm350853ljm.81.2023.10.20.05.53.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 05:53:22 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, isaac.w.oram@intel.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms v2 14/15] ManageabilityPkg: Return error on PLDM header check fails Date: Fri, 20 Oct 2023 15:53:01 +0300 Message-Id: <20231020125302.1459-15-aladyshev22@gmail.com> In-Reply-To: <20231020125302.1459-1-aladyshev22@gmail.com> References: <20231020125302.1459-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697806418600100001 Content-Type: text/plain; charset="utf-8" Currently PldmSubmit command returns EFI_SUCCESS even if the response header checks have failed. Correct the code to return errors in such cases. Signed-off-by: Konstantin Aladyshev --- .../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/Pl= dmProtocolCommon.c index bc72ce07b3..04f250e57c 100644 --- a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c @@ -241,7 +241,7 @@ CommonPldmSubmitCommand ( if (FullPacketResponseData =3D=3D NULL) { DEBUG ((DEBUG_ERROR, " Not enough memory for FullPacketResponseDataSi= ze.\n")); Status =3D EFI_OUT_OF_RESOURCES; - goto ErrorExit2; + goto ErrorExit; } =20 // Print out PLDM packet. @@ -281,6 +281,7 @@ CommonPldmSubmitCommand ( FullPacketResponseDataSize )); HelperManageabilityDebugPrint ((VOID *)FullPacketResponseData, Transfe= rToken.ReceivePackage.ReceiveSizeInByte, "Failed response payload\n"); + Status =3D EFI_DEVICE_ERROR; goto ErrorExit; } =20 @@ -303,6 +304,7 @@ CommonPldmSubmitCommand ( DEBUG ((DEBUG_ERROR, " Pldm Completion Code =3D 0x%x\n", ResponseHe= ader->PldmCompletionCode)); =20 HelperManageabilityDebugPrint ((VOID *)FullPacketResponseData, Transfe= rToken.ReceivePackage.ReceiveSizeInByte, "Failed response payload\n"); + Status =3D EFI_DEVICE_ERROR; goto ErrorExit; } =20 @@ -319,6 +321,7 @@ CommonPldmSubmitCommand ( )); =20 HelperManageabilityDebugPrint ((VOID *)FullPacketResponseData, Transfe= rToken.ReceivePackage.ReceiveSizeInByte, "Failed response payload\n"); + Status =3D EFI_DEVICE_ERROR; goto ErrorExit; } =20 @@ -332,6 +335,7 @@ CommonPldmSubmitCommand ( ResponseHeader->PldmCompletionCode )); HelperManageabilityDebugPrint ((VOID *)FullPacketResponseData, GET_PLD= M_MESSAGE_PAYLOAD_SIZE(TransferToken.ReceivePackage.ReceiveSizeInByte), "Fa= iled response payload\n"); + Status =3D EFI_DEVICE_ERROR; goto ErrorExit; } =20 @@ -350,13 +354,12 @@ CommonPldmSubmitCommand ( =20 // Return transfer status. // -ErrorExit: Status =3D TransferToken.TransferStatus; if (EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "%a: Failed to send PLDM command over %s\n", __fu= nc__, mTransportName)); } =20 -ErrorExit2: +ErrorExit: if (PldmTransportHeader !=3D NULL) { FreePool ((VOID *)PldmTransportHeader); } --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109864): https://edk2.groups.io/g/devel/message/109864 Mute This Topic: https://groups.io/mt/102080244/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-