From nobody Fri Dec 19 20:54:04 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109860+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109860+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1697806405; cv=none; d=zohomail.com; s=zohoarc; b=cZDAF+nLgBcM+lwa8+cX4nQfkxvAa7TI1LoGhKhKBSQxj3GpT74GgClKEJo+whp4Nr0dEN23H7vbqE0F/UyDkg4FvHLTVr+mLb1jiKDHUNnn2uI69XHXQ48F9hqxvmFG8fN8XyHE3cS/mca+nqOufcruqAIsK+wQFhwB1KEqpLE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697806405; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=Kj1kzmSmnNC4NWxY9Yks1Ea0weOGCSJYW74wia9zJlY=; b=BiUqal5M1o/vNz1cHzfxcJC5qdd69Y23VSP+1U+B61rdko0+iBzzLhkUSHNWIF5qlBdjpkZRECQb5qztnaJV6tctQ2n/TD2QXD/FYZoHb7wKVjUfPXeB4HbxPHj6P+htIm9fNhBmvC91EsoW6k42QwpNqgDq/JdSFMmDa2OfiAs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109860+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697806405871544.8250691320633; Fri, 20 Oct 2023 05:53:25 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=NQKu5eUWZnLl/LOdgzzATobRXYpcIfEmNk/kuqAraq8=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697806401; v=1; b=L4IVqnHIlrS/6WLHoxO/G6XOmmYoLpxpmKG+SgGgo+QCTKhlkSLXsV+QN8B5uAG0/kPzYijj aDAcmGWd80sYG944Izmi/ZuqZo8hJcBf0QfH79641bP6qvzhp94rVj5xz0uNVM4RD5tXA921bPV VAJhMcOqYjrtzOvvvr/n6IhI= X-Received: by 127.0.0.2 with SMTP id L9OUYY1788612xKjqtJ1Wep5; Fri, 20 Oct 2023 05:53:21 -0700 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web10.53388.1697806400715499693 for ; Fri, 20 Oct 2023 05:53:21 -0700 X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2c5210a1515so12600531fa.0 for ; Fri, 20 Oct 2023 05:53:20 -0700 (PDT) X-Gm-Message-State: nZdFecHpR9zAXw4mU94hCINCx1787277AA= X-Google-Smtp-Source: AGHT+IEyjg9TuOoBbZL7VPu/bx2mtzfgGEc7Q681O+14Zh5hRq2atnl2N3ON8/HU3uMGy/GdJZcA5A== X-Received: by 2002:a2e:b78f:0:b0:2c5:2813:5534 with SMTP id n15-20020a2eb78f000000b002c528135534mr1490221ljo.51.1697806398640; Fri, 20 Oct 2023 05:53:18 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id x22-20020a05651c105600b002b9e5fe86dasm350853ljm.81.2023.10.20.05.53.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 05:53:18 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, isaac.w.oram@intel.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms v2 10/15] ManageabilityPkg: Return error on multiple-packet MCTP responses Date: Fri, 20 Oct 2023 15:52:57 +0300 Message-Id: <20231020125302.1459-11-aladyshev22@gmail.com> In-Reply-To: <20231020125302.1459-1-aladyshev22@gmail.com> References: <20231020125302.1459-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697806406536100031 Content-Type: text/plain; charset="utf-8" Since the current driver doesn't yet support handling of multiple-packet MCTP responses, return EFI_UNSUPPORTED error in such cases. Signed-off-by: Konstantin Aladyshev --- .../MctpProtocol/Common/MctpProtocolCommon.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/Mc= tpProtocolCommon.c index 4aae4fcba9..3709ab16eb 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c @@ -524,6 +524,17 @@ CommonMctpSubmitMessage ( FreePool (ResponseBuffer); return EFI_DEVICE_ERROR; } + if ((MctpTransportResponseHeader->Bits.StartOfMessage !=3D 1) || + (MctpTransportResponseHeader->Bits.EndOfMessage !=3D 1) || + (MctpTransportResponseHeader->Bits.PacketSequence !=3D 0)) { + DEBUG (( + DEBUG_ERROR, + "%a: Error! Multiple-packet MCTP responses are not supported by the = current driver\n", + __func__ + )); + FreePool (ResponseBuffer); + return EFI_UNSUPPORTED; + } =20 MctpMessageResponseHeader =3D (MCTP_MESSAGE_HEADER *)(MctpTransportRespo= nseHeader + 1); if (MctpMessageResponseHeader->Bits.MessageType !=3D MctpType) { --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109860): https://edk2.groups.io/g/devel/message/109860 Mute This Topic: https://groups.io/mt/102080239/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-