From nobody Fri Dec 19 20:54:12 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109859+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109859+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1697806401; cv=none; d=zohomail.com; s=zohoarc; b=bSTaPyk9bwDTAgIC/lGzwRxuIRNhZSZ0jSygP+hId8iqCJPCJIEUb/6pOQFsgU6BCcbMkQdI+oOsTCASOUs9VhlS2YWW453rQiGARNh9pBUg9IBiPjBr7sSOg5RElpCUaMn4Z4lmOypo5dKhNNpfSIVUNO6NrL8/nU1NZr+uE5Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697806401; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=gyKBnuFPJdaOeNEDZ0wqKVYG3OfiZoVTTvA62tIYgfk=; b=KK28rM/GHZClU9FbXeJ+R6nSM1Pt1/sS5qDDPt2CJsHRhcSdVtZGg5OG0fAJzKjmV6i0lLtOI3KlECuR7eLKtwXqdDQwEWtrp3Yd31Cj2w6bYae9kJKbqn8i4o1OHrGSWyv9VcdpiCBLg2nlJexbP0sr4cNoI7samTVnBYBe4d0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109859+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 169780640105131.95795873890745; Fri, 20 Oct 2023 05:53:21 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=1JyO1G64TCigpb1rPmmFicyImDT+GBxshQDFF1zQNPU=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697806400; v=1; b=bLuwj+6irYL1H6YmCvgUMTIgQL40oA2c+UK6fryFsHdCk9UbQ+jHzbHTY8/OINRLD3ukGQ7B uQOWVeaHKvihpQChtoTg6MQG5Ez1JiJAqidPndjRAjRKhWk82xMLYK/RPDCsFQsPUt3ZLSHzPx9 gINmaOb7aROBPrcKSO6zXq6w= X-Received: by 127.0.0.2 with SMTP id ihdBYY1788612xjVCSODS94Y; Fri, 20 Oct 2023 05:53:20 -0700 X-Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by mx.groups.io with SMTP id smtpd.web10.53387.1697806399854594534 for ; Fri, 20 Oct 2023 05:53:20 -0700 X-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2c501bd6ff1so11037011fa.3 for ; Fri, 20 Oct 2023 05:53:19 -0700 (PDT) X-Gm-Message-State: 5hwti7oHewBdOzW0TM7REpnQx1787277AA= X-Google-Smtp-Source: AGHT+IFeuOQzBiw68p7OuC2l4dkauxbW3EEXAvW21hnP0SD6L/5IrIj9ONGQeSNM69YFDI3INxayTg== X-Received: by 2002:a05:651c:504:b0:2c5:72e:6ff7 with SMTP id o4-20020a05651c050400b002c5072e6ff7mr1384741ljp.24.1697806397743; Fri, 20 Oct 2023 05:53:17 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id x22-20020a05651c105600b002b9e5fe86dasm350853ljm.81.2023.10.20.05.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 05:53:16 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, isaac.w.oram@intel.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms v2 09/15] ManageabilityPkg: Use correct constants for PLDM header checks Date: Fri, 20 Oct 2023 15:52:56 +0300 Message-Id: <20231020125302.1459-10-aladyshev22@gmail.com> In-Reply-To: <20231020125302.1459-1-aladyshev22@gmail.com> References: <20231020125302.1459-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697806402535100025 Content-Type: text/plain; charset="utf-8" Currently PldmProtocol code uses magic numbers in the PLDM header checks. Since PLDM headers have all the necessary definitions replace magic numbers with the appropriate defines. Signed-off-by: Konstantin Aladyshev --- .../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/Pl= dmProtocolCommon.c index 1c4506d87f..4edfe05955 100644 --- a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c @@ -321,15 +321,15 @@ CommonPldmSubmitCommand ( // // Check the integrity of response. data. ResponseHeader =3D (PLDM_RESPONSE_HEADER *)FullPacketResponseData; - if ((ResponseHeader->PldmHeader.DatagramBit !=3D 0) || - (ResponseHeader->PldmHeader.RequestBit !=3D 0) || + if ((ResponseHeader->PldmHeader.DatagramBit !=3D (!PLDM_MESSAGE_HEADER_I= S_DATAGRAM)) || + (ResponseHeader->PldmHeader.RequestBit !=3D PLDM_MESSAGE_HEADER_IS_R= ESPONSE) || (ResponseHeader->PldmHeader.InstanceId !=3D mPldmRequestInstanceId) = || (ResponseHeader->PldmHeader.PldmType !=3D PldmType) || (ResponseHeader->PldmHeader.PldmTypeCommandCode !=3D PldmCommand)) { DEBUG ((DEBUG_ERROR, "PLDM integrity check of response data is failed.= \n")); - DEBUG ((DEBUG_ERROR, " Request bit =3D %d (Expected value: 0)\n")); - DEBUG ((DEBUG_ERROR, " Datagram =3D %d (Expected value: 0)\n")); + DEBUG ((DEBUG_ERROR, " Datagram =3D %d (Expected value: %d)\n",= ResponseHeader->PldmHeader.DatagramBit, (!PLDM_MESSAGE_HEADER_IS_DATAGRAM)= )); + DEBUG ((DEBUG_ERROR, " Request bit =3D %d (Expected value: %d)\n",= ResponseHeader->PldmHeader.RequestBit, PLDM_MESSAGE_HEADER_IS_RESPONSE)); DEBUG ((DEBUG_ERROR, " Instance ID =3D %d (Expected value: %d)\n",= ResponseHeader->PldmHeader.InstanceId, mPldmRequestInstanceId)); DEBUG ((DEBUG_ERROR, " Pldm Type =3D %d (Expected value: %d)\n",= ResponseHeader->PldmHeader.PldmType, PldmType)); DEBUG ((DEBUG_ERROR, " Pldm Command =3D %d (Expected value: %d)\n",= ResponseHeader->PldmHeader.PldmTypeCommandCode, PldmCommand)); --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109859): https://edk2.groups.io/g/devel/message/109859 Mute This Topic: https://groups.io/mt/102080238/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-