From nobody Sat May 18 15:49:30 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109744+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 169763449219924.928026256615226; Wed, 18 Oct 2023 06:08:12 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=IR8TFydop5GkIOxcF93qnAluwWPOF/I17N6uOk9qPao=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697634491; v=1; b=TEDmmT2muSz3zYqh8jK7/vCHJk3MJIRMipVWyH0rrx+alv5sDEYXx4oaD+VUoKGGYP1YB0ts 5jV8tPPDmICCb0hNu2sDuuf5e5HPbBP7s4dGsdEC6LxKnUmbV0ofciInzSKQZZl/ibmrPM/HWGZ Y0sJH4/raWxk1Rn2iBdfUMvw= X-Received: by 127.0.0.2 with SMTP id tGBZYY1788612xyrbIX1GO7t; Wed, 18 Oct 2023 06:08:11 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.54]) by mx.groups.io with SMTP id smtpd.web11.280750.1697634490800485525 for ; Wed, 18 Oct 2023 06:08:11 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LhMrZvRBgH0JIgFj2IsQnjYbPr9qqg1SjodNFfUckx69SlyRNK7AA+351l8nMu/jOMKcuaLrNm1sNn2CNrZYseUwyg4HryXYLpjgcJtvSjLFGpsTF4daUk0VVSypYodZWqs9rm6kgcJbPvVeUDQAoOoHUyDWbhcc0FZ8bIswG2h25z3oeCalBKfANmc/kdPN3v8VSaQ4YfI/bQ+ZexTXhn1m1fbo90ISciua3Kl410JFq6in/FlEPVM+4lwlRJ0DNEZhxLUYpMxi6AQjhdvtIPjCxPOAfOrWXs90IQYceUOUETU5jayI67wjcm9GE0vjc1DF6agLtYycn1bA9cyTxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xaqcCHUhD6lU5DiX2QBlerh7LjovYH72naAP7XNP8o4=; b=QXBprZ5ER3twqMffH1XFKTd4dAtMA6EtLyvVyiwbgJ+hqKhOExi3cmGZ7jlOADX6e0SKDrBlePk9ZhjH5H/Z2RnCXLgoRm6aZiVYhYYkDHxariPFQbCF8bBJ0YMfQgFagheLQOu0XqBk2iR2KOykB8npY5kru9Jirw9VHU0GelLmSK96290eMCD5exV9zZKUEqTDT8o56PZoAz4XtIxwYcoMw1q/9pjtTr/GHjjGvsmhyexJLa/Z80u+zUO16hk9KCMkQH1tTWTzyKqmc+9SWhjCKg9bF9+7jDqfFSD412rQiAjlfemCXpUYsOGOZZ70LLMWlAYEuukg9XT9TtYW/Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none X-Received: from MN2PR16CA0007.namprd16.prod.outlook.com (2603:10b6:208:134::20) by SN7PR12MB6689.namprd12.prod.outlook.com (2603:10b6:806:273::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.21; Wed, 18 Oct 2023 13:08:08 +0000 X-Received: from BL6PEPF0001AB52.namprd02.prod.outlook.com (2603:10b6:208:134:cafe::b7) by MN2PR16CA0007.outlook.office365.com (2603:10b6:208:134::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.29 via Frontend Transport; Wed, 18 Oct 2023 13:08:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109744+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C X-Received: from mail.nvidia.com (216.228.117.161) by BL6PEPF0001AB52.mail.protection.outlook.com (10.167.241.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.22 via Frontend Transport; Wed, 18 Oct 2023 13:08:07 +0000 X-Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 18 Oct 2023 06:07:43 -0700 X-Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 18 Oct 2023 06:07:43 -0700 X-Received: from NV-CL38DL3.nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.986.41 via Frontend Transport; Wed, 18 Oct 2023 06:07:42 -0700 From: "Nickle Wang via groups.io" To: CC: Abner Chang , Igor Kulchytskyy Subject: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout Date: Wed, 18 Oct 2023 21:07:43 +0800 Message-ID: <20231018130743.7712-1-nicklew@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0001AB52:EE_|SN7PR12MB6689:EE_ X-MS-Office365-Filtering-Correlation-Id: b265b585-31bb-487a-d9f2-08dbcfdb45ee X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Message-Info: XYHwmg0AxLUtur7LyAzQ0AbT93O6UNP3kgtIvFqIExys1o9zO7SbsidTQvuv9/JZzOLwPJozGjAyjaA3llKb212f8fAwrXYRNaf177m7oeEDEB5B8tsPhN5BMx8qaWTcOuM/cvkhuUCXbt71tSh3y4c5V1sYf7zqBBd7IG2x4asXySfDE+NSaz4GdTyaxAVctTv9f+31COPv2DH8e7a3+4xU33iCrpJHlgIq4dTUZCkS7xBOOM/3aewlIB7OBGUWM2gYRu156gjdOEJ4KOBsTQP1RgXeWEXjx45oD5nKAfuN6iqM3JYoRQSXKDOYyei7lIbnhi1m3Gc5siEQbPukD1P01d4qi6N0tnaDGExBRmBBNNGH6e0tjZ05fgcS57Ij+eHU/NQP2xeoIylZ0io9+IIOoH+aC/WYl1StSsUhWfYs2eaKfj9Tmq7X7OzMPMiLPpKrxVAjEIqAbsRJLrU/9Lozx/S/CM9nCAOsAPUV4NvoRHIYlumATF3FA6eClX6IVkgh7NRXBMpGjV6eg9SwC7ETyPh60SHndKXZRVeXlC9vvdZ/gQV+hTwFy8MZ9niY92v5nrIPDV6ytxNLzL5cyQJ9uBabAclXu07K39E+fUES41h15ZUrHI6bynqYGzeGzRY1wLaFjVHdyHqusCVZ49peyq4JPAMv6pLIAPZDhfFSjH1oJ8TvqfQlPL9BsTgx5E4g1yYZj+iOq31xG4NinIe4lywe1z0ERc28Sl/ifxB3z6u3Kt1l4mpUHhrCJWexSZJCZzW857r15VKKkheRFQ== X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 13:08:07.8938 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b265b585-31bb-487a-d9f2-08dbcfdb45ee X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0001AB52.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB6689 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,nicklew@nvidia.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: bO56QNVJaN85OyabXbf0tK2wx1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697634493691100001 Content-Type: text/plain; charset="utf-8" Introduce PCD PcdRedfishSendReceiveTimeout to RedfishDiscoverDxe driver. The SendReceiveTimeout is hard-code value in Redfish discover driver. With this PCD, platform owner can configure timeout value easily. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Reviewed-by: Abner Chang Reviewed-by: Igor Kulchytskyy --- RedfishPkg/RedfishPkg.dec | 5 +++++ RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf | 2 +- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/RedfishPkg/RedfishPkg.dec b/RedfishPkg/RedfishPkg.dec index cdb1528cedc9..0f18865cea0b 100644 --- a/RedfishPkg/RedfishPkg.dec +++ b/RedfishPkg/RedfishPkg.dec @@ -142,3 +142,8 @@ # This PCD indicates that if BMC bootstrap credential service will be di= sabled by BIOS or not. # gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService= |FALSE|BOOLEAN|0x00001007 + # + # The EFI_REST_EX_HTTP_CONFIG_DATA.SendReceiveTimeout value that Redfish= DiscoverDxe driver + # set to EFI_REST_EX_PROTOCOL. + # + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0x= 00001008 diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf b/Redfish= Pkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf index 950098bf6a0d..c982056fd700 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf @@ -54,4 +54,4 @@ =20 [Pcd] gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDiscoverAccessModeInBand ## CONSU= MES - + gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout ## CONSU= EMS diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPk= g/RedfishDiscoverDxe/RedfishDiscoverDxe.c index 17c88ad82db4..2f9e604f6cd6 100644 --- a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c +++ b/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c @@ -877,7 +877,7 @@ AddAndSignalNewRedfishService ( goto EXIT_FREE_CONFIG_DATA; } =20 - RestExHttpConfigData->SendReceiveTimeout =3D 5000; + RestExHttpConfigData->SendReceiveTimeout =3D PcdGet32= (PcdRedfishSendReceiveTimeout); RestExHttpConfigData->HttpConfigData.HttpVersion =3D HttpVers= ion11; RestExHttpConfigData->HttpConfigData.LocalAddressIsIPv6 =3D CheckIsI= pVersion6 (NetworkInterface); if (RestExHttpConfigData->HttpConfigData.LocalAddressIsIPv6) { --=20 2.17.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109744): https://edk2.groups.io/g/devel/message/109744 Mute This Topic: https://groups.io/mt/102038456/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-