From nobody Mon Feb 9 20:31:28 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109643+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109643+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1697462310; cv=none; d=zohomail.com; s=zohoarc; b=fgD1yH4MugWnFx96UvL/xmQi/Y6MK4vb6cSXPtz5baVpH2dfEfwxITbPF5Cfs66gz4IcQy7ifE1Af5sNPWEYvLG8sQPLuEUwB5T6p/3UBE6KwH88usrOq0bmx4r8NweUQzDPYAGsrCPp3EJ0v4UmkKNmrrAAPNdLLi1frIhafA0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697462310; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=iyoa/jlPTEovl3hNLQ1dqZ7ntwnAMYbSTxrTCi6/Pr8=; b=I+9pEROQ4yDO6A+fAYXtAtjEk2DKGMhivuI66ywZ+uCwJHi0h+SYLBqS3zbp/KZAGliXKrM1xcs3P5qHXyvJwlJhxJboHPjpI7gMWJ4Y4K67fCBnq4xaNQ8PRRLWpVsYPf7JVxzgOOhFChL2vXP+JyTxZN0XXUlG7QaOkiqPrCs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109643+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 169746231012859.893379174935035; Mon, 16 Oct 2023 06:18:30 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=WLB/EphbKJKqKF95fuXLvQh5Q5uu8Ld6iw/m1KIk7k4=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697462309; v=1; b=oCYXqq9qegaRyjS2F2iuGUmc+4g7wO5FCRFcoEnZAvonMrxTiYWlWtVzDsZRFCsEwfU9whXN rF3kaPf7Bzpj7zh4rvM11Y+qOTX2NHUGw1OJet9xGLbh6yv9GNWvkdl2JF5O+Gn3QFIyOQU7F9C mpSXYKyuST8u6BP7WNSoRj4s= X-Received: by 127.0.0.2 with SMTP id 5WQfYY1788612xsImbE9ty8Y; Mon, 16 Oct 2023 06:18:29 -0700 X-Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by mx.groups.io with SMTP id smtpd.web11.123866.1697462309013277007 for ; Mon, 16 Oct 2023 06:18:29 -0700 X-Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2c17de836fbso53876031fa.1 for ; Mon, 16 Oct 2023 06:18:28 -0700 (PDT) X-Gm-Message-State: M2tMz1EbVcLtRynHJuEe5NVZx1787277AA= X-Google-Smtp-Source: AGHT+IHzvLVCvJ2cUZqR1c5Gig8UZqGYuNUfKPXgoyChuvH2JuERK+KfyTw2nEsXROdXUt9IZUF5pw== X-Received: by 2002:a2e:a552:0:b0:2c5:13e8:e6d5 with SMTP id e18-20020a2ea552000000b002c513e8e6d5mr4946518ljn.23.1697462306910; Mon, 16 Oct 2023 06:18:26 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id 9-20020a2e1449000000b002ba586d27a2sm1362545lju.26.2023.10.16.06.18.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 06:18:26 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, isaac.w.oram@intel.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms 10/10] ManageabilityPkg: Return error on multiple-packet MCTP responses Date: Mon, 16 Oct 2023 16:18:16 +0300 Message-Id: <20231016131816.6634-11-aladyshev22@gmail.com> In-Reply-To: <20231016131816.6634-1-aladyshev22@gmail.com> References: <20231016131816.6634-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697462311715100041 Content-Type: text/plain; charset="utf-8" Since the current driver doesn't yet support handling of multiple-packet MCTP responses, return EFI_UNSUPPORTED error in such cases. Signed-off-by: Konstantin Aladyshev --- .../MctpProtocol/Common/MctpProtocolCommon.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/Mc= tpProtocolCommon.c index 4aae4fcba9..7cf2d916f4 100644 --- a/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/MctpProtocol/Common/MctpProtocolC= ommon.c @@ -524,6 +524,17 @@ CommonMctpSubmitMessage ( FreePool (ResponseBuffer); return EFI_DEVICE_ERROR; } + if ((MctpTransportResponseHeader->Bits.StartOfMessage !=3D 1) || + (MctpTransportResponseHeader->Bits.EndOfMessage !=3D 1) || + (MctpTransportResponseHeader->Bits.PacketSequence !=3D 0)) { + DEBUG (( + DEBUG_ERROR, + "%a: Error! Multiple-packet MCTP responses are not supported by the = current driver\n", + __func__, + )); + FreePool (ResponseBuffer); + return EFI_UNSUPPORTED; + } =20 MctpMessageResponseHeader =3D (MCTP_MESSAGE_HEADER *)(MctpTransportRespo= nseHeader + 1); if (MctpMessageResponseHeader->Bits.MessageType !=3D MctpType) { --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109643): https://edk2.groups.io/g/devel/message/109643 Mute This Topic: https://groups.io/mt/101994949/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-