From nobody Tue Feb 10 04:16:43 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109642+1787277+3901457@groups.io; helo=mail02.groups.io; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109642+1787277+3901457@groups.io; dmarc=fail(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1697462309; cv=none; d=zohomail.com; s=zohoarc; b=GRyPsEj18MDQN0ih2tRRHZhY/MeXI+oWhFxBGX9jcIdPN3Nw3IhysE1DCoC/thHpd14DctfVhiGiL9OvOvsugbgYs8gxQX1/Ox3RzhfLmQ1z06CC/D5kIKoPXZ5xGGGN3lxYv9T2OsFQuiDxKRADVRFTtKA4DoB5Re2ISEKCzsI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1697462309; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Id:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=+JDcPeQuZuJwlMPCK3XuiCEISGxl9sj183snD6qA3GM=; b=S93ztnFg2UGOgrpEsrQ1YpH3ea1bK70Zt1/Fme0jAcbVXymxHqkUP+lLt2iWpkPy/1VITNVdPn09PQLsfe2FZhVDFqHUe9pYUrcU7NBe4HvjNEqrqvrYhFmm7NIPNcdUFEba5RWGt6dUsAmMOYhYX0o+tfeZA7Ta7Q7/WmIXs1k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109642+1787277+3901457@groups.io; dmarc=fail header.from= (p=none dis=none) Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 1697462309159431.07634139487186; Mon, 16 Oct 2023 06:18:29 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=sVvSvXl4PFlnnk06LxXe62ZQ5oRLFUgTVt7OLwSmh0g=; c=relaxed/simple; d=groups.io; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding; s=20140610; t=1697462308; v=1; b=LaRmgQorPVabvVQ+/qPKvaAywwn8BMJ9xKUEKrLPC9idNYeWHmvUNx/luH8h48EqvtuMBdL3 lyAn2fvrUmUkrc2QqWbbwBxK/mP7cEG0+7OW2bq9SlhgHfKMBVf9+r4LwBM6yaE+FJBXtuPowP1 OD5//ZyumFnKYrbXfho/bvfI= X-Received: by 127.0.0.2 with SMTP id GRkIYY1788612x6Wmk07yQ7Q; Mon, 16 Oct 2023 06:18:28 -0700 X-Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by mx.groups.io with SMTP id smtpd.web10.123816.1697462307983768733 for ; Mon, 16 Oct 2023 06:18:28 -0700 X-Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2c51388ccebso23845471fa.3 for ; Mon, 16 Oct 2023 06:18:27 -0700 (PDT) X-Gm-Message-State: nDkaSLovg56pHMDEZmoNbka6x1787277AA= X-Google-Smtp-Source: AGHT+IEVlLJ662Dgs0XHlS0G1EXjIkUgO02TwqN+9DOtoabu6Uhu+9xFOy9easoYWWA5s4GXVBxp+Q== X-Received: by 2002:a2e:5109:0:b0:2c5:1a8e:e4c9 with SMTP id f9-20020a2e5109000000b002c51a8ee4c9mr3695169ljb.31.1697462305893; Mon, 16 Oct 2023 06:18:25 -0700 (PDT) X-Received: from PC10319.67 ([82.97.198.254]) by smtp.googlemail.com with ESMTPSA id 9-20020a2e1449000000b002ba586d27a2sm1362545lju.26.2023.10.16.06.18.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 06:18:25 -0700 (PDT) From: "Konstantin Aladyshev" To: devel@edk2.groups.io Cc: abner.chang@amd.com, isaac.w.oram@intel.com, AbdulLateef.Attar@amd.com, nicklew@nvidia.com, Konstantin Aladyshev Subject: [edk2-devel] [PATCH edk2-platforms 09/10] ManageabilityPkg: Use correct constants for PLDM header checks Date: Mon, 16 Oct 2023 16:18:15 +0300 Message-Id: <20231016131816.6634-10-aladyshev22@gmail.com> In-Reply-To: <20231016131816.6634-1-aladyshev22@gmail.com> References: <20231016131816.6634-1-aladyshev22@gmail.com> MIME-Version: 1.0 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,aladyshev22@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697462309464100033 Content-Type: text/plain; charset="utf-8" Currently PldmProtocol code uses magic numbers in the PLDM header checks. Since PLDM headers have all the necessary definitions replace magic numbers with the appropriate defines. Signed-off-by: Konstantin Aladyshev --- .../Universal/PldmProtocol/Common/PldmProtocolCommon.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmPr= otocolCommon.c b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/Pl= dmProtocolCommon.c index 1c4506d87f..3deded541a 100644 --- a/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c +++ b/Features/ManageabilityPkg/Universal/PldmProtocol/Common/PldmProtocolC= ommon.c @@ -321,15 +321,15 @@ CommonPldmSubmitCommand ( // // Check the integrity of response. data. ResponseHeader =3D (PLDM_RESPONSE_HEADER *)FullPacketResponseData; - if ((ResponseHeader->PldmHeader.DatagramBit !=3D 0) || - (ResponseHeader->PldmHeader.RequestBit !=3D 0) || + if ((ResponseHeader->PldmHeader.DatagramBit !=3D PLDM_MESSAGE_HEADER_IS_= DATAGRAM) || + (ResponseHeader->PldmHeader.RequestBit !=3D PLDM_MESSAGE_HEADER_IS_R= ESPONSE) || (ResponseHeader->PldmHeader.InstanceId !=3D mPldmRequestInstanceId) = || (ResponseHeader->PldmHeader.PldmType !=3D PldmType) || (ResponseHeader->PldmHeader.PldmTypeCommandCode !=3D PldmCommand)) { DEBUG ((DEBUG_ERROR, "PLDM integrity check of response data is failed.= \n")); - DEBUG ((DEBUG_ERROR, " Request bit =3D %d (Expected value: 0)\n")); - DEBUG ((DEBUG_ERROR, " Datagram =3D %d (Expected value: 0)\n")); + DEBUG ((DEBUG_ERROR, " Request bit =3D %d (Expected value: %d)\n",= PLDM_MESSAGE_HEADER_IS_RESPONSE)); + DEBUG ((DEBUG_ERROR, " Datagram =3D %d (Expected value: %d)\n",= PLDM_MESSAGE_HEADER_IS_DATAGRAM)); DEBUG ((DEBUG_ERROR, " Instance ID =3D %d (Expected value: %d)\n",= ResponseHeader->PldmHeader.InstanceId, mPldmRequestInstanceId)); DEBUG ((DEBUG_ERROR, " Pldm Type =3D %d (Expected value: %d)\n",= ResponseHeader->PldmHeader.PldmType, PldmType)); DEBUG ((DEBUG_ERROR, " Pldm Command =3D %d (Expected value: %d)\n",= ResponseHeader->PldmHeader.PldmTypeCommandCode, PldmCommand)); --=20 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109642): https://edk2.groups.io/g/devel/message/109642 Mute This Topic: https://groups.io/mt/101994947/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-