From nobody Mon May 13 03:46:05 2024 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce+27952+109576+1787277+3901457@groups.io; arc=fail (BodyHash is different from the expected one); dmarc=fail(p=none dis=none) header.from=arm.com Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by mx.zohomail.com with SMTPS id 169713075000259.14235782326034; Thu, 12 Oct 2023 10:12:30 -0700 (PDT) Return-Path: DKIM-Signature: a=rsa-sha256; bh=qf/XDc2X0cuw+6L85rG865JcIltWoOQuXTeaMYRUhAo=; c=relaxed/simple; d=groups.io; h=Received-SPF:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:Received-SPF:From:To:CC:Subject:Date:Message-ID:MIME-Version:NoDisclaimer:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Transfer-Encoding:Content-Type; s=20140610; t=1697130749; v=1; b=K5Pj01L+jx30vaNyf2fDiVnMCc6E1L0GPpNujHoYf73Gs7cvoVX1aUE2uDAKN5MNGsH7Kd2k ByOgmARzyqRXeZRCHKaFnrzQ7vn7qbAcMlndPmuMzbiYE/W3t2xpQCbVOBWTZWe40SKQE52XkzC uVyO0BCBGu3/x+TkwlI9W5yM= X-Received: by 127.0.0.2 with SMTP id 4v7dYY1788612xMPqCIX3MFt; Thu, 12 Oct 2023 10:12:29 -0700 X-Received: from EUR03-DBA-obe.outbound.protection.outlook.com (EUR03-DBA-obe.outbound.protection.outlook.com [40.107.104.88]) by mx.groups.io with SMTP id smtpd.web10.17952.1697130748336353650 for ; Thu, 12 Oct 2023 10:12:29 -0700 X-Received: from DUZPR01CA0102.eurprd01.prod.exchangelabs.com (2603:10a6:10:4bb::9) by VI1PR08MB5534.eurprd08.prod.outlook.com (2603:10a6:803:135::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.45; Thu, 12 Oct 2023 17:12:14 +0000 X-Received: from DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:4bb:cafe::c9) by DUZPR01CA0102.outlook.office365.com (2603:10a6:10:4bb::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.27 via Frontend Transport; Thu, 12 Oct 2023 17:12:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: pass (zohomail.com: domain of groups.io designates 66.175.222.108 as permitted sender) client-ip=66.175.222.108; envelope-from=bounce+27952+109576+1787277+3901457@groups.io; helo=mail02.groups.io; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C X-Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT042.mail.protection.outlook.com (100.127.142.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.27 via Frontend Transport; Thu, 12 Oct 2023 17:12:14 +0000 X-Received: ("Tessian outbound 9aeaca65ec26:v211"); Thu, 12 Oct 2023 17:12:14 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: bf57b8d32cf04285 X-CR-MTA-TID: 64aa7808 X-Received: from 130945d26856.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 876AF714-51B0-44D5-A938-E9516813F61E.1; Thu, 12 Oct 2023 17:12:02 +0000 X-Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 130945d26856.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 12 Oct 2023 17:12:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GhEld4c3ubeYVIiZc4ktZczdezn/rvxF6laGmO1+moUOeiw8nMExAclN7SQdxid/uyVlCwIdSgndXgTeSyHAsoVe9nE87m5WYyrVBvTPQRp4z7C8F7QCyQnIm5j6VfY3y+HOtESzgcgSanUwDFvGiD4RSXAZuj95hsYK0Khldb08MleFlRBAhTOcMRhTh8yO60kYltBWHHd/FVe5tcHpfSLOXzZ1APvMqNHtXTf431I8aW+uxCuJ9K9ombEPzB6lLBUcoEgUj2biiuYS4TuOPpLfrF5KqIfvraH5p4lq+Y4mEpx7ctsLykTfuU6eMWM4R3TAFEQPMm8bVdRgOT6I8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6+nFLOIsynHkFbTIRcFLWDLUAgBja0iGCs7Ojf3XdSI=; b=Q1JnYWa3Q1sixIwoRfqPBoRQJaSoCGypCv+UQWsrRdVg3ovKGT/hkBdrL/8Tn+pAqOKTNZsrtkIQvfVmI+wKvkRJqLO1rdDEmqxJ3ZAos28huOdkDnp0ywBrXfBCyLtgH+CEMQwpmu+n1ChGaBfJXXWP95+TyPv3WV44oTcFZChfLRNF2bNeUut6rsvaf771xRv2P9hovfR57RUy2BfqpPabubHKRzfLBqgeNzYLMjykJKfybxIP4R8UiEsarkGWZkFu1ZJUFQ/GGMNjdOD3A2W0P4I+8728dyL4HWYn9YmF5nM3Bv7+sfFKnij8IOT7Fc8NISl/Zq2tthFKdYv+0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=none (message not signed); arc=none X-Received: from AS9PR05CA0017.eurprd05.prod.outlook.com (2603:10a6:20b:488::25) by VI0PR08MB10711.eurprd08.prod.outlook.com (2603:10a6:800:20c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.42; Thu, 12 Oct 2023 17:11:59 +0000 X-Received: from AM7EUR03FT046.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:488:cafe::a8) by AS9PR05CA0017.outlook.office365.com (2603:10a6:20b:488::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.30 via Frontend Transport; Thu, 12 Oct 2023 17:11:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 40.67.248.234 as permitted sender) receiver=protection.outlook.com; client-ip=40.67.248.234; helo=nebula.arm.com; pr=C X-Received: from nebula.arm.com (40.67.248.234) by AM7EUR03FT046.mail.protection.outlook.com (100.127.140.78) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6886.31 via Frontend Transport; Thu, 12 Oct 2023 17:11:59 +0000 X-Received: from AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 12 Oct 2023 17:11:59 +0000 X-Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX02.Emea.Arm.com (10.251.26.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 12 Oct 2023 17:11:58 +0000 X-Received: from e129823.cambridge.arm.com (10.1.197.6) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.2507.32 via Frontend Transport; Thu, 12 Oct 2023 17:11:58 +0000 From: "levi.yun" To: CC: , , , , , , , , , Subject: [edk2-devel] [PATCH] Basetools: Include PCD declarations from Library Instance Date: Thu, 12 Oct 2023 18:11:55 +0100 Message-ID: <20231012171155.3262128-1-yeoreum.yun@arm.com> MIME-Version: 1.0 X-EOPAttributedMessage: 1 X-MS-TrafficTypeDiagnostic: AM7EUR03FT046:EE_|VI0PR08MB10711:EE_|DBAEUR03FT042:EE_|VI1PR08MB5534:EE_ X-MS-Office365-Filtering-Correlation-Id: fc52435f-e190-40da-b33c-08dbcb46614a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: gD8V+buSk08CpyrQh8dQ4/coZTeMeDNafWORcvN9WriJbQJHiJ3wu081sCsxjmRGrGxWhx7RrsmTzBtcsUbRnb3mLwKOUT1ZznYIKi0RniYbzN/SYqP2cbEv4J22O825HhXv8uQ04/ZrnAq+r37qZPYM2NZXKOjB6VQ0j1mxNng7f8cS6Rp4pcFhUMCWl96R8txX3r3aY0Tt/t8SNHsLUnPE4hGCqnLzrtHpwsFM7sq3ZmEUnnk4Ve+0dyGKEFa8meBgn5Qln+qFWZPsHFP4I5pUJUljFGhXNWN6VbmxjhAFztRZvcQrIcBN7pwz5E5UuNEF6myKRI0DoN8HJTU+CNrkz1wUaT8uU/30HAUVNBEsgB/2lP4mWPHgVae3HN8oKGR2bRWTGpOe1WeJ8+oFJ35Rerj6icBN5tnJZK3dlkLCE+jC/josPCf6Rf7YSBylPArzA9Z3hjx75MBPNpdU6tpFPENsk5Dl6YAkm4R1M51tlNuovrcb72GLLRmt03hjwZ1LzWGu/Fngf16ggOcYPhSfRSui5uPeieV15uEVqyQvlVhC6V+S4tOIEdHw7+ktNJctJo+MlzHCWuFPd1jrywx+ESVbwXE415iRnzmwS9DZxIhQ0gwSlyGZIDjseDBfD4qwVdcGDq6fmgasum6FRHJG3WjK4WdTCC+x1/rfSCx854bfmsiNKc77Yi6JqME+t6zk2a0sK3ZHMOSUHqDXJg7902ggvNa/BUv4Ov7V71bCi3g/uZvFsXhSvev1slU+OAPRcC8o+3Jt4ugTgPzA/VqLN2O8nz74IbE5+L92EFY= X-Forefront-Antispam-Report-Untrusted: CIP:40.67.248.234;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:nebula.arm.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(346002)(396003)(136003)(376002)(39860400002)(230922051799003)(82310400011)(451199024)(64100799003)(186009)(1800799009)(36840700001)(46966006)(40470700004)(4326008)(336012)(426003)(1076003)(26005)(8676002)(8936002)(40460700003)(40480700001)(47076005)(82740400003)(86362001)(81166007)(356005)(2906002)(36860700001)(36756003)(5660300002)(83380400001)(41300700001)(7696005)(966005)(478600001)(6916009)(54906003)(6666004)(70206006)(70586007)(2616005)(316002)(36900700001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI0PR08MB10711 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: c8c213e9-f481-4ab1-4301-08dbcb465881 X-Microsoft-Antispam-Message-Info: PVu+esESnnvyLWGsaZjCwBnRC87rZrJiRv9jT24WE0XHN+HrjjZqEgRSFWjw8IIToMkrEZpYO/i56bAZv8G4uARog0EE6wdHho6Fi1RKKkkezJvBn3Jaxlf/XqzGxZdF7cKodwvsLKuOfkdUrnmN9WnuZrmHlnpzjVftnjzGHDFtpgJVuXgb3K+Y+CAOFAQYtJpqaOLr49bRx32f8igSQfvGVJFqAKCD+rbkkZ8sbFr/0pu56W8rDz2uu+ug0wDzOWNJ8vTNSfeQtAuQKi0WRBRcLrJIBzI34R5m7s6yt6ssmGHXmZT8GNADQAjIVD6x6CGbgAP5JrxoSQnzS5UBmB7MCXkgEqYhFzQrjA5cid3PSYpZJjvfI8E0KlDdNbzG0bvJTDmRHJF9kF4pMVmgQXmzlF1PuYrEV3GJAHTae4/SZFNxs+FEwlI7b8c/dIw644JQStrMc4oQdZHSnWFgL+2v8V10FE3j+/eQ2Ir1iF0RBYPBE1Ng4daRj1atrJN6SzMBkfdgb83L6d6qxPugWHo/Ykf0SeIb7SM4nESCvnR5CL1XvLdFQzq5lmy6iPV9nmldS/9EM/ZJr3ZC68iJGIP25L4H7pRqt6F0yS+Dp5uskoAARoY7x4vtu6PfcnmjOE5Efgl/zLIl2loLurnliZBYJ2iJFk/F0JO9pcteTnw0hJW1FJeD+C+zQoCw01zCcQ7EKYR6WZB2F0fPcn65JQHVwyMN3PcoBMf67C9du62KuMCn6OmEdaJ4jEVPytfdXEUZVDrFbEXL9Nk3ekK89g== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Oct 2023 17:12:14.3335 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fc52435f-e190-40da-b33c-08dbcb46614a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT042.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB5534 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,yeoreum.yun@arm.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: jESaM4SfasMtMUn7lOfjnG0Ox1787277AA= Content-Transfer-Encoding: quoted-printable X-ZohoMail-DKIM: pass (identity @groups.io) X-ZM-MESSAGEID: 1697130750773100001 Content-Type: text/plain; charset="utf-8" The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver architecture independent" (https://edk2.groups.io/g/devel/message/109178) removed ArmPkg/ArmPkg.dec from the Packages section in the INF file: StandaloneMmPkg/Drivers/StandaloneMmCpu/StandaloneMmCpu.inf This change was done as part of making the StandaloneMmCpu driver architecture independent. Although this change is correct, it results in a side effect here some platforms that utilise PCDs declared in ArmPkg.dec are no longer declared. An example of this issue can be seen when building edk2-platforms/Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc $ build -a AARCH64 -t GCC -p Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc build.py... /mnt/source/edk2-platforms/Platform/ARM/SgiPkg/PlatformStandaloneMm.fdf(23): error F001: PCD (gArmTokenSpaceGuid.PcdFdBaseAddress) used in FDF is not declared in DEC files. As seen above, removing ArmPkg.dec from the Packages section in the StandAloneMmCpu Driver Inf file triggers build failure. Although, ArmPkg.dec is included in other Library Instances, the build system does not include the declarations from .dec files defined in Library instances. The build system only includes the PCD declarations from DEC files that are specified in INF files for Modules (components). Therefore, extend the build system to include the Packages from Library Instances so that the PCD declarations from the respective package DEC files are included. This patch can be seen on https://github.com/LeviYeoReum/edk2/tree/levi/2848_dec_check_on_library Signed-off-by: levi.yun Reviewed-by: Rebecca Cran Reviewed-by: Sami Mujawar Tested-by: Pierre Gondois --- BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py b/BaseTool= s/Source/Python/AutoGen/WorkspaceAutoGen.py index f86c749c08c3bb2837a88b5872101bc69e8bf7a0..f52ef42045da52c3d4f20277c61= 542f659eb7874 100644 --- a/BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py +++ b/BaseTools/Source/Python/AutoGen/WorkspaceAutoGen.py @@ -439,6 +439,10 @@ class WorkspaceAutoGen(AutoGen): PkgSet =3D set() for mb in [self.BuildDatabase[m, Arch, self.BuildTarget, self.= ToolChain] for m in Platform.Modules]: PkgSet.update(mb.Packages) + + for lb in [self.BuildDatabase[l, Arch, self.BuildTarget, self.= ToolChain] for l in Platform.LibraryInstances]: + PkgSet.update(lb.Packages) + for Inf in ModuleList: ModuleFile =3D PathClass(NormPath(Inf), GlobalData.gWorksp= ace, Arch) if ModuleFile in Platform.Modules: @@ -968,4 +972,3 @@ class WorkspaceAutoGen(AutoGen): # def CreateAsBuiltInf(self): return - -- Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") IMPORTANT NOTICE: The contents of this email and any attachments are confid= ential and may also be privileged. If you are not the intended recipient, p= lease notify the sender immediately and do not disclose the contents to any= other person, use it for any purpose, or store or copy the information in = any medium. Thank you. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109576): https://edk2.groups.io/g/devel/message/109576 Mute This Topic: https://groups.io/mt/101922917/1787277 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [importer@patchew.org] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-